Received: by 2002:ab2:1347:0:b0:1f4:ac9d:b246 with SMTP id g7csp302320lqg; Thu, 11 Apr 2024 03:33:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV3EXGT6LfoCfbMNK+fksOrB/ADjJX4o6BhZOh3dcCFsGvBVG0nWPNj7t1/rCeQ+c3pY0yEmFnSISNUUuwggLks2FbNLFkTYq2b7ONcsg== X-Google-Smtp-Source: AGHT+IEJAi1gF1Iol0AlkhC8dSu2PFKmu2W+Zp1MCT2T0HHoa0OxfRpFnhjXDry1NsqSzhZFCq5G X-Received: by 2002:a05:620a:46ac:b0:78e:c0da:994f with SMTP id bq44-20020a05620a46ac00b0078ec0da994fmr2026972qkb.54.1712831628206; Thu, 11 Apr 2024 03:33:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712831628; cv=pass; d=google.com; s=arc-20160816; b=pzq8ViG7PUEJcQcgjxrkRecxn1b4nKgDrnqJ/Cey+JMPHwTQkHB90wwHxyB+/Vp97E zIABRnZCKk4eZ9TQI2YYye7Ki1y1lSDj3yHUzcZz5Yq+SaFm7m4kwZi6PK+xsQH+D5uh 07Q/O+JRNTj1wEkZy+CQFdfnjvZAXqQesF1rk42jfRAb7WcmgY2EZTCp3ctnp2VuV6mW M43OZ2dxOkz2CDB0jgK9AzVfpsBawecMXJ5Eb9QsBQGSsy0ZE6p+y6r5OqosnEIKpmD0 vKXSj2HmxYqblD6HhGormhdplI2wd7y/pK/zN1DxVMsAN8wzQatfRUGe9SM2Sua0CYcF mvzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gcnjoJrjLylLXAH3rtU2vKqJq2FaC8fgwxIrZFCTV4c=; fh=+CCjMFwEciID7sKQLwBCFEkJa1ozRr7AoQACaG61tRs=; b=ezYHm/0xlj53CKKGwo0LOMUzxIa38PzXlpamMxBiz4JPPspS+ru65X7IHCdYPHvtKx 6KLr/soKPjlHW+pKffbQOauH/CZY6KyP1FZpBviGRKNYWxONJX0NRifj4EABpm5a/eoO QDO+wl5VrYEZ4dPXpScfuz+IfDARFS3yX6jO2o3frxF/ijf5D44cYcmFoazhWLtNiXwA sqcA+te/P3inR1DzeCUQjkvlrOvgVE3txLWebJUVpDmAZupl0ydh3SglVLBJc0OdIKWz Wzh0kLE+D5W1S2h95AuBle9y8fgSDhDfuP5/vn1k55sgWXfdawipfAQA1AboPk8k9D15 vIMA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X9pcmQrL; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-140253-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140253-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id bs19-20020a05620a471300b0078ec65d1b57si341564qkb.358.2024.04.11.03.33.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 03:33:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-140253-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X9pcmQrL; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-140253-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140253-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5D1D41C21989 for ; Thu, 11 Apr 2024 10:33:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 098BE14BF91; Thu, 11 Apr 2024 10:31:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X9pcmQrL" Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EEA014B07B for ; Thu, 11 Apr 2024 10:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712831498; cv=none; b=cg2Il6EhyZeCcAwbEHsunif353xFIOUUlM9u+ksVWaYaL4444+zcT+PDhQYrwG9aLmOGhJOdVYY9bvaP9VcK1ovIJ5tV0sMd1wOh/zHhMDhHDPxUGAZHcrZsKVAX8cLBNqWSzyWKGLmL0VaGDgGdXmsJ9kGZ2xyZCfq2si65aTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712831498; c=relaxed/simple; bh=WaXysxKJe+vS1i8j5oNGaoke2Hd03sYBfChSAqV5DuU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eTjGM1LZt7/O0gG+3PiuLkfpNvCSfP+Xpax0Tt/G1DRblHwNm/S9MnHPHZtBjb+m/4/5NdsJQLPR+qz5OEHO3lsyI4K/6nH/6Hb3dSlY3wiQxCJ9uPy6FlnlvaDx329UJ8p6BxZ59nv8W84aCs/QJRixGdwmL3e2sPrMIIgQBtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=X9pcmQrL; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a522715519bso35660966b.3 for ; Thu, 11 Apr 2024 03:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712831494; x=1713436294; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gcnjoJrjLylLXAH3rtU2vKqJq2FaC8fgwxIrZFCTV4c=; b=X9pcmQrLIlBOqIqdWBYOi6BbTZyrOy0WDTlLlM9aR2rZy00a11AVoM1d/I5vuXgz4y hlBZwSoXZy1Z+xLOzRINP2sAlNRtKZr/wVCLADfIreAK704WxjhVNCMmqaSjacX9f5O9 wI93CZGmvdcNNXstf1e/fLKBARp/1ieP87oCNbTJMDSU6ExdSH+gkmXNtY+TYe4WazsV t9r86dzKsM/BaHAsP3VwguoABsO6ogtzeK0bZ9u0iXlijJl/dmlPGpdds127ABt3nSJn JEHG65cU38v4HGuLa13ttkRkLeD5jeyZnyeUm+eQMDK2P/SxFHMlV+W/w4RINc0Hmbk5 93qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712831494; x=1713436294; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gcnjoJrjLylLXAH3rtU2vKqJq2FaC8fgwxIrZFCTV4c=; b=eoIZelKVjGLWiLhM2Aq5BVKzx2MNjTmimi0s70sWNMvcKgyZ807FHvmvP4TUDiSXBd yert7N4miOPk60HSZkf3NFcnE0jOpGzV9WHEMngUqXYUaEpZqPTSsX0u+ne6M912RJuM VZAaA5dkKqbGBqK+cbS2wIN+MhMdsjbxNcMlAgd5SxUG4kwPUgN9ekfMKRpBGPfS/qQg cDPVcBe64hOzNXwIW8vc7uW/2YgvuB07feuFW93f4OhBH19zWKXNrtefATlgiqog+iE9 +xUmfyAlK8sIZ4xZGeFwF0L3DYZapbHDGqkJUztwRzJUtrMaEwukBj0Un5CrP749wa2L G6Bw== X-Forwarded-Encrypted: i=1; AJvYcCWyiskW3nha/narOf8/ix1QQPtBsjM6MHeJVEz2WQmIneqEHQMEtPEKkQi7rUnpzbGkes1fug5u72rmQuJ/84n/hvQylTQPiFQ6+yAc X-Gm-Message-State: AOJu0Ywod2LZU7Ch1PAD3NpyCCkWJKF2oXeIB5CG4s9sc6VhBRY1cDDA qrTya1AD/9u6LPw0saDfiOqrTywrWRReYYWzgwzTlnGnl8KCtcyp9+r3l4/vUVI= X-Received: by 2002:a17:907:9302:b0:a52:1466:4d1b with SMTP id bu2-20020a170907930200b00a5214664d1bmr3301095ejc.17.1712831494384; Thu, 11 Apr 2024 03:31:34 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id kk7-20020a170907766700b00a51def4861bsm618040ejc.91.2024.04.11.03.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 03:31:34 -0700 (PDT) Date: Thu, 11 Apr 2024 13:31:30 +0300 From: Dan Carpenter To: Tung Quang Nguyen Cc: Colin Ian King , Jon Maloy , Ying Xue , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "netdev@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][next] tipc: remove redundant assignment to ret, simplify code Message-ID: References: <20240411091704.306752-1-colin.i.king@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 11, 2024 at 10:04:10AM +0000, Tung Quang Nguyen wrote: > > > I suggest that err variable should be completely removed. Could you > please also do the same thing for this code ? > " > ... > err = skb_handler(skb, cb, tsk); > if (err) { If we write the code as: if (some_function(parameters)) { then at first that looks like a boolean. People probably think the function returns true/false. But if we leave it as-is: err = some_function(parameters); if (err) { Then that looks like error handling. So it's better and more readable to leave it as-is. regards, dan carpenter