Received-SPF: pass (google.com: domain of linux-kernel+bounces-140277-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: multipart/signed;
 boundary=f7bcb3103797fb11dc8c9e325de0ccbdaba3a8a308f4ddca767ec9ae9a6c;
 micalg=pgp-sha384; protocol="application/pgp-signature"
Date: Thu, 11 Apr 2024 12:46:32 +0200
Message-Id: <D0H8EQB97VFA.2P27K85EJXCTB@kernel.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>, "Bartosz Golaszewski"
 <brgl@bgdev.pl>
From: "Michael Walle" <mwalle@kernel.org>
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
 <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] gpio: regmap: Use -ENOTSUPP consistently
References: <20240410063930.1199355-1-andy.shevchenko@gmail.com>
In-Reply-To: <20240410063930.1199355-1-andy.shevchenko@gmail.com>
Precedence: bulk

--f7bcb3103797fb11dc8c9e325de0ccbdaba3a8a308f4ddca767ec9ae9a6c
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Andy,

On Wed Apr 10, 2024 at 8:39 AM CEST, Andy Shevchenko wrote:
> The GPIO library expects the drivers to return -ENOTSUPP in some cases
> and not using analogue POSIX code. Make the driver to follow this.

I don't care too much, so if you like you can add

Reviewed-by: Michael Walle <mwalle@kernel.org>

But.. isn't it the wrong errno and isn't it discouraged to use it
because it's a NFS only errno? Thus, wouldn't it make more sense for
the core to accept EOPNOTSUPP and maybe convert it to ENOTSUPP if we
don't want to break userspace?

-michael

> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>  drivers/gpio/gpio-regmap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
> index c08c8e528867e..71684dee2ca5d 100644
> --- a/drivers/gpio/gpio-regmap.c
> +++ b/drivers/gpio/gpio-regmap.c
> @@ -129,7 +129,7 @@ static int gpio_regmap_get_direction(struct gpio_chip=
 *chip,
>  		base =3D gpio_regmap_addr(gpio->reg_dir_in_base);
>  		invert =3D 1;
>  	} else {
> -		return -EOPNOTSUPP;
> +		return -ENOTSUPP;
>  	}
> =20
>  	ret =3D gpio->reg_mask_xlate(gpio, base, offset, &reg, &mask);
> @@ -160,7 +160,7 @@ static int gpio_regmap_set_direction(struct gpio_chip=
 *chip,
>  		base =3D gpio_regmap_addr(gpio->reg_dir_in_base);
>  		invert =3D 1;
>  	} else {
> -		return -EOPNOTSUPP;
> +		return -ENOTSUPP;
>  	}
> =20
>  	ret =3D gpio->reg_mask_xlate(gpio, base, offset, &reg, &mask);


--f7bcb3103797fb11dc8c9e325de0ccbdaba3a8a308f4ddca767ec9ae9a6c
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCZhe/iBIcbXdhbGxlQGtl
cm5lbC5vcmcACgkQEic87j4CH/isTwF/XCyGf2p6F7G12CDeKBlKMIQwJDLACieE
GTK8iuyzUoL/Legr4j1zapvm+nSkFwIYAYDkgBxqzP3KAplp1eybe6b9EJnZWrpm
Wx3JWhVVjnsw7IkRrxKcvW+3iKI+7QrsGYc=
=DFER
-----END PGP SIGNATURE-----

--f7bcb3103797fb11dc8c9e325de0ccbdaba3a8a308f4ddca767ec9ae9a6c--