Received: by 2002:ab2:1347:0:b0:1f4:ac9d:b246 with SMTP id g7csp312282lqg; Thu, 11 Apr 2024 03:59:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWeDrW9XXSxbAJSASMlfQXQkgfoC7MTmyHPRJ96XFvXGsUmAoOUIB2bm/TtdtAZ1/UV3DmiUbzBzNJyX7IBs91g8swy1wzzJ4wqy1MI6A== X-Google-Smtp-Source: AGHT+IEzfNXLXwSLWOyz/OOfqdNj//rVrvWEiYLBJAQGuNZ/V+JAoWNAjYkCR9wXGvazwWq1IHME X-Received: by 2002:a17:907:97cc:b0:a52:140c:5704 with SMTP id js12-20020a17090797cc00b00a52140c5704mr3547883ejc.6.1712833180456; Thu, 11 Apr 2024 03:59:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712833180; cv=pass; d=google.com; s=arc-20160816; b=Aq2qATBPibFKOB1ciUXVAcTKtCb4yv33NsRTqnt4niQowDUxA6IBRl7bkAFEtEVkXg MjjfI63n8GO1U0bnn+HWx3Ompw2kZn/Kma4frWnzsaS70bNBjjFRa/V7u9UHY8nlvEab 95TRMTBiW9kgOuKOF4wVWXgAe+N5iWGC8bAciGifm9QnNBnKuX3D9OT52CRLc+V4/VUq OmbVeHNmp0/ppad5QKtQVJxbE2eCNA+fLt8jgPbx5bjgzu0alJFyho2K0hHrrg4dTR5R 2quurRMWwPZMeZnpmALNL2mHA0hYKG2Tka1DDnsvxB2JycWZdoFswky0li/AxFs2MEdq rBJg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=g7JzacHZVp2MEF3+WsgvTN31EdflGCKbj1r/KL/9ijM=; fh=UTP4gncvCi+dXIZ6pRIg/skh4siquJRnTrK3ECilyUk=; b=d7B8mKxrMZpT25oMy7moh1WmskreygQQSWcy2RyXYHSdhVK9yacLEVRxj3Q8fVjGQI F6jLXEE8Dn4WdGr9ywlrEgeAWw697qmQU0MK1VHQgp74dWN/qq4cMmEOoQx2wKKwUOMI CtUPfaKrSkbeuiViNBa1NjhCGJ/sMg+08h9opR03Vtj15hqSyPRycAY20m3hEnBIQEBz n1Ku9B2BqoFNLW1hTGaiePsg2vJXDcETZfCWWik6uJ/iQONcesrOhVm88kEaOEmCGhMz jeDaevPaNUaSL2o9Kf1LIU1QS2msQmYSFFCSHCvRG2dsOO8xkxl/ZNo5Nu41EAezFQIt 5g9Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gGBKyPZg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-140297-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140297-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id i22-20020a170906115600b00a52122ea65csi632106eja.459.2024.04.11.03.59.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 03:59:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-140297-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gGBKyPZg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-140297-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140297-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 31B401F28EE2 for ; Thu, 11 Apr 2024 10:59:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7B95C145B13; Thu, 11 Apr 2024 10:59:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gGBKyPZg" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4BEA146591; Thu, 11 Apr 2024 10:59:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712833173; cv=none; b=fAh5MU37W0kCnw+AiiahGIzkWZT/jdyOqlYe9Y1UuP+X3bnbvKGiucWBUwZmqPuX/a3ZLG3ThWtiKyQa92dDPF1R0n2p8pNrA7mxLjQbDfytlRVKb1AY1odHqBGlqRPekkVvK5VFUTmTCTSxKVuOFv5Wa6RdhgGmSmvPWjLF2RM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712833173; c=relaxed/simple; bh=LkE30NYpF2o7SzMeclAi3/U/CTniH0WkbJ93S02QeA0=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=MsWlbbVUdRLccQcclHQVdmG3dJ9gTitHLsjGxBIyqh44qK8/qPJnBHuxMVruv1tc9Y9bgy3SR6xsj4XKOpSHmX+H6LuK3q3lDtMgSUcfcfJpkPkD2yPkL8y1+7oihtK/XFVJq7WqTki1cvF64QetfIGI4DlofOPVOPYQM5jYKCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gGBKyPZg; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4060EC433F1; Thu, 11 Apr 2024 10:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712833173; bh=LkE30NYpF2o7SzMeclAi3/U/CTniH0WkbJ93S02QeA0=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=gGBKyPZg2EGppsuNECaD/GTUmKioTdwoKkTNmfQ7J3oVUmZCmjO+iH0LpL3sf+8Mr qP/aFOWv3XVKTResT+dB1cSh4JlbWr3XaKhee1RkuJokwVQAuwGsjE9+tRvjtkNCLy e9XS6aeJS3Y157UZSz5mw+OsRLInbvhILiEK3cO8vzy+814949nkxJ50eB/TrtSGQp 1LrcnqKZ2yq0dN4K0G7Pd7bbrGoqQftimQbkxTqV/WxUDqqsLTQRcwfGSzD+8E/45M B4dZaw77nS8JUzNuLOnMPfMA58i/n5EbuPHc4SI5nkcNy2seLg3JhP3qhy130nDARB lZV8PlmZ8NSIA== From: Lee Jones To: andy.shevchenko@gmail.com, pavel@ucw.cz, lee@kernel.org, vadimp@nvidia.com, christophe.leroy@csgroup.eu, hdegoede@redhat.com, mazziesaccount@gmail.com, peterz@infradead.org, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, nikitos.tr@gmail.com, kabel@kernel.org, =?utf-8?q?Marek_Beh=C3=BAn?= , George Stark Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@salutedevices.com In-Reply-To: <20240314201856.1991899-1-gnstark@salutedevices.com> References: <20240314201856.1991899-1-gnstark@salutedevices.com> Subject: Re: [PATCH v7 0/8] devm_led_classdev_register() usage problem Message-Id: <171283316999.2296003.5529877568304975347.b4-ty@kernel.org> Date: Thu, 11 Apr 2024 11:59:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.4 On Thu, 14 Mar 2024 23:18:48 +0300, George Stark wrote: > This patch series fixes the problem of devm_led_classdev_register misusing. > > The basic problem is described in [1]. Shortly when devm_led_classdev_register() > is used then led_classdev_unregister() called after driver's remove() callback. > led_classdev_unregister() calls driver's brightness_set callback and that callback > may use resources which were destroyed already in driver's remove(). > > [...] Applied, thanks! [1/8] locking/mutex: introduce devm_mutex_init() commit: c1a17857f8e333aa597ce0099c8728888e0c5037 [2/8] leds: aw2013: use devm API to cleanup module's resources commit: aa2fb50d9f17185e799a5969d0d357842d07450b [3/8] leds: aw200xx: use devm API to cleanup module's resources commit: 517d9d3c408369cfa552652ac06294410c570095 [4/8] leds: lp3952: use devm API to cleanup module's resources commit: f8cf710c971e021e5ca39832adde32dfa241e081 [5/8] leds: lm3532: use devm API to cleanup module's resources commit: d265d86a2725e38c4f13ef79fc4e685b7234e7a3 [6/8] leds: nic78bx: use devm API to cleanup module's resources commit: 917676a8961e18e4dd5b17411317e3261473762a [7/8] leds: mlxreg: use devm_mutex_init() for mutex initialization commit: 0548081cb25fbd0eb3a605cb6647dd166368da32 [8/8] leds: an30259a: use devm_mutex_init() for mutex initialization commit: c898cf6eb464d4172c79e925ea4d8007e856e10c -- Lee Jones [李琼斯]