Received-SPF: pass (google.com: domain of linux-kernel+bounces-140300-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 11 Apr 2024 08:02:04 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Kan Liang <kan.liang@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCHSET 0/7] perf annotate: Add TUI support for data type
 profiling (v2)
Message-ID: <ZhfDLHH98rgl6_4P@x1>
References: <20240411033256.2099646-1-namhyung@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240411033256.2099646-1-namhyung@kernel.org>

On Wed, Apr 10, 2024 at 08:32:49PM -0700, Namhyung Kim wrote:
> Hello,
> 
> This is to support interactive TUI browser for type annotation.
> 
> v2 changes:
>  * fix build errors when libslang2 or libdw is missing  (Arnaldo)
>  * update commit messages with examples  (Arnaldo)
>  * skip updating sample histogram for stack canary  (Arnaldo)
>  * add Reviewed-by from Ian

Thanks, applied.

- Arnaldo
  
> Like the normal (code) annotation, it should be able to display the data type
> annotation.  Now `perf annotate --data-type` will show the result in TUI by
> default if it's enabled.  Also `perf report -s type` can show the same output
> using a menu item.
> 
> It's still in a very early stage and supports the basic functionalities only.
> I'll work on more features like in the normal annotation browser later.
> 
> The code is also available at 'perf/annotate-data-tui-v2' branch at
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> 
> Thanks,
> Namhyung
> 
> 
> Namhyung Kim (7):
>   perf annotate-data: Skip sample histogram for stack canary
>   perf annotate: Show progress of sample processing
>   perf annotate-data: Add hist_entry__annotate_data_tty()
>   perf annotate-data: Add hist_entry__annotate_data_tui()
>   perf annotate-data: Support event group display in TUI
>   perf report: Add a menu item to annotate data type in TUI
>   perf report: Do not collect sample histogram unnecessarily
> 
>  tools/perf/builtin-annotate.c          | 149 ++++--------
>  tools/perf/builtin-report.c            |   7 +-
>  tools/perf/ui/browsers/Build           |   1 +
>  tools/perf/ui/browsers/annotate-data.c | 312 +++++++++++++++++++++++++
>  tools/perf/ui/browsers/hists.c         |  31 +++
>  tools/perf/util/annotate-data.c        | 113 +++++++++
>  tools/perf/util/annotate-data.h        |  22 ++
>  tools/perf/util/annotate.c             |  12 +-
>  8 files changed, 534 insertions(+), 113 deletions(-)
>  create mode 100644 tools/perf/ui/browsers/annotate-data.c
> 
> 
> base-commit: 9c3e9af74326978ba6f4432bb038e6c80f4f56fd
> -- 
> 2.44.0.478.gd926399ef9-goog