Received-SPF: pass (google.com: domain of linux-kernel+bounces-140322-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 11 Apr 2024 19:14:38 +0800
From: Chao Gao <chao.gao@intel.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Alexandre Chartre <alexandre.chartre@oracle.com>, <x86@kernel.org>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<daniel.sneddon@linux.intel.com>, <pawan.kumar.gupta@linux.intel.com>,
	<tglx@linutronix.de>, <konrad.wilk@oracle.com>, <peterz@infradead.org>,
	<gregkh@linuxfoundation.org>, <seanjc@google.com>,
	<dave.hansen@linux.intel.com>, <nik.borisov@suse.com>, <kpsingh@kernel.org>,
	<longman@redhat.com>, <bp@alien8.de>, <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: x86: Set BHI_NO in guest when host is not affected
 by BHI
Message-ID: <ZhfGHpAz7W7d/pSa@chao-email>
References: <20240411072445.522731-1-alexandre.chartre@oracle.com>
 <7f1faa48-6252-4409-aefc-2ed2f38fb1c3@citrix.com>
 <caa51938-c587-4403-a9cd-16e8b585bc13@oracle.com>
 <d47dcc77-3c8b-4f78-954a-a64d3a905224@citrix.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d47dcc77-3c8b-4f78-954a-a64d3a905224@citrix.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nwhO6nD2CLPrnPSqHgjjwPqdEqMufP68NChFvx0DmFssattNYl7YqWRiewwJ?=
 =?us-ascii?Q?DeFgZtRWAfNn7Uqd90XQF/SHQqhiV4Q655KzIQz7/Wq+VYXESX9vnbpWRvyt?=
 =?us-ascii?Q?ZVcNzyL/EqEjvJplFkWIEKBqCw1/lN4D8HDcf4Y3DfS58nd2+eMGb29eohPE?=
 =?us-ascii?Q?727DjiD5GZVI61GZwtVttA/H/MpsRFSc1+hvZD9Bgja2iV9h9n4kkOB+IUVO?=
 =?us-ascii?Q?D0LbDf0fLvIAXdcDLVgmYhWinu48r+aK10SgckB1yyGBHxmfuFOGqS8wb9Q7?=
 =?us-ascii?Q?IIGQUfW3CKNVsfosBV9ksG8qBnxZEe3U5+ddoYbTR0QJh65zCh72UpFdZ6NQ?=
 =?us-ascii?Q?NStseqKRKqrVm3yfyrAY9/P0IKsJc10m+k0Pii3JqZL65nudtGtzkPUcFwui?=
 =?us-ascii?Q?S8Fob/wa1dXIeNT6F2TNiCL4WzOsjkKzcmdXCIZopNh6J5v6aFOgbmDTOwT1?=
 =?us-ascii?Q?xKaOF+akTe0r5XLUIMET7l6H9jlemv39SFbOwWyKLQsEWMdLvhRfVMBobgws?=
 =?us-ascii?Q?xSuBdNXjB2pyONqRnczbeCqE9LppajT4Q9ytb4owGMTJhyJhwBJ8ta3hOAKe?=
 =?us-ascii?Q?fUvaQ1pOpgnrVvE1SiT5jY/vGiT6VIEHApDx4+YBJo8Arz1MCGEXKF/Ln/9m?=
 =?us-ascii?Q?u8ES1hv47X7dglEUPoiM20q8doqENBzcyf87F8OxybHiqylCyl8W7DrACI1C?=
 =?us-ascii?Q?vjWpqd6QPX1iQwn0PajMZV5lyAHxj8IcG6uL5809qOng3bgrr4z/X71MJKaD?=
 =?us-ascii?Q?vG0uVnpUzZWz5iDNqrbcIOEvqlogA/omEQ2j9NxZxveKf6PzEqrvlFrGV0vr?=
 =?us-ascii?Q?7hF1ZKgF7wzX3JCUhWGXB+XcSF+VcgyCcx6EIaqi83KGOiuuX+4rSkRxgAGW?=
 =?us-ascii?Q?sU7/To0xCZwpFltHZcrYM55pZt5hCpM/7xAFq/L0+eUEJohdYc5QmTQwvRFN?=
 =?us-ascii?Q?1R9w4oLS64AiiOtDgJQVNaYXaJs5CwPX8bxC8rBTPdZYTIz2ZzWAXzdMajlp?=
 =?us-ascii?Q?HWQ48w3vXPmzQh8dOghNLyVV/qYmlhw2pEzZtJoN/+M5laxnjecvfZuD9DQ7?=
 =?us-ascii?Q?HjBPk+fUyF93kbGfD9z36I4rVDFa6fNBwl9r8l8dycO6WQ/T+tXXVimuRElx?=
 =?us-ascii?Q?9b6yCFMlZXfpB3Il9VKJq+ytH+QNr/7YjIPX8Uv2NildFaiF/FkUi7bXmJVC?=
 =?us-ascii?Q?9Qo0ccmti/b+ds1SFs2bkNpA/N/DgjOo+Ghhgo4y7XE0sW2lCRWdmb/O2AzX?=
 =?us-ascii?Q?q8D8A+iqBi1aSroYFzvDkNczbiXM9XninVDDkMQhnkyz5aVDoyLpTwnur8Vc?=
 =?us-ascii?Q?wSMqi4nSDB8njXzf1utguY9Jud5l8PlIeJoSTcpV9X05bNDgiSd9U6Xb9x0n?=
 =?us-ascii?Q?s9ywbM9htPT+IiLljKFA5CCptbWPx6K2bZxAlcxQzAweCtgwu6VhGE6eWsvC?=
 =?us-ascii?Q?9qvsoeRJhEZQoVZHsDP0V7ABYRjDHqrHMC+kE75Pqq2oiqgv27lBireBlgkb?=
 =?us-ascii?Q?kwzIL/9vMjjdewneR47mlAVUHmSsSGvDDm5PWcsgpGi4Q3+QyJhaRGHp3xQU?=
 =?us-ascii?Q?l4Y3m/Lvzdg6Ru/G7WLehPggepP+jD9/TaVug68r?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b0a33589-6438-4bc9-5574-08dc5a189ad7
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 11:14:50.4289
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jQpbx0vee8TPZ5kxtp2Y3JEIat+PdXGYsYp5v+1XOUzbqtXrNj3VKC4oE2AKC0uUDWE5I8tMmhSgcskTLlQw9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4831
X-OriginatorOrg: intel.com

>> The problem is that we can end up with a guest running extra BHI
>> mitigations
>> while this is not needed. Could we inform the guest that eIBRS is not
>> available
>> on the system so a Linux guest doesn't run with extra BHI mitigations?
>
>Well, that's why Intel specified some MSRs at 0x5000xxxx.

Yes. But note that there is a subtle difference. Those MSRs are used for guest
to communicate in-used software mitigations to the host. Such information is
stable across migration. Here we need the host to communicate that eIBRS isn't
available to the guest. this isn't stable as the guest may be migrated from
a host without eIBRS to one with it.

>
>Except I don't know anyone currently interested in implementing them,
>and I'm still not sure if they work correctly for some of the more
>complicated migration cases.

Looks you have the same opinion on the Intel-defined virtual MSRs as Sean.
If we all agree the issue here and the effectivenss problem of the short
BHB-clearing sequence need to be resolved and don't think the Intel-defined
virtual MSRs can handle all cases correctly, we have to define a better
interface through community collaboration as Sean suggested.