Received-SPF: pass (google.com: domain of linux-kernel+bounces-140375-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <adf9d74c-6f22-4653-a27d-c50f7320efd1@gmail.com>
Date: Thu, 11 Apr 2024 19:45:14 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 0/10] transfer page to folio in KSM
To: David Hildenbrand <david@redhat.com>, alexs@kernel.org,
 Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, zik.eidus@ravellosystems.com,
 willy@infradead.org, aarcange@redhat.com, hughd@google.com,
 chrisw@sous-sol.org
References: <20240411061713.1847574-1-alexs@kernel.org>
 <db95e01f-9334-4db8-8f8b-83f25a7dda87@redhat.com>
Content-Language: en-US
From: Alex Shi <seakeel@gmail.com>
In-Reply-To: <db95e01f-9334-4db8-8f8b-83f25a7dda87@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/11/24 3:55 PM, David Hildenbrand wrote:
> On 11.04.24 08:17, alexs@kernel.org wrote:
>> From: "Alex Shi (tencent)" <alexs@kernel.org>
>>
>> This is the first part of page to folio transfer on KSM. Since only
>> single page could be stored in KSM, we could safely transfer stable tree
>> pages to folios.
>> This patchset could reduce ksm.o 57kbytes from 2541776 bytes on latest
>> akpm/mm-stable branch with CONFIG_DEBUG_VM enabled. It pass the KSM testing
>> in LTP and kernel selftest.
> 
> Just a nit (no need to address for this patch set): "transfer page to folio" sounds very misleading to me. I'm not a native speaker, but I'd have called this patch set
> 
> "mm/ksm: convert some KSM code to use folios"
> 
> It's rather code conversion/transformation, not a transfer.
> 
> But again, I'm not a native speaker ...
> 

Uh, me neither. but sounds you're right. I will take care this next time.

Thanks
Alex