Received-SPF: pass (google.com: domain of linux-kernel+bounces-140403-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: duchangbin <changbin.du@huawei.com>
To: duchangbin <changbin.du@huawei.com>
CC: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>, Vincent Guittot
	<vincent.guittot@linaro.org>, Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, "Mel
 Gorman" <mgorman@suse.de>, Daniel Bristot de Oliveira <bristot@redhat.com>,
	Valentin Schneider <vschneid@redhat.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/cputime: remove unused vtime_account_kernel
Thread-Topic: [PATCH] sched/cputime: remove unused vtime_account_kernel
Thread-Index: AQHajAKDIkVvBXkJoUKksEBvgpwDs7Fi+RMA
Date: Thu, 11 Apr 2024 12:05:48 +0000
Message-ID: <b1befac0501944919cd99f20c4bcecaa@huawei.com>
References: <20240411112212.2061899-1-changbin.du@huawei.com>
In-Reply-To: <20240411112212.2061899-1-changbin.du@huawei.com>
Accept-Language: en-US
Content-Language: zh-CN
x-ms-exchange-messagesentrepresentingtype: 1
Content-Type: text/plain; charset="us-ascii"
Content-ID: <02E6C0AB2AB5CE48B135099171E224ED@huawei.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0

The vtime_account_idle() can also be removed. Will update this change.

On Thu, Apr 11, 2024 at 07:22:12PM +0800, Changbin Du wrote:
> This removes the vtime_account_kernel() function in generic vtime
> accounting. It's never used anymore.
>=20
> Signed-off-by: Changbin Du <changbin.du@huawei.com>
> ---
>  kernel/sched/cputime.c | 12 ------------
>  1 file changed, 12 deletions(-)
>=20
> diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
> index af7952f12e6c..29320e66abdc 100644
> --- a/kernel/sched/cputime.c
> +++ b/kernel/sched/cputime.c
> @@ -709,18 +709,6 @@ static void __vtime_account_kernel(struct task_struc=
t *tsk,
>  		vtime_account_system(tsk, vtime);
>  }
> =20
> -void vtime_account_kernel(struct task_struct *tsk)
> -{
> -	struct vtime *vtime =3D &tsk->vtime;
> -
> -	if (!vtime_delta(vtime))
> -		return;
> -
> -	write_seqcount_begin(&vtime->seqcount);
> -	__vtime_account_kernel(tsk, vtime);
> -	write_seqcount_end(&vtime->seqcount);
> -}
> -
>  void vtime_user_enter(struct task_struct *tsk)
>  {
>  	struct vtime *vtime =3D &tsk->vtime;
> --=20
> 2.34.1
>=20

--=20
Cheers,
Changbin Du