Received-SPF: pass (google.com: domain of linux-kernel+bounces-140416-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240410205201.1885032-1-shorne@gmail.com>
In-Reply-To: <20240410205201.1885032-1-shorne@gmail.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 11 Apr 2024 14:12:59 +0200
Message-ID: <CAMuHMdV6W613FESO6EGTTJWoG=dfCbicyH49dywm-5O09SEi0Q@mail.gmail.com>
Subject: Re: [PATCH] openrisc: Add support for more module relocations
To: Stafford Horne <shorne@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Jonas Bonn <jonas@southpole.se>, 
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>, Eric Biederman <ebiederm@xmission.com>, 
	Kees Cook <keescook@chromium.org>, linux-openrisc@vger.kernel.org, linux-mm@kvack.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Stafford,

On Wed, Apr 10, 2024 at 10:52=E2=80=AFPM Stafford Horne <shorne@gmail.com> =
wrote:
> This patch adds the relocations. Note, we use the old naming R_OR32_*
> instead or the new naming R_OR1K_* to avoid change as this header is
> exported as a user api.

> --- a/arch/openrisc/include/uapi/asm/elf.h
> +++ b/arch/openrisc/include/uapi/asm/elf.h
> @@ -43,6 +43,8 @@
>  #define R_OR32_JUMPTARG        6
>  #define R_OR32_VTINHERIT 7
>  #define R_OR32_VTENTRY 8
> +#define R_OR32_AHI16   35
> +#define R_OR32_SLO16   39

Would it make sense to switch to the new names, e.g.

  #define R_OR1K_NONE        0

and add definitions for backwards compatibility?

    #define R_OR32_NONE        R_OR1K_NONE

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds