Received-SPF: pass (google.com: domain of linux-kernel+bounces-140440-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 11 Apr 2024 14:33:49 +0200
From: Alexander Gordeev <agordeev@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Xu <peterx@redhat.com>, Sven Schnelle <svens@linux.ibm.com>,
        Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
        Andrea Arcangeli <aarcange@redhat.com>, kvm@vger.kernel.org,
        linux-s390@vger.kernel.org
Subject: Re: [PATCH v2 2/2] s390/mm: re-enable the shared zeropage for !PV
 and !skeys KVM guests
Message-ID: <ZhfYrVERxUijQbAL@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
References: <20240327171737.919590-1-david@redhat.com>
 <20240327171737.919590-3-david@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240327171737.919590-3-david@redhat.com>

On Wed, Mar 27, 2024 at 06:17:37PM +0100, David Hildenbrand wrote:
> index 60950e7a25f5..1a71cb19c089 100644
> --- a/arch/s390/include/asm/pgtable.h
> +++ b/arch/s390/include/asm/pgtable.h
> @@ -566,10 +566,19 @@ static inline pud_t set_pud_bit(pud_t pud, pgprot_t prot)
>  }
>  
>  /*
> - * In the case that a guest uses storage keys
> - * faults should no longer be backed by zero pages
> + * As soon as the guest uses storage keys or enables PV, we deduplicate all
> + * mapped shared zeropages and prevent new shared zeropages from getting
> + * mapped.
>   */
> -#define mm_forbids_zeropage mm_has_pgste

Should it be the below insted?

#define mm_forbids_zeropage mm_forbids_zeropage

Once I add it, it fails to compile, due to the issue in patch #1.

But then I guess this series was tested with the generic
mm_forbids_zeropage() which always returns 0:

#define mm_forbids_zeropage(X)	(0)

> +static inline int mm_forbids_zeropage(struct mm_struct *mm)
> +{
> +#ifdef CONFIG_PGSTE
> +	if (!mm->context.allow_cow_sharing)
> +		return 1;
> +#endif
> +	return 0;
> +}
> +

Thanks!