Received-SPF: pass (google.com: domain of linux-kernel+bounces-140453-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <28c5456d-535c-4ed9-b13a-fab7f50412be@bootlin.com>
Date: Thu, 11 Apr 2024 14:44:44 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] pps: clients: gpio: Bypass edge's direction check
 when not needed
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: linux-kernel@vger.kernel.org,
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>, herve.codina@bootlin.com,
 christophercordahi@nanometrics.ca
References: <20240410113502.73038-1-bastien.curutchet@bootlin.com>
 <1f7f5b2f-54d4-4dc1-90ff-b896c930faed@enneenne.com>
 <5bda0980-2373-4284-bda4-89f0c6944e76@bootlin.com>
 <eb64ec08-2ae3-48bb-9f84-3cec362280b2@enneenne.com>
 <27196117-32bc-4892-b545-d9cf43a89f0a@bootlin.com>
 <c1e93cfe-371c-4855-9a13-b4b453bb9e88@enneenne.com>
Content-Language: en-US
From: Bastien Curutchet <bastien.curutchet@bootlin.com>
In-Reply-To: <c1e93cfe-371c-4855-9a13-b4b453bb9e88@enneenne.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Rodolfo

>>> diff --git a/drivers/pps/clients/pps-gpio.c 
>>> b/drivers/pps/clients/pps-gpio.c
>>> index 2f4b11b4dfcd..f05fb15ed7f4 100644
>>> --- a/drivers/pps/clients/pps-gpio.c
>>> +++ b/drivers/pps/clients/pps-gpio.c
>>> @@ -52,7 +52,9 @@ static irqreturn_t pps_gpio_irq_handler(int irq, 
>>> void *data)
>>>
>>>          info = data;
>>>
>>> -       rising_edge = gpiod_get_value(info->gpio_pin);
>>> +       rising_edge = info->capture_clear ? \
>>> +                       gpiod_get_value(info->gpio_pin) : \
>>> +                       !info->assert_falling_edge;
>>>          if ((rising_edge && !info->assert_falling_edge) ||
>>>                          (!rising_edge && info->assert_falling_edge))
>>>                  pps_event(info->pps, &ts, PPS_CAPTUREASSERT, data);
>>>
>>> Please, review and test it before resubmitting. :)
>>>
>>
>> I'll try this and send a V2 after my tests, thank you.
> 
> OK, thanks.
> 
> However we should think very well about this modification since it could 
> be the case where we have a device sending both assert and clear events 
> but we wish to catch just the asserts... in this case we will get 
> doubled asserts!
> 

My understanding is that clear events are to be captured only when this
capture_clear boolean is set. If it is not set, the PPS_CAPTURECLEAR
flag is not added to pps_source_info->mode and get_irqf_trigger_flags()
will return only one edge flag (rising or falling depending on
assert-falling-edge DT property).

By the way, I see that the capture_clear is never set since the legacy
platform data support has been dropped (commit ee89646619ba).


Best regards,
Bastien