Received: by 2002:ab2:1347:0:b0:1f4:ac9d:b246 with SMTP id g7csp380812lqg; Thu, 11 Apr 2024 06:07:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUtOcaeg5LgpebzoUemd4Ferzl4CUBt6x+pO+ZfjfMn4h8P4XFqRpSipqdeEJCXlHMmEYJ8Y6u9FJBd8GM0GV1LIE2tZZp/Uhe4GQnqmQ== X-Google-Smtp-Source: AGHT+IGT7+E+cimTjEW2kRbcEj+g+y0DWzHYsPNBGbov7etDMGwDfCq18lTNxMF1v0nuCP/SGTYw X-Received: by 2002:a05:6a00:1996:b0:6ea:c767:4699 with SMTP id d22-20020a056a00199600b006eac7674699mr3049936pfl.13.1712840879315; Thu, 11 Apr 2024 06:07:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712840879; cv=pass; d=google.com; s=arc-20160816; b=x4Wh0owo/fPUzMHJxw9FhnxjNROliwZS3dylpuVkZjBoZuyiDVK2k/C9v4lYgGlzgK Jdw7Jd7Zp+ZDZ4RxzbXPccpGzSEn3tNkPtrEJD6dACLnQbjmlwS3Vp4jw3SVxUmMdpdd hMolDeKaINapBAgsq+ul/JUhHZ5Cnh2ogoCSoRwMk4EbfesSdFXXcmlnI38JZQq5UfBf KMM9hJ0t5cxfPWHz/s2m2eZDnsZpKKubxZgVLUVqMmywOUEYtR0x9SgVVdqpoZkLWQQ4 4VH8dbVFRjt4YdKs/fdm9kkqqV93POXfwnrVXHkuKbiN0OfJJblJaNd0eKECR4o3dhho SFOg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ddNJT5uybQ4GpH/sWtjIffShJBB90zc+naVrz+t8fDE=; fh=nlwX56W0vJ3fIyNWHsaqUcGbPrJk+LWWeZVmtHPIqiI=; b=vV0q392O8IpjcIeIZD7p16Nmof8WmP43D/b7PHhWuVE9ObQNI7PMmHEoGlx8FkAlJD fqunAfkTNJ4UIf0/eCgl+GZHnlZLG8UFG3CAp0CZqA696rR66HJZ/2o0rvCmxqUhoB0W It6m4Qlerd668emCZ/RMeSUPtsbGo1iimwqT2BqOyPaku1034ZkUw9Kfq5LWoeR2nIb3 93S8e0XqvrV6re1LXL3TvKpZvPV/SX1DzYiKQBgewPbw/z5CtzTK1rl7NJKle1I1icR+ eTsXq80H+EHznREE32j04h60s4big2bj4C7M/dhpAqG/swbF01cHPeyah5DS9QtDlWts uMNA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=l0iizJYj; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-140482-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140482-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z20-20020a056a001d9400b006e691660a08si1415303pfw.40.2024.04.11.06.07.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 06:07:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-140482-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=l0iizJYj; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-140482-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140482-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 00E61283935 for ; Thu, 11 Apr 2024 13:07:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 040D414C58E; Thu, 11 Apr 2024 13:07:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="l0iizJYj" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 155F15A0F4; Thu, 11 Apr 2024 13:07:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712840870; cv=none; b=GCa4AMWjScvhTnYwu+cC3GOGDFYFsnnhAyIUkIyX7PbIwXT7IM8oFU/34jcTc3nPyroA0MWX0P02c1FBo4R4ZrGudk7qStEj9S1YP1ngm+gb4In7Oz1IMY+A+bcNoKQjUz9VJFddDqJbcjYhcrDBXZue9NAX6Y5svulKoFzH9r0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712840870; c=relaxed/simple; bh=pTPEJwwsJFjYG713GzWA/+ri2JEjt8G3lmiEPr5+Q7A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AzIy3iRSV04BI4VzSMtiMIA61Tl8G8JXSBajH6uMRuFy4N54ibeHOtDre1yihspfUvjdqctBSY28OvvYaO4Lhi1/XjEzmVM2fYs9zzG4eCJhlDErWxLmazSDc7/ulqwXnW6UGtvseyk3eWhXZWT1D19L5exePsjRLCCnw0jtQ/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=l0iizJYj; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09E59C433C7; Thu, 11 Apr 2024 13:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712840869; bh=pTPEJwwsJFjYG713GzWA/+ri2JEjt8G3lmiEPr5+Q7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l0iizJYjhDA9viVVBrewQz0x7ceASK0mzGS6oEsloKRpkcsx0urG/1EddVpslYkG2 ZcuAUfOTiffyentqlm1/+PjzykDbUViTFaJCl1BBw6vGvcIm9Sy0l+11wci9GMAemP 2BrR5/70rrKjL+iKFVTAZ13fvRwkPdHIvhpsukYQ= Date: Thu, 11 Apr 2024 15:07:46 +0200 From: Greg Kroah-Hartman To: Lukas Wunner Cc: "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, Jean Delvare , Ard Biesheuvel , linux-efi@vger.kernel.org, Zhenyu Wang , Zhi Wang , intel-gvt-dev@lists.freedesktop.org, Daniel Lezcano , linux-pm@vger.kernel.org, Luis Chamberlain , linux-modules@vger.kernel.org Subject: Re: [PATCH 0/2] Deduplicate bin_attribute simple read() callbacks Message-ID: <2024041128-huddling-humped-4304@gregkh> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Apr 06, 2024 at 03:52:00PM +0200, Lukas Wunner wrote: > For my upcoming PCI device authentication v2 patches, I have the need > to expose a simple buffer in virtual memory as a bin_attribute. > > It turns out we've duplicated the ->read() callback for such simple > buffers a fair number of times across the tree. > > So instead of reinventing the wheel, I decided to introduce a common > helper and eliminate all duplications I could find. > > I'm open to a bikeshedding discussion on the sysfs_bin_attr_simple_read() > name. ;) Seems like no one objects, should I just take this through my driver-core tree for 6.10? thanks, greg k-h