Received-SPF: pass (google.com: domain of linux-kernel+bounces-140507-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 11 Apr 2024 16:25:50 +0300 (EEST)
To: "David E. Box" <david.e.box@linux.intel.com>
cc: Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>, 
    sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH V4 8/9] platform/x86/intel/sdsi: Simplify ascii
 printing
In-Reply-To: <77993eef-b896-7e75-93ba-a76f126b5fad@linux.intel.com>
Message-ID: <626fd010-aa6e-2963-5860-658b6069e035@linux.intel.com>
References: <20240411025856.2782476-1-david.e.box@linux.intel.com> <20240411025856.2782476-9-david.e.box@linux.intel.com> <77993eef-b896-7e75-93ba-a76f126b5fad@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-326121552-1712841950=:1017"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-326121552-1712841950=:1017
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Thu, 11 Apr 2024, Ilpo J=E4rvinen wrote:

> On Wed, 10 Apr 2024, David E. Box wrote:
>=20
> > Add #define for feature length and move NUL assignment from callers to
> > get_feature().
> >=20
> > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@lin=
ux.intel.com>
> > ---
> > V4 - Move NUL assignment to get_feature() and increment FEAT_LEN.
> >=20
> > V3 - Add FEAT_LEN #def
> >=20
> > V2 - Split of V1 patch 7
> >=20
> >  tools/arch/x86/intel_sdsi/intel_sdsi.c | 17 ++++++++---------
> >  1 file changed, 8 insertions(+), 9 deletions(-)
> >=20
> > diff --git a/tools/arch/x86/intel_sdsi/intel_sdsi.c b/tools/arch/x86/in=
tel_sdsi/intel_sdsi.c
> > index ba2a6b6645ae..301213370740 100644
> > --- a/tools/arch/x86/intel_sdsi/intel_sdsi.c
> > +++ b/tools/arch/x86/intel_sdsi/intel_sdsi.c
> > @@ -43,6 +43,7 @@
> >  #define METER_CERT_MAX_SIZE=094096
> >  #define STATE_MAX_NUM_LICENSES=0916
> >  #define STATE_MAX_NUM_IN_BUNDLE=09(uint32_t)8
> > +#define FEAT_LEN=09=095=09/* 4 plus NUL terminator */
> > =20
> >  #define __round_mask(x, y) ((__typeof__(x))((y) - 1))
> >  #define round_up(x, y) ((((x) - 1) | __round_mask(x, y)) + 1)
> > @@ -321,10 +322,11 @@ static char *content_type(uint32_t type)
> >  =09}
> >  }
> > =20
> > -static void get_feature(uint32_t encoding, char *feature)
> > +static void get_feature(uint32_t encoding, char feature[5])
> >  {
> >  =09char *name =3D (char *)&encoding;
> > =20
> > +=09feature[4] =3D '\0';
> >  =09feature[3] =3D name[0];
> >  =09feature[2] =3D name[1];
> >  =09feature[1] =3D name[2];
>=20
> Works, assuming none of the name bytes are 0.

Before somebody starts to wonder, while writing that, I thought this patch=
=20
was also about alignment (were <4 chars would have mattered), which was=20
just wrong recollection from my part and related to some other patch in=20
this series.

> Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-326121552-1712841950=:1017--