Received-SPF: pass (google.com: domain of linux-kernel+bounces-140493-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 11 Apr 2024 09:21:28 -0400
From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Joy Zou <joy.zou@nxp.com>, peng.fan@nxp.com, vkoul@kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	imx@lists.linux.dev, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up unused
 "fsl,imx8qm-adma" compatible stringg
Message-ID: <Zhfj2NH7PPqzz3nM@lizhi-Precision-Tower-5810>
References: <20240411074326.2462497-1-joy.zou@nxp.com>
 <20240411074326.2462497-3-joy.zou@nxp.com>
 <703311b6-ee3a-4131-ae11-57b8d765db5c@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <703311b6-ee3a-4131-ae11-57b8d765db5c@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?73XuZYfy2T8b5Jzh0q5G25KP6VtzAf4svvwDCg5wm46btcjcjePe6TioqDXF?=
 =?us-ascii?Q?YSDCLq2ofALsCWCn7MFUHbSse9uUoAw2PbmoVpkxscK2gnZoHmPWlrUYDOTM?=
 =?us-ascii?Q?Ts8iETKR939UxiAtnLzfMvfknDOcGHPpPtC9LHpnJovUwbvLF7xLVzT6DecS?=
 =?us-ascii?Q?GPTtIlMjX8DY731zPLnL+HYkJCZdzpge7BoDIMsa1hhsjQHetj9DzqgHS8ey?=
 =?us-ascii?Q?bJM9uHVmxEPUhctzPBw++E23xgEsOaEbWpyj5jM7jT0813kKPBtmkLraY5gP?=
 =?us-ascii?Q?CY07607hWrI1aLwoj84B8vj4+NpX4nkOnzXbONnpPGsCm5tjCggLgPvSEz7s?=
 =?us-ascii?Q?mlW0L2KBHjI4hSWEfvVKIi3AudGHsjrDrKluHPecE9VkTcBDWwqmgPz5Ac+N?=
 =?us-ascii?Q?2VA8CF8zwL7oPN4mmIrLwAYEGxCVLqMAtc6C2FCTOa7tNR3xZSdEGjXZqvx4?=
 =?us-ascii?Q?isL/pueuhLVRMFaZtG0gTA067MpSGQ0OcKgt8yYNfCKhLnjR384Fyh6bPbA+?=
 =?us-ascii?Q?2ruqt7Y2s776sK4Bik6TKweQ6MMcfALkW0mBfegDQAJ9cA8CGKEMIsqj/shT?=
 =?us-ascii?Q?26LhR1OxJHG2KwZLhkX5GLSYrPu2Op8qODWSX+HeKjP9wBst77Z+g6MER4YT?=
 =?us-ascii?Q?cWigc2CBVdhHMP2RTqhTfFGqT5EqTg1f22AGd2wn/lk7QbBE/2iYlUPbPJ/9?=
 =?us-ascii?Q?Abn2u5beorZnOPW62FWx1aOux8P0y4n964ZYwgVi17JvLxOzZeE7ASePghxf?=
 =?us-ascii?Q?zVRnmxgNWufgELbKE/08ZomYcngcPFuP48879esih5NKCi0QmnUdBSOUb0Ry?=
 =?us-ascii?Q?fC0+ZbJAVVo0JFqKb36m5DdpK+Xs1ojSR3fPvijrIQtKpjg9nK3N/esSfw7t?=
 =?us-ascii?Q?TDBg2JT3gmijBnKpciYIwhve0rfCKOLCJQ8b2mAvbh48DQkbcL+NovjHkkas?=
 =?us-ascii?Q?hCG1fxZf+BUcPEXxjtMEn2aVdtU6/oz/+BrU7hTJ9OsrPCaCN+6FjTaCj/vd?=
 =?us-ascii?Q?uBN2GkCYdsrrR3BDeHtGDlHOmLj+p1azP2enRfHR2UvTlMnOI7kPmW9SzFdo?=
 =?us-ascii?Q?OyRmOqS8xfCCH+9U7D1U9fgIbnnp9d820TvRMR8kNRPNC4cJo4gFIrf4qnXD?=
 =?us-ascii?Q?pOedd1FOw3yPE7dby2a7ZE3HoCGhIqk+qxfiJE1r7BlBlBQaRz4tQ2WqoOiU?=
 =?us-ascii?Q?Ib0VyyZYOutLsKaT15CfTfWvHF03teQDIA1egIkHiDsKG7uPFGXlIgVhJfPi?=
 =?us-ascii?Q?Nz/YyXWYPpmDSdGhUDbsdFaySc3BKib8FAWw3bJVIqhAwJ9/5QGfb0slvaLB?=
 =?us-ascii?Q?/Qv7RiOxegilw3QO7RvAkCL+ZXOhFVG7dio7OEjpAZis7skqH0D7eC4qyeZz?=
 =?us-ascii?Q?ocQylV5fEJmoAYV71taEXOBmlETzQl1DJqtrcq6kvaK18mvEg2yc2N2w6Gok?=
 =?us-ascii?Q?0SbVF4TzFbAZKjMMa/+/pW8oXyt34aSSTuBpvbMKrkKE4fnMEzA/Cot4xIeo?=
 =?us-ascii?Q?2XHosOHAaIBqbVUM1xjUElPQ2bo1WA8slZCG50dJjwNtxVChwHYWPpeiT+Ci?=
 =?us-ascii?Q?l0kwB08JKBNHAFtEa1ww0yQlnuX6bFpreXag9f4W?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dce86b74-a1a1-49f5-0144-08dc5a2a5049
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 13:21:36.3151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: etZ14X4ugwYWe2KmQ6cybSas9zSVov/9Q9CowP8+I9BAszgIhI5xvcOKcvP3xKokyw5tHytodgPMYBPJVRS+AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8171


It should be

dt-bindings: fsl-dma: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible stringg


b7b8715b430ee dt-bindings: fsl-dma: fsl-edma: add fsl,imx95-edma5 compatible string
6eb439dff645a dt-bindings: fsl-dma: fsl-edma: add edma3 compatible string
10cafa2d45885 dt-bindings: dma: drop unneeded quotes
cfa1927f8468c dt-bindings: dma: fsl-edma: Convert to DT schema


On Thu, Apr 11, 2024 at 10:13:38AM +0200, Krzysztof Kozlowski wrote:
> On 11/04/2024 09:43, Joy Zou wrote:
> > The compatible string "fsl,imx8qm-adma" is unused.
> 
> Why? Commit must stand on its own.

Joy:
	You can copy patch2's comit
> 
> > 
> > Signed-off-by: Joy Zou <joy.zou@nxp.com>
> > ---
> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
> 
> >  Documentation/devicetree/bindings/dma/fsl,edma.yaml | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > index 825f4715499e..64fa27d0cd9b 100644
> > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > @@ -21,7 +21,6 @@ properties:
> >        - enum:
> >            - fsl,vf610-edma
> >            - fsl,imx7ulp-edma
> > -          - fsl,imx8qm-adma
> 
> 
> I see more usages. One more trivial patch which is incorrect.
> 

Please clean up AllOf also.

allOf:                                                                     
  - $ref: dma-controller.yaml#                                             
  - if:                                                                    
      properties:                                                          
        compatible:                                                        
          contains:                                                        
            enum:                                                          
              - fsl,imx8qm-adma  
                           ^^^^                                          
              - fsl,imx8qm-edma  

> Did you implement the internal review?

Patch2 was internal reviewed. Patch1 is new. I know you are busy. Could
you please give me 1 days to review nxp's patches. You see patch always
ahead me if author and you are in similar time zone. 

I knew they are quite busy on heavy development work and all kinds
customer supports. 

Frank

> Best regards,
> Krzysztof
>