Received-SPF: pass (google.com: domain of linux-kernel+bounces-140510-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 11 Apr 2024 06:33:02 -0700
From: Breno Leitao <leitao@debian.org>
To: Tejun Heo <tj@kernel.org>
Cc: Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>,
	leit@meta.com,
	"open list:CONTROL GROUP - BLOCK IO CONTROLLER (BLKIO)" <cgroups@vger.kernel.org>,
	"open list:CONTROL GROUP - BLOCK IO CONTROLLER (BLKIO)" <linux-block@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk-iocost: Fix shift-out-of-bounds in iocg_kick_delay()
Message-ID: <Zhfmjoa2l04fXIVr@gmail.com>
References: <20240410193642.1303741-1-leitao@debian.org>
 <ZhbuUKXQwBwye1_r@slm.duckdns.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZhbuUKXQwBwye1_r@slm.duckdns.org>

On Wed, Apr 10, 2024 at 09:53:52AM -1000, Tejun Heo wrote:
> Hello, Breno.
> 
> On Wed, Apr 10, 2024 at 12:36:41PM -0700, Breno Leitao wrote:
> > When running iocg_kick_delay(), iocg->delay_at could be way behind "now",
> > which causes a huge tdelta difference.
> > 
> > The tdelta value is used to shift some bits around, raising the
> > following UBSAN splat:
> > 
> > 	UBSAN: shift-out-of-bounds in block/blk-iocost.c:1366:23
> > 
> > Debugging this, these are some values I got in my machine with 6.9-rc3.
> > 
> >  now = 3626064295
> >  iocg->delay_at = 3275794093
> > 
> > Fix this by validating that the shift if valid, otherwise bail out,
> > similarly to commit 2a427b49d029 ("blk-iocost: Fix an UBSAN
> > shift-out-of-bounds warning")
> 
> Rik alreaady sent a fix:
> 
>   http://lkml.kernel.org/r/20240404123253.0f58010f@imladris.surriel.com
> 
> which got commited as beaa51b36012fad5a4d3c18b88a617aea7a9b96d.

Even easier then. Thanks!