Received-SPF: pass (google.com: domain of linux-kernel+bounces-140618-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 11 Apr 2024 15:15:23 +0100
From: Dave Martin <Dave.Martin@arm.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: James Morse <james.morse@arm.com>, x86@kernel.org,
	linux-kernel@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	shameerali.kolothum.thodi@huawei.com,
	D Scott Phillips OS <scott@os.amperecomputing.com>,
	carl@os.amperecomputing.com, lcherian@marvell.com,
	bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
	baolin.wang@linux.alibaba.com, Jamie Iles <quic_jiles@quicinc.com>,
	Xin Hao <xhao@linux.alibaba.com>, peternewman@google.com,
	dfustini@baylibre.com, amitsinght@marvell.com,
	David Hildenbrand <david@redhat.com>,
	Rex Nie <rex.nie@jaguarmicro.com>
Subject: Re: [PATCH v1 11/31] x86/resctrl: Move monitor exit work to a restrl
 exit call
Message-ID: <Zhfwe6Xhyec20LzC@e133380.arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-12-james.morse@arm.com>
 <92187846-374f-4b45-865e-543ba198b6b9@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <92187846-374f-4b45-865e-543ba198b6b9@intel.com>

On Mon, Apr 08, 2024 at 08:19:00PM -0700, Reinette Chatre wrote:
> Hi James,
> 
> On 3/21/2024 9:50 AM, James Morse wrote:
> > rdt_put_mon_l3_config() is called via the architecture's
> > resctrl_arch_exit() call, and appears to free the rmid_ptrs[]
> > and closid_num_dirty_rmid[] arrays. In reality this code is marked
> > __exit, and is removed by the linker as resctl can't be built
> 
> resctl -> resctrl

Noted, thanks (also, there is "restrl" in the subject line.)

> 
> > as a module.
> > 
> > MPAM can make use of this code from its error interrupt handler,
> > a later patch drops all the __init/__exit annotations.
> 
> Reminder:
> https://lore.kernel.org/lkml/85f8756a-23a0-444e-b37d-a7817b600f46@intel.com/

The "Drop __init/__exit on assorted symbols" patch speaks for itself,
I guess. I think it's probably sufficient for now to comfirm that this
patch is deliberately not changing the annotations for now.

Does the following work?

--8<--

Since there is no immediate need to change them, leave the __exit
annotations as-is.  This will need to be revisited as and when there is
a need to call these functions other than at __exit time.

-->8--

Cheers
---Dave