Received-SPF: pass (google.com: domain of linux-kernel+bounces-140614-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 11 Apr 2024 15:14:40 +0100
From: Dave Martin <Dave.Martin@arm.com>
To: "Shaopeng Tan (Fujitsu)" <tan.shaopeng@fujitsu.com>
Cc: 'James Morse' <james.morse@arm.com>, "x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	"shameerali.kolothum.thodi@huawei.com" <shameerali.kolothum.thodi@huawei.com>,
	D Scott Phillips OS <scott@os.amperecomputing.com>,
	"carl@os.amperecomputing.com" <carl@os.amperecomputing.com>,
	"lcherian@marvell.com" <lcherian@marvell.com>,
	"bobo.shaobowang@huawei.com" <bobo.shaobowang@huawei.com>,
	"baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
	Jamie Iles <quic_jiles@quicinc.com>,
	Xin Hao <xhao@linux.alibaba.com>,
	"peternewman@google.com" <peternewman@google.com>,
	"dfustini@baylibre.com" <dfustini@baylibre.com>,
	"amitsinght@marvell.com" <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>,
	Rex Nie <rex.nie@jaguarmicro.com>
Subject: Re: [PATCH v1 06/31] x86/resctrl: Export resctrl fs's init function
Message-ID: <ZhfwUHHmOtXZqX1S@e133380.arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-7-james.morse@arm.com>
 <TYAPR01MB63300666A8517A5A141F9B5C8B3D2@TYAPR01MB6330.jpnprd01.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <TYAPR01MB63300666A8517A5A141F9B5C8B3D2@TYAPR01MB6330.jpnprd01.prod.outlook.com>

On Wed, Apr 03, 2024 at 07:51:54AM +0000, Shaopeng Tan (Fujitsu) wrote:
> Hello James,
> 
> > rdtgroup_init() needs exporting so that arch code can call it once it lives in core
> > code. As this is one of the few functions we export, rename it to have the resctrl
> > in the name. The same goes for the exit call.
> > 
> > x86's arch code init functions for RDT are renamed to have an arch prefix to
> > make it clear these are part of the architecture code.
> > 
> > Signed-off-by: James Morse <james.morse@arm.com>
> > ---
> >  arch/x86/kernel/cpu/resctrl/core.c     | 12 ++++++------
> >  arch/x86/kernel/cpu/resctrl/internal.h |  3 ---
> > arch/x86/kernel/cpu/resctrl/rdtgroup.c |  8 ++++----
> >  include/linux/resctrl.h                |  3 +++
> >  4 files changed, 13 insertions(+), 13 deletions(-)
> 
> /fs/resctrl/monitor.c
> 746          * RESCTRL_RESERVED_CLOSID and RESCTRL_RESERVED_RMID are special and
> 747          * are always allocated. These are used for the rdtgroup_default
> 748          * control group, which will be setup later in rdtgroup_init(). 
> "rdtgroup_init()" is still in the comments.
> 
> 
> Best regards,
> Shaopeng TAN
> 

[...]

Noted for James' attention, thanks.

Cheers
---Dave