Received-SPF: pass (google.com: domain of linux-kernel+bounces-140617-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 11 Apr 2024 15:15:07 +0100
From: Dave Martin <Dave.Martin@arm.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: James Morse <james.morse@arm.com>, x86@kernel.org,
	linux-kernel@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	shameerali.kolothum.thodi@huawei.com,
	D Scott Phillips OS <scott@os.amperecomputing.com>,
	carl@os.amperecomputing.com, lcherian@marvell.com,
	bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
	baolin.wang@linux.alibaba.com, Jamie Iles <quic_jiles@quicinc.com>,
	Xin Hao <xhao@linux.alibaba.com>, peternewman@google.com,
	dfustini@baylibre.com, amitsinght@marvell.com,
	David Hildenbrand <david@redhat.com>,
	Rex Nie <rex.nie@jaguarmicro.com>
Subject: Re: [PATCH v1 07/31] x86/resctrl: Wrap resctrl_arch_find_domain()
 around rdt_find_domain()
Message-ID: <ZhfwazGdJk2NbWxI@e133380.arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-8-james.morse@arm.com>
 <f0243dbb-f333-4c06-a315-ceaca8fa0bc2@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f0243dbb-f333-4c06-a315-ceaca8fa0bc2@intel.com>

On Mon, Apr 08, 2024 at 08:17:12PM -0700, Reinette Chatre wrote:
> Hi James,
> 
> On 3/21/2024 9:50 AM, James Morse wrote:
> > rdt_find_domain() finds a domain given a resource and a cache-id.
> > It's not quite right for the resctrl arch API as it also returns the
> > position to insert a new domain, which is needed when bringing a
> > domain online in the arch code.
> > 
> > Wrap rdt_find_domain() in a another function resctrl_arch_find_domain()
> 
> "in a another" -> "in another"

Noted for James' attention.


> > so we avoid the unnecessary argument outside the arch code.
> 
> Please do not impersonate code.

[...]

> Reinette

Noted.

Cheers
---Dave