Received: by 2002:ab2:1347:0:b0:1f4:ac9d:b246 with SMTP id g7csp434787lqg; Thu, 11 Apr 2024 07:24:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVUGgq7PFBBCXwXKbD6ajxzYbX1cdxPWU2qO1viFa7K8cbtYkWTay8BELF8z2Mb2DgNTfhTKwm6DerpQ1f1fsWT1bD/8XuYxzfam3lXqg== X-Google-Smtp-Source: AGHT+IHInQ2gLb+JzguxFuOntc6iDNak4Uy+yZsSkn0tcdFrme7GhQNCLzRmx5WXLCMQnpMLGtcg X-Received: by 2002:a05:6359:2413:b0:186:1de0:c182 with SMTP id ls19-20020a056359241300b001861de0c182mr7800432rwb.4.1712845463783; Thu, 11 Apr 2024 07:24:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712845463; cv=pass; d=google.com; s=arc-20160816; b=CpoaiS/CecXvQwGrdCv4eJyPZvnlZZLPNx4qhbAKnID7Ks90zszke3BY26KfJiaOkm jKNYUGEK7VWmanyd3iwZUP68aheUpA1OfNzGPiYSxYb05LwFuTCQQD+7uL9V3zQJVTii GgZE1fHQ1dKZorhOS6XjbGPQIv8Dr1+kF2lrtwi+7VBhLq1ciTxF1Urxm5DYXi8ZE7Eo 9iLObpCyANa7xNey1M9aLnPVurxupnyWAK+2E2xx6Y92hwnmBYvo06oxXJLhKMgZwp23 0DKJ/5XVOCfdn5whD4XbtzbcKpYCGRGEPdcDDNAP79AJTgL+ZVWdaYyPNnsLaEdCDjSF RWwg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Q/oJU7Vy/d+vtAVhKgDsRx9ErkPhiN/5itGbIlcfFwo=; fh=2siswMJ/+W7HoYnVkPQu1vITli+S9b3yaVtHxsizcTc=; b=rsgF4MWl5pOb0T5/953nGaPkuj8qJ2KSvohwdlKo+2FBf0EPr4K8bNJ1S5+CV+099m YtfVhCBFBMlOCwFXEdd/gIbNe+dc5hgtkU+t5OtNhEtv5hULTyEXd3Y3nM8cXyybT7zp IXsAzDtSB1K+GdLErk3MCQYCZ1cCtuaZrq9OJ1YSArsuJhRJ8l0L+r8rp+SbeeepP8QK 0LedofDd4rW/ru91IPuApF+B2TpTmZF6AXQAwpZUD4Jq/gHxy+2KHVmD4QXiybhSBLLn bNptuJgEI24g9q9kYE3U+f1uczIXXxatrKAC6sEclomAiTz8JMz54emzb+v3IYSQCrYx o3VA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=rnDBtNWs; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-140631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140631-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id o20-20020a637e54000000b005f3e052770esi1333153pgn.83.2024.04.11.07.24.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 07:24:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-140631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=rnDBtNWs; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-140631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140631-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8358828598A for ; Thu, 11 Apr 2024 14:21:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9DE7214EC44; Thu, 11 Apr 2024 14:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="rnDBtNWs" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A502D14D708; Thu, 11 Apr 2024 14:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712845268; cv=none; b=NAC4bG8Q9evXEDf/663xTABHGq8dwPjVBbNtDFgiwGKpgfyDJZUeSqu/h8QpqvTBTg3ZAe24YbDbz4/GjFaCN6iHOGPvAdL7fw4WhiC3x1SDKLbK5N7peaDMPAm6lhNoyJEeBMFWqyR/3x4HhPXt2jKwwFyAM/0NaDXzgx88uHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712845268; c=relaxed/simple; bh=l7j7GLxWdevX8j9nxH2gEq+1VH4ij6kA0ZV6FEUWLa8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sZBnf37170TR/ypWHHJen/ERAza/WP+9SIO8tKGjMAp/YuIvPpglwUDYBbdPTXSVdT2mzcjW/n4hJtJlGeN178OXEoO7DDryIcFafTFtr31l6bZCv9vaYMx8ya+LuAET9Da85F5757/ZRj1kk3dPfaaXmGet8rdTA+O7CCT+jZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=rnDBtNWs; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Q/oJU7Vy/d+vtAVhKgDsRx9ErkPhiN/5itGbIlcfFwo=; b=rnDBtNWsysuvAwGzBDHwwnBkXg n5T7i19Z9E2zXsQ1lOP2+QwHBzLlA2kBNCCPHXPjxcGby5m53CvpLxeJTDMiVY38gdYoRumxPnNl8 NbzHpZj26dxhQwA+VSLyPMvPXJhsqzLW6AZ+Nc4ohMmGpr9Kv3XJfxBIB4t1QWIcj3k0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ruvIJ-00CmSb-42; Thu, 11 Apr 2024 16:20:51 +0200 Date: Thu, 11 Apr 2024 16:20:51 +0200 From: Andrew Lunn To: Alexander Lobakin Cc: Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , David Ahern , Xuan Zhuo , nex.sw.ncis.osdt.itp.upstreaming@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC net-next 7/7] netdev_features: convert NETIF_F_FCOE_MTU to IFF_FCOE_MTU Message-ID: References: <20240405133731.1010128-1-aleksander.lobakin@intel.com> <20240405133731.1010128-8-aleksander.lobakin@intel.com> <20240408193806.18e227c8@kernel.org> <1f14cb75-ee6b-4a7d-9041-23a8cfcd8476@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f14cb75-ee6b-4a7d-9041-23a8cfcd8476@intel.com> > >> @@ -47,7 +47,6 @@ const char netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN] = { > >> > >> [NETIF_F_FCOE_CRC_BIT] = "tx-checksum-fcoe-crc", > >> [NETIF_F_SCTP_CRC_BIT] = "tx-checksum-sctp", > >> - [NETIF_F_FCOE_MTU_BIT] = "fcoe-mtu", > > > > > > But this definitely _is_ a uAPI change, right? > > Why? That it is not obvious why this is not a uAPI change makes it clear this needs explaining in the commit message. Andrew