Received-SPF: pass (google.com: domain of linux-kernel+bounces-140640-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 11 Apr 2024 15:25:49 +0100
From: Dave Martin <Dave.Martin@arm.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: James Morse <james.morse@arm.com>, x86@kernel.org,
	linux-kernel@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	shameerali.kolothum.thodi@huawei.com,
	D Scott Phillips OS <scott@os.amperecomputing.com>,
	carl@os.amperecomputing.com, lcherian@marvell.com,
	bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
	baolin.wang@linux.alibaba.com, Jamie Iles <quic_jiles@quicinc.com>,
	Xin Hao <xhao@linux.alibaba.com>, peternewman@google.com,
	dfustini@baylibre.com, amitsinght@marvell.com,
	David Hildenbrand <david@redhat.com>,
	Rex Nie <rex.nie@jaguarmicro.com>
Subject: Re: [PATCH v1 27/31] x86/resctrl: Rename resctrl_sched_in() to begin
 resctrl_arch_
Message-ID: <Zhfy7dmFBf3yLkiA@e133380.arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-28-james.morse@arm.com>
 <7acf109f-d25f-4a37-9f97-c515346583a8@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7acf109f-d25f-4a37-9f97-c515346583a8@intel.com>

On Mon, Apr 08, 2024 at 08:26:04PM -0700, Reinette Chatre wrote:
> Hi James,
> 
> In subject, did you intend to say "to begin with"?

I'd say the subject is likely to be abbreviated rather than incorrect,
but it certainly does no harm to clarify it.  I'll make a note.

> On 3/21/2024 9:51 AM, James Morse wrote:
> > resctrl_sched_in() loads the architecture specific CPU MSRs with the
> > CLOSID and RMID values. This function was named before resctrl was
> > split to have architecture specific code, and generic filesystem code.
> > 
> > This function is obviously architecture specific, but does not begin
> > with 'resctrl_arch_', making it the odd one out in the functions an
> > architecture needs to support to enable resctrl.
> > 
> > Rename it for concistency. This is purely cosmetic.
> 
> concistency -> consistency

Noted.

Cheers
---Dave