Received: by 2002:ab2:1347:0:b0:1f4:ac9d:b246 with SMTP id g7csp438326lqg; Thu, 11 Apr 2024 07:29:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU0DvwRUD+xeI3faSIAE6IBEaKblaeT+Gwt2RHO8lINnaoQJHKlxd5PYV2L9aX/NUWD/1NDfoTn36I2gW8XGC62oyo43U/xFSxu0ZweZQ== X-Google-Smtp-Source: AGHT+IG0WfNiORKgjdqNDpOjGGXNhUdsOZcEG4NPlxQ1oA8wvCZ2EqFpf1wF/SGGVyjO6r43Z53h X-Received: by 2002:a05:6214:2686:b0:69b:2523:fcd3 with SMTP id gm6-20020a056214268600b0069b2523fcd3mr7015315qvb.60.1712845781524; Thu, 11 Apr 2024 07:29:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712845781; cv=pass; d=google.com; s=arc-20160816; b=Na35c/YelP6anuc5YJuZtPP+i5MLcQ6I1xjCWfrE+qobA5xGY+sFqglHdhuKR1eFr0 9AB0TBPoTuxG1Ofanz4cY2O3oGUTqIya1YC3BUrTgfUa44KsFIBoDllDRAajYiJE0n97 ZME/OUeR/Td/Evn97G8W+Puo92/kmNsGg8OtA3qJ/KOrcxGZsqE78gVDsDgNRNYlMU8M EgbPgBOgQktv1ROuz9LD+fP7aJxhR7gNBHYFFK7j3y8RPrZUUJ7HNa+ssBHw5OpvkPxB Oh4V7ZNT4PbK3nf/kIQbHmT/JRDWP6Yxfm5Zc638S6+YmZT8pWyRiXS4Rp9ZyO+Ebt56 gbEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=rlvrzm3gB3jWm2EEmkGypCs6qLfw+j8/jNqMMZcpIr4=; fh=l3pmbiAgZ/S8Jx0/IndcOFdbdY9shx1r3LOEIFgdDpE=; b=yp1VfOWr7p9BaQvE4P33KGGZjkxGBjvK5Zl0VKkaSDC4d6+gV286HDFJFyQIDMa7PR beC6B9dAhvu5+W8/hnVnLnRzhDpCaRgJLZjk6QeZiOeAnIOCsWfjvzFcOlW43n2ZDBzv fUoblQ0fsH2A84Gb43JZAwwPl90r/h33HfPymG+dxWpEXK9XbrnM/zYnucVscy8/mFiZ qWmbQqs+GMn/fR9tNk8u/cOS/vfUFurwgAOH1vsCfJ19I+T0MHadvHkpCkmRdhstC61O PJ5Cw/JSzysv0lplx+M0nPyYxAAHIDIYiNOF1LSYJFbSiiQx8utgwMmaYmxaAvEiI1bU RVlg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="V/MyrsDG"; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-140650-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140650-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id a7-20020a0ccdc7000000b0069b10ddc5d6si1603265qvn.94.2024.04.11.07.29.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 07:29:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-140650-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="V/MyrsDG"; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-140650-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140650-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 34C6F1C2095B for ; Thu, 11 Apr 2024 14:29:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 53ABE14F13D; Thu, 11 Apr 2024 14:29:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="V/MyrsDG" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52B1614F12D; Thu, 11 Apr 2024 14:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712845751; cv=none; b=TYPz/n9pBelfdj5BdV7dAXCFkHdmgeEA4bcvDxB17YEa+oYSB7Z3S6v4IWRvtvZoZN8MJCbG3Bt8ut9zlNrM7zu2yAu8uN5ypiC0jJheVzB+Phjw8j5noFxm1SUSH8GHF1eDcsGg25vd1DCjSHNKkYnRu6BjaRDuwfCxXhLtNHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712845751; c=relaxed/simple; bh=rlvrzm3gB3jWm2EEmkGypCs6qLfw+j8/jNqMMZcpIr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eoamMLEsKitXHpYRKG7saCIRDqD37POxGHEQsgdAF48u2HmuoqvCopWYri1NoKoueclbmhjC0XFlkN3b5oOJLYyuXLWxedpA7DptAZPltDSROh0DD93d0+AcbOy+w5XcoeyOrnJmyrIpkb8h4IPeQRccWr3PbvLO2QLmI2XE2Ek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=V/MyrsDG; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712845749; x=1744381749; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=rlvrzm3gB3jWm2EEmkGypCs6qLfw+j8/jNqMMZcpIr4=; b=V/MyrsDGhVsLP4xWeePDLvKTAEoeAl8SXaAM0eR8XQc/4Agwzt/J2g0X mTQk0EC8G0jjZp8u6yF8FEam+JRN+3AjesQJLLW4YFmBY2VH7GRkNzSbJ 0Ok5gqDf7z63m7+blk/om0rM1jTUw+9Kuq2o9apzl1bYG/IYve2M5Z/ht 1VPgaGLoo4SIQWzKhiuINhyoUI/9IbJpgmoziK4Cym5qlAxEmMq4V5OJy 7v9vaUEVZtwBzBrego1YfTXdR1VgSKp2+dQwNLmlmM8jJg8JSP+0bTr8Y Sg064Ja/IFvIB9x5sbZCqtzAdgvlutTsL55rorNQukgMAROzUvZr6LS8b A==; X-CSE-ConnectionGUID: VJ+tgjCbSGiJ/NGlEP0q7w== X-CSE-MsgGUID: iIjTnaIjR9a/wyaUvum9gA== X-IronPort-AV: E=McAfee;i="6600,9927,11041"; a="8113984" X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="8113984" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 07:29:08 -0700 X-CSE-ConnectionGUID: S7tBaVmVTpiilrUbNjKQpw== X-CSE-MsgGUID: Zweba5zHQSaNkwkGAW/NJg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="25381463" Received: from tgrabows-mobl.amr.corp.intel.com (HELO [10.209.89.64]) ([10.209.89.64]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 07:29:07 -0700 Message-ID: Date: Thu, 11 Apr 2024 07:29:06 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched: Add missing memory barrier in switch_mm_cid To: Mathieu Desnoyers , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" Cc: linux-kernel@vger.kernel.org, "levi . yun" , stable@vger.kernel.org, Steven Rostedt , Vincent Guittot , Juri Lelli , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Catalin Marinas , Mark Rutland , Will Deacon , Aaron Lu References: <20240308150719.676738-1-mathieu.desnoyers@efficios.com> <18f5d6e7-9e33-419a-bd15-fd4fa34a69c8@efficios.com> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <18f5d6e7-9e33-419a-bd15-fd4fa34a69c8@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/10/24 10:18, Mathieu Desnoyers wrote: > --- a/arch/x86/include/asm/barrier.h > +++ b/arch/x86/include/asm/barrier.h > @@ -79,6 +79,9 @@ do {                                    \ >   #define __smp_mb__before_atomic()    do { } while (0) >   #define __smp_mb__after_atomic()    do { } while (0) > +/* Writing to CR3 provides a full memory barrier in switch_mm(). */ > +#define smp_mb__after_switch_mm()    do { } while (0) I haven't gone through this in detail, but the CR3 certainly is a full barrier and the x86 code _looks_ correct, so: Acked-by: Dave Hansen # for x86