Received-SPF: pass (google.com: domain of linux-kernel+bounces-140329-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 11 Apr 2024 14:20:29 +0300 (EEST)
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
    LKML <linux-kernel@vger.kernel.org>, 
    linux-serial <linux-serial@vger.kernel.org>, 
    Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/1] serial: max3100: Convert to_max3100_port() to be
 static inline
In-Reply-To: <20240410141135.1378948-1-andriy.shevchenko@linux.intel.com>
Message-ID: <0efff014-43a2-b1e2-6690-515a6b2a3edd@linux.intel.com>
References: <20240410141135.1378948-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-94683981-1712834247=:1017"
Content-ID: <b296fc51-820a-5172-1f94-14d0777a60c8@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-94683981-1712834247=:1017
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <d4ccf212-a95c-7bf6-6d13-d12ae3696795@linux.intel.com>

On Wed, 10 Apr 2024, Andy Shevchenko wrote:

> As Jiri rightfully pointed out the current to_max3100_port() macro
> implementation is fragile in a sense that it expects the variable
> name to be port, otherwise it blow up the build.
>=20
> Change this to be static inline to prevent bad compilation.
>=20
> Suggested-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/tty/serial/max3100.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
> index 1e6b5763ce3f..07ee001640bb 100644
> --- a/drivers/tty/serial/max3100.c
> +++ b/drivers/tty/serial/max3100.c
> @@ -111,7 +111,10 @@ struct max3100_port {
>  =09struct timer_list=09timer;
>  };
> =20
> -#define to_max3100_port(port)=09container_of(port, struct max3100_port, =
port)
> +static inline struct max3100_port *to_max3100_port(struct uart_port *por=
t)
> +{
> +=09return container_of(port, struct max3100_port, port);
> +}
> =20
>  static struct max3100_port *max3100s[MAX_MAX3100]; /* the chips */
>  static DEFINE_MUTEX(max3100s_lock);=09=09   /* race on probe */
>=20

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

It seems liteuart has the same trap.

--=20
 i.
--8323328-94683981-1712834247=:1017--