Received: by 2002:ab2:1347:0:b0:1f4:ac9d:b246 with SMTP id g7csp448994lqg; Thu, 11 Apr 2024 07:45:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVP2DXKRsOEaOxC6veQsdz6UkqfnqgkxJoY5xogak5g8+yN84S7Kfi0gBk8+dbE6a1ZvOatlRArx9B+JUThfC4wSKwZBn4EAuD1+Nhx0g== X-Google-Smtp-Source: AGHT+IHfBERYcjYX0m+Iz1FbyfMN+7SnM173/X7n0uAWztVhhgMGI7t86vH/4m+WY6ZalpRW4HJH X-Received: by 2002:ac8:5acd:0:b0:434:68ad:bc6d with SMTP id d13-20020ac85acd000000b0043468adbc6dmr6627367qtd.52.1712846748577; Thu, 11 Apr 2024 07:45:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712846748; cv=pass; d=google.com; s=arc-20160816; b=KtV3zrVpaR9okCqzQRzOLCtUQF/9iWXbuNyxa/SwGyAJIXgB0nBtouLuOZHr9VHLYs lPu7ZL6CaIkV2NhJussVYZR1BwnfXG5PArjeu6qkyRdBjAfwdA9voScVz+/uICTeqQ8h vNyuQ8QWlPmx4fvkGBOzYDa+wskBbldPkKlgMLffVYzcHhV0xBhSpFObJXFu0p4ozh1f bLV070QsneDy0gRwJ7WV4QJ+7lYE03TbfS7YQUhNAsTBYMUzBXWPEi2w4iDj2oImXVDb zOeL2nXzj2z4IcWTsqInRzywOtkfmfpHI4jlVJlO4kAeWAbOQfQYtx40L5aiNq2+cJQ9 2bfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=mZZq/IuabjGDu9kMHcg7s15OaiK1wzXax1ZXSefWXYw=; fh=N9Y0IwdJYteZyjw67LK/bsLWrYmFnI1NxRod/Rtoz40=; b=U5nD6VjkLSgyraOE7zFrU29YiIsNbPSN5EP/z/FWfO4GpPRJOsgmrQT9+Cvf65TYYD DBmv5DQ9zKETGVZ166NBYKbUfGpNYnh5KVWCQ9TYKzluyuTrgxhq6Qx04sASGuQHYgok 7CPNLtNE8Kp8V6kBbcHlIGYTCwe8+NxboIMTuJyV8+IeNuWyyieub+ULBI4I2T6zEcdG vkHl/iyxgzyzU99JLvKqA0vLkgah4WITceppqcIiz+Ahi8jsOQFekPxLdOigsWKjtX9s g2jTi8dZfD+dFrXrFkxE57WR08BbKmfIAl8x6tONIO5qhRZ9kaEEWTVSkY3magHT96uX VC8A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=irWM4nTz; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-140686-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140686-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o9-20020a05622a138900b00434ff9cdc6csi1666610qtk.44.2024.04.11.07.45.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 07:45:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-140686-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=irWM4nTz; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-140686-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-140686-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 770421C22C86 for ; Thu, 11 Apr 2024 14:45:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DB7E5E55F; Thu, 11 Apr 2024 14:44:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="irWM4nTz" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 489A2DF44 for ; Thu, 11 Apr 2024 14:44:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712846685; cv=none; b=Te8ff41t6W5g2i082Aw4ayTxhXUIRkU6gkAXhpCS8QHj09YgjbG0juDwLZRcbKbl2GppIE1JvDHZ366WTe6Qroj/VdNj6z4kGZ4G3HaiLSB2Ohcnb2Zh57IX9mEM6vvlnIYvSPVTlzaf9Ocbx1prWs5Qq0bJw6nmV+s65l7TG3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712846685; c=relaxed/simple; bh=7sLvHW+VvP4RvfSJNqpyvbfhEblcKLSuUvl5UJNohJE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m6lC0jRS6Np0rhyV5Y4OkP6mFHsj+O3zwv7f4Lxd+2GcGbiXtoxHZLQA022thKCCBNuHQbMSCZaMpEQpUPLxQRWg06aiuSb07vZRtBRMsnJz99ENeEQHqr8T70MKwBBXS1afD7BVcXjVCGdv4ycBBIgE/JuWkYy9Wxz6mwdOj1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=irWM4nTz; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712846684; x=1744382684; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=7sLvHW+VvP4RvfSJNqpyvbfhEblcKLSuUvl5UJNohJE=; b=irWM4nTzCZFXMWQvr+0jGD6XATjW4Be/Q2nai83gkp4Hds2f9G4i+Y6g jwTLJGvMEmPG57d6rFmGd84a+rYABbufmWM2iMFK6SzFtWzCrdxF/k1FW Mg5Ka4b/d3SbLgbmTZ8TfAino/JId83KODy6IP2ZyEk6QM15b1GP4mZbi B7Fdk3UkaGVjjJ6gEQjLPzVgaLmxIZC7bAa/TGjcvn5hltDLa1wdMkNDj U1z0n0blgkEbj8Ko4dOr6/R5oHVP1YmajOAS4Pv6FYsNuwjmMbS428Had w/xTHKGbqNY3UCLYChb2qc9eY+bvRZUaCOCIFO9LCFl/SXdy3scbxspls A==; X-CSE-ConnectionGUID: ibqpi0rtSBWDw2CAAi4u0g== X-CSE-MsgGUID: Yt7KKDOtSPKJGoEmbDIBBA== X-IronPort-AV: E=McAfee;i="6600,9927,11041"; a="8365399" X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="8365399" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 07:44:43 -0700 X-CSE-ConnectionGUID: 1ya5wsnPSA6rMLi3VIfObw== X-CSE-MsgGUID: YhzQOf5qQp2DzCRpScViBw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="21420764" Received: from tgrabows-mobl.amr.corp.intel.com (HELO [10.209.89.64]) ([10.209.89.64]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 07:44:43 -0700 Message-ID: <3ee70b6c-3399-43f9-8934-cb5a0e51f006@intel.com> Date: Thu, 11 Apr 2024 07:44:43 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] x86/mm: Don't disable INVLPG if "incomplete Global INVLPG flushes" is fixed by microcode or the kernel is running in a hypervisor To: Xi Ruoyao , Dave Hansen , Michael Kelley , Pawan Gupta Cc: Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Sean Christopherson , Andrew Cooper References: <20240411104822.6429-1-xry111@xry111.site> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240411104822.6429-1-xry111@xry111.site> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/11/24 03:48, Xi Ruoyao wrote: > + /* > + * The Intel errata claims: "this erratum does not apply in VMX > + * non-root operation. It applies only when PCIDs are enabled > + * and either in VMX root operation or outside VMX operation." > + * So we are safe if we are surely running in a hypervisor. > + */ When you revise this, could you please work to make this more succinct? The Intel language on these things tends to be a bit flowery and is not always well-suited for the kernel. Also, saying that the erratum "claims" this casts doubt on it. That's counterproductive. I believe the current documentation is correct. My original ce0b15d11ad8 ("x86/mm: Avoid incomplete Global INVLPG flushes") should have considered virtualized systems immune to this issue. I agree that it sounds weird. It _is_ weird that systems running under hypervisors aren't affected. But that's all it is: a weird bug. The documentation is correct.