Received-SPF: pass (google.com: domain of linux-kernel+bounces-140692-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <1f5d53596e2ac8948332570e3bda17c3877fd499.camel@xry111.site>
Subject: Re: [PATCH v6] x86/mm: Don't disable INVLPG if "incomplete Global
 INVLPG flushes" is fixed by microcode or the kernel is running in a
 hypervisor
From: Xi Ruoyao <xry111@xry111.site>
To: Dave Hansen <dave.hansen@intel.com>, Dave Hansen
 <dave.hansen@linux.intel.com>, Michael Kelley <mhklinux@outlook.com>, Pawan
 Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: Andy Lutomirski <luto@kernel.org>, Peter Zijlstra
 <peterz@infradead.org>,  Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar
 <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, "H. Peter Anvin"
 <hpa@zytor.com>, x86@kernel.org, linux-kernel@vger.kernel.org, Sean
 Christopherson <seanjc@google.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>
Date: Thu, 11 Apr 2024 22:48:07 +0800
In-Reply-To: <3ee70b6c-3399-43f9-8934-cb5a0e51f006@intel.com>
References: <20240411104822.6429-1-xry111@xry111.site>
	 <3ee70b6c-3399-43f9-8934-cb5a0e51f006@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-04-11 at 07:44 -0700, Dave Hansen wrote:
> On 4/11/24 03:48, Xi Ruoyao wrote:
> > +	/*
> > +	 * The Intel errata claims: "this erratum does not apply in VMX
> > +	 * non-root operation.=C2=A0 It applies only when PCIDs are enabled
> > +	 * and either in VMX root operation or outside VMX operation."
> > +	 * So we are safe if we are surely running in a hypervisor.
> > +	 */
>=20
> When you revise this, could you please work to make this more succinct?
> The Intel language on these things tends to be a bit flowery and is not
> always well-suited for the kernel.

Oops, bad timing.  I just sent v7 before getting this reply.

I'm not a native English speaker, so could you give some hint about how
to write this comment clearly?

> Also, saying that the erratum "claims" this casts doubt on it.=C2=A0 That=
's
> counterproductive.=C2=A0 I believe the current documentation is correct.=
=C2=A0 My
> original ce0b15d11ad8 ("x86/mm: Avoid incomplete Global INVLPG flushes")
> should have considered virtualized systems immune to this issue.

Then do we need a "Fixes: ce0b15d11ad8" for the patch keeping PCID
enabled for guests?

> I agree that it sounds weird.=C2=A0 It _is_ weird that systems running un=
der
> hypervisors aren't affected.=C2=A0 But that's all it is: a weird bug.=C2=
=A0 The
> documentation is correct.

Yes, these hardware issues are just weird to me...

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University