Received-SPF: pass (google.com: domain of linux-kernel+bounces-140622-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 11 Apr 2024 15:16:19 +0100
From: Dave Martin <Dave.Martin@arm.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: James Morse <james.morse@arm.com>, x86@kernel.org,
	linux-kernel@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	shameerali.kolothum.thodi@huawei.com,
	D Scott Phillips OS <scott@os.amperecomputing.com>,
	carl@os.amperecomputing.com, lcherian@marvell.com,
	bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
	baolin.wang@linux.alibaba.com, Jamie Iles <quic_jiles@quicinc.com>,
	Xin Hao <xhao@linux.alibaba.com>, peternewman@google.com,
	dfustini@baylibre.com, amitsinght@marvell.com,
	David Hildenbrand <david@redhat.com>,
	Rex Nie <rex.nie@jaguarmicro.com>
Subject: Re: [PATCH v1 14/31] x86/resctrl: Export the is_mbm_*_enabled()
 helpers to asm/resctrl.h
Message-ID: <Zhfws5KVuCPXy9V8@e133380.arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-15-james.morse@arm.com>
 <67021f34-65fd-4ea8-b696-b5d797ae9dbc@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <67021f34-65fd-4ea8-b696-b5d797ae9dbc@intel.com>

On Mon, Apr 08, 2024 at 08:20:12PM -0700, Reinette Chatre wrote:
> Hi James,
> 
> On 3/21/2024 9:50 AM, James Morse wrote:
> > The architecture specific parts of resctrl have helpers to hide accesses
> > to the rdt_mon_features bitmap.
> > 
> > Once the filesystem parts of resctrl are moved, these can no longer live
> > in internal.h. Once these are exposed to the wider kernel, they should
> > have a 'resctrl_arch_' prefix, to fit the rest of the arch<->fs interface.
> > 
> > Move and rename the helpers that touch rdt_mon_features directly.
> > is_mbm_event() and is_mbm_enabled() are only called from rdtgroup.c,
> > so can be moved into that file.
> > 
> > Signed-off-by: James Morse <james.morse@arm.com>
> > ---
> >  arch/x86/include/asm/resctrl.h         | 17 +++++++++++
> >  arch/x86/kernel/cpu/resctrl/core.c     |  4 +--
> >  arch/x86/kernel/cpu/resctrl/internal.h | 27 -----------------
> >  arch/x86/kernel/cpu/resctrl/monitor.c  | 18 ++++++------
> >  arch/x86/kernel/cpu/resctrl/rdtgroup.c | 40 +++++++++++++++++---------
> >  5 files changed, 54 insertions(+), 52 deletions(-)
> > 
> > diff --git a/arch/x86/include/asm/resctrl.h b/arch/x86/include/asm/resctrl.h
> > index 5f6a5375bb4a..50407e83d0ca 100644
> > --- a/arch/x86/include/asm/resctrl.h
> > +++ b/arch/x86/include/asm/resctrl.h
> > @@ -7,6 +7,7 @@
> >  #include <linux/jump_label.h>
> >  #include <linux/percpu.h>
> >  #include <linux/sched.h>
> > +#include <linux/resctrl_types.h>
> >  
> 
> Can this be alphabetical?

I'd guess so, looking at it.

Noted.

Cheers
---Dave