Received-SPF: pass (google.com: domain of linux-kernel+bounces-140652-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 11 Apr 2024 10:29:25 -0400
From: Frank Li <Frank.li@nxp.com>
To: Joy Zou <joy.zou@nxp.com>
Cc: peng.fan@nxp.com, vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, imx@lists.linux.dev, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dmaengine: fsl-edma: Remove unused
 "fsl,imx8qm-adma" compatible string
Message-ID: <ZhfzxQKkP4G1KDFS@lizhi-Precision-Tower-5810>
References: <20240411074326.2462497-1-joy.zou@nxp.com>
 <20240411074326.2462497-2-joy.zou@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240411074326.2462497-2-joy.zou@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Uy59PsjUylMJRenVPFE9SEbGoHMeOc37HY4dcivjVXNarnfvxfvaq2VE5FnU?=
 =?us-ascii?Q?S871w3Xb67+S+LYwta3ea5WOfWoVHLsOqaPoTCYCDCupKhON+jQadkFg/xZM?=
 =?us-ascii?Q?pRj9kwhwBDwA27do6rtViPFJ7qa29e7KP2NNogedQMdSngZmj4lx/llm3pmA?=
 =?us-ascii?Q?EIsdPJXa8lnyB1coVDbH8EhDGpCoH54VrpCUAJd09HOt+VpYl/8wNYJf0Kxa?=
 =?us-ascii?Q?0jW/HXGwB2pPhmthPuaoPfzfr0dNB8opNW1SKac8gRv5KC2iW+Ng8oGbM/X3?=
 =?us-ascii?Q?si0wUTVgN4ud3Kze2K5pDvhK4uch3IMFTbzyr4kb4D7yS8W5Vvql3KCsxKQq?=
 =?us-ascii?Q?HxUVNiF6Cib8Mqg2DkgruwLw8TYWn53c9SyyXBYJcQ6MXEC6GEieM0qMMdLM?=
 =?us-ascii?Q?3RH2f5n9AATLFP79kIBuaAVfliHhOLPVoWJgcp7lf5plC+gdUOBr25+iMG8t?=
 =?us-ascii?Q?fv4/4O7JjbqaEEPsgxxLUgb4ReFoIYQEWnezYXENBpkuy+aAFqTbPo4+cJPX?=
 =?us-ascii?Q?GBjEVrBNdrFtFOYxNM9yw1wkyf+nLgE60Yf9Hc9kpaOiYZSXHMO2hvZUs5o7?=
 =?us-ascii?Q?IOQKcHKCQOqek13qu8pxoeXWm9BGdz61k+wQlKTno4wYoLE73iWTV8HGQAb0?=
 =?us-ascii?Q?5VPX79ledfPZjwt7trvlmIViVhwU2gUXg0lzZHAsV3+wyy+UPSrlnr3G7A6H?=
 =?us-ascii?Q?Vsas0Nx2J6wtMDMOhcqcBLXK1vIz+qGzVlr+uJpiuDfiTmf/kXIGB8u4PHcs?=
 =?us-ascii?Q?X1ZW2OhDkIDpAqUKOtAh1NAjory+UvGeTVvZ18u2khM17gK4BNB4DmIeFyWf?=
 =?us-ascii?Q?s6I9g4FNBQjXo10o1Uv8ZAUyHtReP4LNAp6yTcviBJUgN84ZFglpPUxanlPf?=
 =?us-ascii?Q?8ywYY1n7z5wkgT/DXrp9vFWaLCi1bow/M5bHcJYTb/LtKiwDe1UUo9/n8LaJ?=
 =?us-ascii?Q?i+ONRufhHB82yoOCl1gJ/mGMrzZ1JPSXKciCHe8kI00iQxMWZYCN0Fd+3muz?=
 =?us-ascii?Q?4ZcO9xPd4RLJFr1z+cdb/GF0KJ1v2fe67UCtPVsd9sXy6MmxXkbDjYE6zJ8n?=
 =?us-ascii?Q?1dpZnk3X5RtCB45hlvayNxpitIvpEEJE7aAaRI9uklAZ6FbFY9kHnhfvQnb2?=
 =?us-ascii?Q?t+FqICLwoka3jZIBeDVG0LfpSdFdDh2iKwgaYiYqTvTSo3j3ejnlhQVvBtvZ?=
 =?us-ascii?Q?vSuFfl7C4d8bu8mgaKsrIwoUq/fS1NKeVswVGKihzy+dPcu5E7JKtJiYaWPc?=
 =?us-ascii?Q?xdCb++HlGgBYZZlBtSKNwVvFa8abC2jUIwkKDHifSMo5PTcnTfxQzlJB0ZRM?=
 =?us-ascii?Q?nPNTtfgKOy0WK7IM1x2aZ/ol1w1mCBpFhkfRI7ep0hhmMG3E0nxVNizf0Yb2?=
 =?us-ascii?Q?F/ydBvf2DijdJLW+3Um+IiNiTyXl+l9SUgu5saBZB05rjOZCKnmf/Twm4u+C?=
 =?us-ascii?Q?TJ55Kv+cW6XF0VFtjBCE4sbDdbVN+x2A05Z/yAOvsmOGeSD0Df/KDvt+CAnx?=
 =?us-ascii?Q?oQDn61NilGDH8hhmY66UN3xmmbdf5iyiJlbUhWzTun0u7i4gmyQRh1nKp6F4?=
 =?us-ascii?Q?sZLSHAG63aGHzrUZE5GDOsG48j0BswbpChAa1pIh?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8fe219c-d890-40a5-eb48-08dc5a33cdb3
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 14:29:32.4150
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xyc3WEg4YHPfImZeQg1wvQAuKWUn3RNvbpafHK0YfZr6gIgOMOzvauMO2usv1P7t6Wo2Q3x1dMdqEhTAGC80EQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7384

On Thu, Apr 11, 2024 at 03:43:25PM +0800, Joy Zou wrote:
> The eDMA hardware issue only exist imx8QM A0. A0 never mass production.
> So remove the workaround safely.
> 
> Signed-off-by: Joy Zou <joy.zou@nxp.com>
> ---
> Changes for v2:
> 1. Change the subject.
> ---
>  drivers/dma/fsl-edma-common.c | 16 ++++------------
>  drivers/dma/fsl-edma-main.c   |  8 --------
>  2 files changed, 4 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
> index f9144b015439..ed93e01282d5 100644
> --- a/drivers/dma/fsl-edma-common.c
> +++ b/drivers/dma/fsl-edma-common.c
> @@ -75,18 +75,10 @@ static void fsl_edma3_enable_request(struct fsl_edma_chan *fsl_chan)
>  
>  	flags = fsl_edma_drvflags(fsl_chan);
>  	val = edma_readl_chreg(fsl_chan, ch_sbr);
> -	/* Remote/local swapped wrongly on iMX8 QM Audio edma */
> -	if (flags & FSL_EDMA_DRV_QUIRK_SWAPPED) {

Please also remove FSL_EDMA_DRV_QUIRK_SWAPPED macro define in
fsl-edma-common.h

Frank

> -		if (!fsl_chan->is_rxchan)
> -			val |= EDMA_V3_CH_SBR_RD;
> -		else
> -			val |= EDMA_V3_CH_SBR_WR;
> -	} else {
> -		if (fsl_chan->is_rxchan)
> -			val |= EDMA_V3_CH_SBR_RD;
> -		else
> -			val |= EDMA_V3_CH_SBR_WR;
> -	}
> +	if (fsl_chan->is_rxchan)
> +		val |= EDMA_V3_CH_SBR_RD;
> +	else
> +		val |= EDMA_V3_CH_SBR_WR;
>  
>  	if (fsl_chan->is_remote)
>  		val &= ~(EDMA_V3_CH_SBR_RD | EDMA_V3_CH_SBR_WR);
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 755a3dc3b0a7..b06fa147d6ba 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -349,13 +349,6 @@ static struct fsl_edma_drvdata imx8qm_data = {
>  	.setup_irq = fsl_edma3_irq_init,
>  };
>  
> -static struct fsl_edma_drvdata imx8qm_audio_data = {
> -	.flags = FSL_EDMA_DRV_QUIRK_SWAPPED | FSL_EDMA_DRV_HAS_PD | FSL_EDMA_DRV_EDMA3,
> -	.chreg_space_sz = 0x10000,
> -	.chreg_off = 0x10000,
> -	.setup_irq = fsl_edma3_irq_init,
> -};
> -
>  static struct fsl_edma_drvdata imx8ulp_data = {
>  	.flags = FSL_EDMA_DRV_HAS_CHMUX | FSL_EDMA_DRV_HAS_CHCLK | FSL_EDMA_DRV_HAS_DMACLK |
>  		 FSL_EDMA_DRV_EDMA3,
> @@ -397,7 +390,6 @@ static const struct of_device_id fsl_edma_dt_ids[] = {
>  	{ .compatible = "fsl,ls1028a-edma", .data = &ls1028a_data},
>  	{ .compatible = "fsl,imx7ulp-edma", .data = &imx7ulp_data},
>  	{ .compatible = "fsl,imx8qm-edma", .data = &imx8qm_data},
> -	{ .compatible = "fsl,imx8qm-adma", .data = &imx8qm_audio_data},
>  	{ .compatible = "fsl,imx8ulp-edma", .data = &imx8ulp_data},
>  	{ .compatible = "fsl,imx93-edma3", .data = &imx93_data3},
>  	{ .compatible = "fsl,imx93-edma4", .data = &imx93_data4},
> -- 
> 2.37.1
>