Received: by 2002:ab2:7988:0:b0:1f4:b336:87c4 with SMTP id g8csp79522lqj; Thu, 11 Apr 2024 10:17:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXwtdXTknfWJC+lWSBn1KtkM+5KBp0wnqjgfUy37A7J9J6/ZHq2PsPMTvadJl60uyptxhklEjwnMPjSJEVhyqkzOfglHgciHrMWqA1yXQ== X-Google-Smtp-Source: AGHT+IEhTQzvJYoWdrT4EiG9YWzVt+Ayv1KGLOw82dYR2HYH7OMmIpjdxDDbCehgqpuuSLl5g3E3 X-Received: by 2002:a05:6214:807:b0:69b:1c3f:4554 with SMTP id df7-20020a056214080700b0069b1c3f4554mr383033qvb.17.1712855844917; Thu, 11 Apr 2024 10:17:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712855844; cv=pass; d=google.com; s=arc-20160816; b=I7k8SkDSq/WqDRl+pXYpL7oj/7NuClEIasxHwwVyA/82AGx7lvcX1KIYi45GwHaTuG bnsSJL8onej26epJ3MjzQBTFOikP1f/35EJBn59l8y5F5VGxyj2q1tuqBkhHSIHs82M7 2oPOlDXnRoF3lxo9d50tKLCiCY/kWdD8zjT0YCilSvO4oJiGYkcx5KJzD5Ih1+wUlPHd S0OW0jB205T/YZrtra3x8M2BfSpwim0rZ2K+2ufpRHbbJligwmah9klQppHPg7xVgotl D4pbQThDQSLHszOjWvaRDa55eJVXdlTFGEOczFLBBXh5aiQA5KelVqUOjg58IoSt5Z09 5Ilw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=sLDFFXmHm+yf97UNhVDE2sYWEmux0LMIJIrRi9jb2uU=; fh=N9Y0IwdJYteZyjw67LK/bsLWrYmFnI1NxRod/Rtoz40=; b=VgnLEM8VeLU0pjSQFDgievAaxBfwKg0h8BoBd9TJVTudwGEBISSv8Tta72kUs9gB/0 k97k2g4/MVsMj5vEy+KAdN/Y1WSiU0g/8ctFBN5V09PXe1fg5JYYmPWsBZgLsFa68u3Z 2ufZ6XMfP6lqF05uJaA98kO6o1iDnS6jbpXR0Sw+MY3QM1vt3jLzp3v374bEWAEc+sTn ShGpOS3noiFut8DowsVL0RJxWVt5h83nvI5zp48Z22QozaQE4ZZCM01Opr9DAqYKvOOs hsWuK++878evBbtB2y4FTgnr2eq3nk4WK88Uprrb79XP1+dR+SzfNV2f8o0xpM8SvWFK rLaQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lrwhKEXH; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-141208-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141208-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id eu13-20020ad44f4d000000b0069b1ed8ea7bsi1865128qvb.258.2024.04.11.10.17.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 10:17:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-141208-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lrwhKEXH; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-141208-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141208-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2BD6C1C2232A for ; Thu, 11 Apr 2024 17:16:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA9C653390; Thu, 11 Apr 2024 15:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lrwhKEXH" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5252A1FFC3A for ; Thu, 11 Apr 2024 15:43:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712850211; cv=none; b=i3xqwfHCXYPftipRJSH+QHfpKpMehnpUOqS+hSpdN9OlPlhAZyPio3QGJ1Kzx3mGTi+Sb2MO5533WLB0j1cYbH+cuYSF0hGRWcUBaIddw4WOLP3OyoULpJ6Ue67yimlqiMHF8ZL5+68FWHbB1/3v9jxStcRh0I1ZntfcmRA+XiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712850211; c=relaxed/simple; bh=MOMp6xSzpZJ/Pd9oy9m//zqob+TNdkNGOXiGMSI3XoI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zq8T3QE+xzwXdi1+EpVcQb/4+1hz1sJyROdLnrL6k2BJNRkhzjsEvb1+qbyMJAbeh3ADXLdLBBRTccmaxJ9HpDepnq3PcupkjlavR7tGlUNLcsXMMotMjRX7rRruwPTExZoeJF/28VyRf0/BDqyzh/jWn3KZ/ue3WqdgjWW9+vw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lrwhKEXH; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712850210; x=1744386210; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=MOMp6xSzpZJ/Pd9oy9m//zqob+TNdkNGOXiGMSI3XoI=; b=lrwhKEXHWV8qwzYblvS1peVCuvu0Jd87qYeF5fOH2nIoaMN3sQ4SV/l2 ckDsMKMIlawE1hjm2iCRSz/S11vq3Z6S4IicPG5XsZOydwsI4L4TZTXZM 6zwSWEskGJHHQv+IxPr2mB8worxga5O0k0pBn5swdRDEL3hFt3IVvbAEy TOrrORCoKntDh97F7Qu/3aVfTjyxsKFcDlI9mZH03GXLbD0swlKH2Q3y+ I0u2SwBEA7YI/5PBU/8BN6VcEwLfs86YcqGmHUPkX0yj/lwAGbxcyJqte ROkLTgIpy6UXwixG2x0tpqQ8K85/2z5O2+fPopEH7ybKnAClr0hpL6uZr w==; X-CSE-ConnectionGUID: mTbPDmSLRCiaGRtyGfEQxg== X-CSE-MsgGUID: T//SbJdaQ2eIDfnp7xJEEw== X-IronPort-AV: E=McAfee;i="6600,9927,11041"; a="30749443" X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="30749443" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 08:43:29 -0700 X-CSE-ConnectionGUID: vNoOrQo8TUapo9H4WFRQKQ== X-CSE-MsgGUID: l4Fv5RjWQuaNE6rnNyAhvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="21430413" Received: from tgrabows-mobl.amr.corp.intel.com (HELO [10.209.89.64]) ([10.209.89.64]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 08:43:29 -0700 Message-ID: Date: Thu, 11 Apr 2024 08:43:29 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] x86/mm: Don't disable INVLPG if "incomplete Global INVLPG flushes" is fixed by microcode or the kernel is running in a hypervisor To: Xi Ruoyao , Dave Hansen , Michael Kelley , Pawan Gupta Cc: Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Sean Christopherson , Andrew Cooper References: <20240411104822.6429-1-xry111@xry111.site> <3ee70b6c-3399-43f9-8934-cb5a0e51f006@intel.com> <1f5d53596e2ac8948332570e3bda17c3877fd499.camel@xry111.site> <99d6583a-1541-499f-a682-e1818507e472@intel.com> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <99d6583a-1541-499f-a682-e1818507e472@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/11/24 08:18, Dave Hansen wrote: > >> I'm not a native English speaker, so could you give some hint about how >> to write this comment clearly? > Something like this would be fine: > > /* Only bare-metal is affected. PCIDs in guests are OK. */ One more thing... Instead if cluttering up the main PCID setup path that everybody has to read, you can put this in the macro: #define INTEL_MATCH(_model) \ { \ .vendor = X86_VENDOR_INTEL, \ .feature = X86_FEATURE_HYPERVISOR \ .family = 6, \ .model = _model, \ } Then you can supplement the "INVLPG may not properly flush Global entries..." comment. /* * INVLPG may not properly flush Global entries. But * it only misbehaves when PCIDs are in use on bare * metal on specific CPU models. It is completely * fixed with updated microcode. */