Received-SPF: pass (google.com: domain of linux-kernel+bounces-141241-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 11 Apr 2024 17:55:54 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: parker@finest.io
Cc: Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH 2/2] serial: exar: adding CTI PCI/PCIe serial port
 support to 8250_exar
Message-ID: <2024041147-flogging-straining-910c@gregkh>
References: <cover.1712846025.git.pnewman@connecttech.com>
 <9ffdef053f455c87f705dff169346bc10d307787.1712846026.git.pnewman@connecttech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9ffdef053f455c87f705dff169346bc10d307787.1712846026.git.pnewman@connecttech.com>

On Thu, Apr 11, 2024 at 11:29:27AM -0400, parker@finest.io wrote:
> From: Parker Newman <pnewman@connecttech.com>
> 
> This patch adds support for most of Connect Tech's (CTI) PCI/PCIe
> serial cards to the 8250_exar driver.
> 
> Major changes:
>  - Added (optional) board_setup function called once during probe
>  - Added exar_get_nr_ports function
>  - Removed old Connect Tech setup functions
>  - Added new UART family based CTI setup functions
>  - Added PCI IDs entries for Exar XR17V25x and CTI FPGA based cards
>  - Added MPIO functions for configuring/setting a single MPIO
>  - Added support for reading from the Exar EEPROM

When you need to list the different things you did in a single patch,
that's a huge hint it needs to be broken up into smaller, easier to
review, pieces.

> 
> Signed-off-by: Parker Newman <pnewman@connecttech.com>
> ---
>  drivers/tty/serial/8250/8250_exar.c | 1089 +++++++++++++++++++++++++--
>  1 file changed, 1019 insertions(+), 70 deletions(-)

Reviewing 1000 lines of changes at once that does different things,
isn't easy.  Please break this up into smaller,
one-logical-step-at-a-time patches.

thanks,

greg k-h