Received-SPF: pass (google.com: domain of linux-kernel+bounces-141248-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <6c363e03-23e4-4ab2-b66a-aeb179cbacff@gmail.com>
Date: Thu, 11 Apr 2024 18:00:09 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH net-next v6 2/6] net: gro: add p_off param in
 *_gro_complete
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>, davem@davemloft.net,
 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org,
 dsahern@kernel.org, aduyck@mirantis.com, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
References: <20240410153423.107381-1-richardbgobert@gmail.com>
 <20240410153423.107381-3-richardbgobert@gmail.com>
 <6617493095ee1_2d6bc6294fc@willemb.c.googlers.com.notmuch>
 <66175ca5e3621_2dde6a2947c@willemb.c.googlers.com.notmuch>
From: Richard Gobert <richardbgobert@gmail.com>
In-Reply-To: <66175ca5e3621_2dde6a2947c@willemb.c.googlers.com.notmuch>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Willem de Bruijn wrote:
> And the latter parse the network header for total_len/payload_len, to
> find their original offset.
> 
> It's also a bit of a hack. But a lot smaller patch, probably.


While producing a smaller change - this is a bit of a hacky code change.
My initial idea was to use network_offset added to the CB in the 4th commit
- making a very small change. (https://lore.kernel.org/netdev/446695cb-50b8-4187-bf11-63aedb6e9aed@gmail.com/)

Eric suggested it'd make more sense to pass it off as a parameter
throughout the complete chain.