Received-SPF: pass (google.com: domain of linux-kernel+bounces-141261-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 11 Apr 2024 17:03:10 +0100
From: Mark Brown <broonie@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, John Stultz <jstultz@google.com>,
	Marco Elver <elver@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Dmitry Vyukov <dvyukov@google.com>, kasan-dev@googlegroups.com,
	Edward Liaw <edliaw@google.com>,
	Carlos Llamas <cmllamas@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] selftests/timers/posix_timers: reimplement
 check_timer_distribution()
Message-ID: <280faf88-9bcd-4f0d-b02a-eb72cbefbb3e@sirena.org.uk>
References: <CANDhNCoGRnXLYRzQWpy2ZzsuAXeraqT4R13tHXmiUtGzZRD3gA@mail.gmail.com>
 <87o7aqb6uw.ffs@tglx>
 <CANDhNCreA6nJp4ZUhgcxNB5Zye1aySDoU99+_GDS57HAF4jZ_Q@mail.gmail.com>
 <87frw2axv0.ffs@tglx>
 <20240404145408.GD7153@redhat.com>
 <87le5t9f14.ffs@tglx>
 <20240406150950.GA3060@redhat.com>
 <f0523b3a-ea08-4615-b0fb-5b504a2d39df@sirena.org.uk>
 <87il0o0yrc.ffs@tglx>
 <20240411155053.GD5494@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="6X+i8LxTiBMSWKj7"
Content-Disposition: inline
In-Reply-To: <20240411155053.GD5494@redhat.com>


--6X+i8LxTiBMSWKj7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 11, 2024 at 05:50:53PM +0200, Oleg Nesterov wrote:
> On 04/11, Thomas Gleixner wrote:

> > Grrr. Let me stare at this.

> Damn ;)

> Can't we just turn ksft_min_kernel_version() into

> 	static inline int ksft_min_kernel_version(unsigned int min_major,
> 						  unsigned int min_minor)
> 	{
> 	#ifdef NOLIBC
> 		return -1;
> 	#else

That'd probably work well enough here.  I think it's reasonable for
someone who wants to build a test that uses ksft_min_kernel_version()
with nolibc to figure out how to implement it, right now it's not
actually getting used with nolibc and just happens to be seen due to
being in the same header.

> Not sure what should check_timer_distribution() do in this case, to me
> ksft_test_result_fail() is fine.

I'd go with skip but yeah.

--6X+i8LxTiBMSWKj7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYYCb4ACgkQJNaLcl1U
h9Corgf+If9pRewR2Sf7yuBxPHFwhekXG3uOsPuQGQrq/fl0/zgB+V1ToPn9FsrD
+INicy+H4EAfPy4Zr1aWOSJc9O9fsavsvYg59sfnRmYiwSHjQEbIj0ZUSVzEpCRH
39YNs2AEF8MtR0530GNjsDJqYFGdGj/ZCkcgaAHLrvkTWe97LPNaFDhxRfvR6HJz
Y9Dub0bcfCQUt9bg2zGOMzgdll5TF6h2TApiEeedMpS0qO6/uvDH8Ws1gnVlH2dV
HNW/grfhC5too7+GFpDDnBDaWaWD3vWDwuVDcGIWm1Nm9e8Yi1pwjXiGXSRMsBID
8MBmTlnBXsIEKJEnVpTu9zVw9Fg1Sw==
=G3lU
-----END PGP SIGNATURE-----

--6X+i8LxTiBMSWKj7--