Received-SPF: pass (google.com: domain of linux-kernel+bounces-141296-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 11 Apr 2024 17:14:23 +0100
From: Conor Dooley <conor@kernel.org>
To: Michael Opdenacker <michael.opdenacker@bootlin.com>
Cc: Jisheng Zhang <jszhang@kernel.org>,
	Inochi Amaoto <inochiama@outlook.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chen Wang <unicorn_wang@outlook.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board
 device tree
Message-ID: <20240411-persuaded-symptom-b14a8cfee57f@spud>
References: <20240409064504.4010353-1-michael.opdenacker@bootlin.com>
 <IA1PR20MB49532A8D4294ADCE0C33A654BB072@IA1PR20MB4953.namprd20.prod.outlook.com>
 <20240409-prevent-deepness-2d22bf009b16@spud>
 <IA1PR20MB49534E00CAE29D24F7D7E718BB072@IA1PR20MB4953.namprd20.prod.outlook.com>
 <1514d28a-5e96-4531-a972-894e41902efa@bootlin.com>
 <IA1PR20MB4953CA04D33EA0C7902DFA3ABB062@IA1PR20MB4953.namprd20.prod.outlook.com>
 <ZhZo0iJFSn1te-6d@xhacker>
 <5fdda638-21ba-4fa7-b666-33cf2fd69dda@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="MFXo6Ns2Jdu07e2i"
Content-Disposition: inline
In-Reply-To: <5fdda638-21ba-4fa7-b666-33cf2fd69dda@bootlin.com>


--MFXo6Ns2Jdu07e2i
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 11, 2024 at 10:35:55AM +0200, Michael Opdenacker wrote:
> Hi Jisheng,
>=20
> On 4/10/24 at 12:24, Jisheng Zhang wrote:
> > setting the correct bus-width is necessary for better performance
> > no-1-8-v can be removed, but it doesn't harm anything because
> > the board doesn't supply 1.8v
> >=20
> > no-mmc and no-sdio to make the probe a bit quicker
>=20
> Many thanks for your advice!
>=20
> However, whether I apply these changes or not,
> git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git is now broken for
> me:
> Error: arch/riscv/boot/dts/sophgo/sg2000-milkv-duos.dts:32.1-8 Label or p=
ath
> sdhci0 not found

This is probably just because you need to use the for-next branch of
https://github.com/sophgo/linux.git as your base. Palmer doesn't apply
dts patchs to the riscv repo. Usually working on linux-next is fine for
these kinds of activities.

> I was previously testing with linux-next, but it's now broken too, though=
 in
> a different way:
> [=A0=A0=A0 1.306811] /dev/root: Can't open blockdev
> [=A0=A0=A0 1.311200] VFS: Cannot open root device "/dev/mmcblk0p2" or
> unknown-block(0,0): error -6
>=20
> Shall I submit my updates anyway?

This is probably worth investigating by someone, providing a longer log
would help if you don't wanna do so yourself. Did you rebase on a more
recent linux-next and this cropped up?

--MFXo6Ns2Jdu07e2i
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZhgMXwAKCRB4tDGHoIJi
0izEAP9BMtHM9XrULQAvBFk8Lzjfx7aDOB1RFamiBRseR4yYvQD+LVtg9ja4UyKL
TWkuivznsZkY8kuYquTYOwl8jiAijQY=
=HZD6
-----END PGP SIGNATURE-----

--MFXo6Ns2Jdu07e2i--