Received-SPF: pass (google.com: domain of linux-kernel+bounces-141312-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 11 Apr 2024 12:22:48 -0400
From: Parker Newman <parker@finest.io>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
 linux-pci@vger.kernel.org, Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH 1/2] serial: exar: add missing CTI/Exar PCI IDs to
 include/linux/pci_ids.h
Message-ID: <20240411122248.5070c840@SWDEV2.connecttech.local>
In-Reply-To: <2024041124-blah-obligate-5f6d@gregkh>
References: <cover.1712846025.git.pnewman@connecttech.com>
	<936439b200c810f83076a710eab81acd1e79ec83.1712846025.git.pnewman@connecttech.com>
	<2024041124-blah-obligate-5f6d@gregkh>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:aqGDdD3EIFw=;0d/rEnUuyg9oWdY1xKNe5Pmvl2G
 WU7QwO4nHirmSzCqtDlmcV/WSXbBG7VJxtepxuiPwS8GwORoMCD9ZOGPAW9xvLkIJxJJONyXU
 8EcFP873ITtDy1J1V/jgGgRAWl7G9opSSwlE1VYVCphddQmbj1qKtIEcLZQrOCvaWGOxqMFoB
 8fx1fjjjlPrrsVzJHDrTU5Wtg/ZRWgnZtPbqCk7Yvx3OSvPfodBH8NozhaJ9i2LWdQh42vlpW
 4rGZVKzrsz7nNnBFME+InyMfwIQj7RumBNzbFCcFen0UZHJPSeQNv8SUJxa4E/HqaSrb8PUBJ
 Q0EgXFIngPygONnDfpwSu24npTFDyGqQ/p2KeOUZ8yn1hW2wkyq2YTRSCvuEFqCr75o7Objnm
 +B2I3EKSBg92jZP5gJWmoKBBkfrojUmaq8iYUeCcGZZFCPKos1vA6EwELt1yewjHjZBfPxywl
 zKvaq/+7wMD1s4BRkpLIt53PP018mzaFIKH8Nya+nu1jue2MhesiuGkzc4r3nEDLbud/AJBH0
 C2u7Cgx8a6iqHbVl1KmLVKdJ9EzJDa0y9w+04dIjibLCj6hPDGDMbWyeR940j+lqICrUIyzrb
 Gg3hve4K2vgO9iyt8G9BxQMBQJiqmTJWUB4BhSlK74t4drNqcUEXDOvkcveSGINONMJhSt78Y
 krDZWB5rGiTT7P28SGaHP2nwfwQqicGdPoS9LRJG5HyuwIz+s1IOeLZ4k04jUMiqC2TIg/Y/F
 XiWCDchRsD061WMxoIQ2OLAN0i9UXpKnFIOXCgbPxJURIjSZkbzPtE=

On Thu, 11 Apr 2024 17:54:45 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Thu, Apr 11, 2024 at 11:29:26AM -0400, parker@finest.io wrote:
> > From: Parker Newman <pnewman@connecttech.com>
> >
> > - Added missing CTI serial car PCI IDs
> > - Added missing Exar XR17V25X PCI IDs
> > - Moved XR17V4358 and XR17V8358 PCI ID defines to pci_ids.h
>
> Did you read the top of the pci_ids.h file?  Don't add new ids there
> unless it is going to be needed in multiple files please.
>
> thanks,
>
> greg k-h
No sorry I missed that... I was just trying to consolidate them all
in one place.

Would it be better to move all the Connect Tech sub-IDs from
pci_ids.h into 8250_exar.c? Or should I just add the missing ones
to 8250_exar.c instead of pci_ids.h?

Thank you,
-Parker