Received-SPF: pass (google.com: domain of linux-kernel+bounces-141347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e23420bb-0d97-4546-a2ae-8bfe3c10e259@arm.com>
Date: Thu, 11 Apr 2024 17:45:41 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 0/2] mm: add per-order mTHP alloc and swpout counters
Content-Language: en-GB
To: Barry Song <21cnbao@gmail.com>, Andrew Morton
 <akpm@linux-foundation.org>, david@redhat.com
Cc: linux-mm@kvack.org, cerasuolodomenico@gmail.com, chrisl@kernel.org,
 kasong@tencent.com, peterx@redhat.com, surenb@google.com,
 v-songbaohua@oppo.com, willy@infradead.org, yosryahmed@google.com,
 yuzhao@google.com, linux-kernel@vger.kernel.org
References: <20240405102704.77559-1-21cnbao@gmail.com>
 <20240405131140.8881aae1af0d877dc70c8ea9@linux-foundation.org>
 <CAGsJ_4zpKmha2YtnsuDdda9_w4MtPZrk=SbdnBhJbdoA9HbogA@mail.gmail.com>
From: Ryan Roberts <ryan.roberts@arm.com>
In-Reply-To: <CAGsJ_4zpKmha2YtnsuDdda9_w4MtPZrk=SbdnBhJbdoA9HbogA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 05/04/2024 23:04, Barry Song wrote:
> On Sat, Apr 6, 2024 at 9:11 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>>
>> On Fri,  5 Apr 2024 23:27:02 +1300 Barry Song <21cnbao@gmail.com> wrote:
>>
>>> The patchset introduces a framework to facilitate mTHP counters, starting
>>> with the allocation and swap-out counters. Currently, only four new nodes
>>> are appended to the stats directory for each mTHP size.
>>>
>>> /sys/kernel/mm/transparent_hugepage/hugepages-<size>/stats
>>>       anon_alloc
>>>       anon_alloc_fallback
>>>       anon_swpout
>>>       anon_swpout_fallback
>>
>> Please let's get these documented?
> 
> Sure, I will do it.
> 
> Furthermore, after careful consideration, I suggest renaming anon_alloc to
> anon_fault_alloc and anon_alloc_fallback to anon_fault_fallback. This
> renaming is consistent with the naming convention observed in
> thp_fault_alloc and thp_fault_fallback in vmstat. Additionally, this
> modification will facilitate the handling of large folio swap-ins.
> 
> /sys/kernel/mm/transparent_hugepage/hugepages-<size>/stats
>            anon_fault_alloc,
>            anon_fault_fallback,
>            anon_swpin_alloc,
>            anon_swpin_fallback,
> 
> Otherwise, without this renaming, it would be difficult to
> differentiate fault_alloc
> from swpin_alloc.
> 
> Hi David, Ryan,
> I would also appreciate your input on the modification I am considering.

Yes, this makes sense to me!

> 
>> Documentation/admin-guide/mm/transhuge.rst seems to be the place, and
>> under Documentation/ABI.
> 
> Thanks
> Barry