Received: by 2002:ab2:7988:0:b0:1f4:b336:87c4 with SMTP id g8csp104311lqj; Thu, 11 Apr 2024 11:03:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW2+nE01NKNmdny/n9cokbNOo85CCAjLpjSfmynWyyN2nnc9vOnbmqTi54SlvejdafwcKbJHRHzAt7nX84x7IxgcWtjioT53JSpwNbB8g== X-Google-Smtp-Source: AGHT+IH7qjpDbwfgtrMQHZkfzF+tcY2lgYteyHbm2v6UdL9Rxndyy6ryCy+mzVgEyqXZtX3uoJJK X-Received: by 2002:a05:6402:5213:b0:56f:eea2:43e5 with SMTP id s19-20020a056402521300b0056feea243e5mr1336110edd.7.1712858629780; Thu, 11 Apr 2024 11:03:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712858629; cv=pass; d=google.com; s=arc-20160816; b=rqlDzsy3mmYcukz5UaErlfX+kWfBVnII2bSTjQM9GZE2cM3N+EZ6cq84aFkQYPs7Bg qfsPSoSlyQS3Ds+V/tgIdSN3gIicWUtvUpuvPIQDZK0WplIVJ0gY/vl6k2D6UpOI7Oqk boQtmaE644Xwcof2wqmDY8VMrdFoC/6FvtthJATw3+gmvBA9Fqph17SqxMn34bEVFr2/ NY5HImTc9P8zd+nCyqTd9OE6Qzgc7YX4kU43TDNP6rPRpaT3G/xbPnHmhcnQAMYE6Du7 WTXXFh8RT/IUo+bdn4GbL4K8Ad8u3EwouooZDAhLbOv72Os4ltAJh7zqV4mjH1xsYt/B UWkQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=okeAvFfUEaK896RIWOik8lHqxHZXxstaNcHrNypDUOY=; fh=DyRaSnRISiqDt5CDhz4Su+gDWSuaudtSkJNgSDCx+yM=; b=B/iwQ2kc5S0zaVYMK9pYa2Ev+sYEX23fuy0XssNo8+VrUn3UAgwYxjQKNXwcflBOmn 7LPLEP3vLkfBtNXjIFVlL32Q5kM3WPNBqkapamk/7YCrqlsADxJjflD9yMyXesNdE8FC tiCIL85CW+KiOn5zP5vDeCXnJ8EgkHpC0AdkEXEFGOiA8tt9wYg9jDDwvTkN5gj4Kl8U QOSJJ70al0UFrDjv3OwZGTLGTVCYxACIx7kgvDOlQGmLdHEViXv4CnWlejQ42nJfAhek 21YqOJR1AkqyvvL69saDb92aoj8Nkv9rGCGe/m9TLqV5PRXLWj/IEKo4yiy7cE3PrqvL /LIA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SRw9gbg3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-141352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141352-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id e11-20020a056402190b00b0056e2e8a7b1bsi988634edz.599.2024.04.11.11.03.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 11:03:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-141352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SRw9gbg3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-141352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141352-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 83A8A1F240F7 for ; Thu, 11 Apr 2024 18:03:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 72B601CAE80; Thu, 11 Apr 2024 16:48:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SRw9gbg3" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93B911CAE62; Thu, 11 Apr 2024 16:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712854120; cv=none; b=DwxNgK7JCTBOJH+D78ifVNfManuj2CVtaXkcG1KzQoZZ+TtKldRPEFs0WB7/wj0JFQ5TrMw1P8Tti3haOly/1f8CpHPi5HVf+sxeFqTCsRWbToVRsvk/CP40uS2vB2SWq069pMMr52CQT8rhvq6E+8fiV8uPsZMss35Lr144WKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712854120; c=relaxed/simple; bh=LWlrTCJGqYKdS9PYJSR2H64H7PQGjxik5FHnH+YFRek=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=b4lghRai251c1Q5i7kqeWDYa1bgsyzRAOjWRGQx1PS6QEbpplD73QKvrN45NcfJtzPGANI8qYw60DPA6mRb8byAQU4I3wFcCJjlv+HEQzXNF+dWzjy2YVG1XENuAOedOEujy+bLXKySDXB9j3m9v038O0+j5obhvP12tYOkWsX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SRw9gbg3; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11011C072AA; Thu, 11 Apr 2024 16:48:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712854120; bh=LWlrTCJGqYKdS9PYJSR2H64H7PQGjxik5FHnH+YFRek=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=SRw9gbg3ILr9SlXTXTQ+BUnw1oNfqMDP46YMiFKH2ywD5rU1P0dEI+ifC98brtzT3 sK/T8pTySfw5lZUKqDGe0eomeXbvOgcJM/BmFRtMyceO9GX3DEYpYSdTMuatLQPJxf nLplnjGvyUcQBu8NuzBliq2HTBtzk1/Fcj/fZKzNGAXhRQHB2JVF12XTExdynCf9t8 iSd6+nVzTg9fkeIUENqsjt2GH2BlY0YH44BpSEAJyqvHQScjw5PfyNprZUfnH0d4xT 8scaN3SbJU5zDwE2FhccU4BjirKFtM2vAR5V2+KZcKZ+bIF59FTLnEtNBJBPHycIyy /Ptqgg7AuvOGA== From: Lee Jones To: pavel@ucw.cz, lee@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, ChiaEn Wu Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, peterwu.pub@gmail.com, cy_huang@richtek.com In-Reply-To: <28FE6F1712799128000.chiaen_wu@richtek.com> References: <28FE6F1712799128000.chiaen_wu@richtek.com> Subject: Re: (subset) [PATCH] leds: mt6360: Fix the second LED can not enable torch mode by V4L2 Message-Id: <171285411780.2498946.3824215880975158305.b4-ty@kernel.org> Date: Thu, 11 Apr 2024 17:48:37 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.4 On Tue, 09 Apr 2024 18:21:54 +0800, ChiaEn Wu wrote: > V4L2 will disable strobe mode of the LED device when enable torch mode, > but this logic will conflict with the "priv->fled_torch_used" > in "mt6360_strobe_set()". So after enabling torch mode of the first > LED, the second LED will not be able to enable torch mode correctly. > > Therefore, at the beginning of "mt6360_strobe_set()", check whether the > state of the upcoming change and the current LED device state are the > same, so as to avoid the above problem. > > [...] Applied, thanks! [1/1] leds: mt6360: Fix the second LED can not enable torch mode by V4L2 commit: 0dcd0488a7a5b8762256b393a8bd0c21e5e4e0fb -- Lee Jones [李琼斯]