Received-SPF: pass (google.com: domain of linux-kernel+bounces-141411-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <7e418360-33b4-4a6f-b520-5a35e110e2d9@intel.com>
Date: Thu, 11 Apr 2024 10:36:15 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 06/31] x86/resctrl: Export resctrl fs's init function
To: Dave Martin <Dave.Martin@arm.com>
CC: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Thomas
 Gleixner" <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "Borislav
 Petkov" <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>, Babu Moger
	<Babu.Moger@amd.com>, <shameerali.kolothum.thodi@huawei.com>, "D Scott
 Phillips OS" <scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-7-james.morse@arm.com>
 <e74077e1-3c5b-4126-a567-4b4b04f5367d@intel.com>
 <ZhfwXXoe4k+JusWo@e133380.arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ZhfwXXoe4k+JusWo@e133380.arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGxlWERSblRpaVlVNDJnNnI2NXdHOXhETnVxLzhIakNnOFBrRklUV1h0bGNY?=
 =?utf-8?B?UitQTjhmU1VGaUpyQUdLTDJSWW1FV3cvQm1KSXhRL01QbWFUTFpNZkpSbHBy?=
 =?utf-8?B?cktiRFA2MUs5QXlDbk1odEl4bldadS9mYVZLd01JV2VVTVNxZmhqbUZIR1Fz?=
 =?utf-8?B?QmZiVFA5RVlPS0MvQnhhSnNwblVSeXBsN0tGVlBNVzVaWDRTcTlQNnJTT0ZG?=
 =?utf-8?B?L3A1cFMyZG1zcEY0NUZiTi9HVEtGRGkways5OXQ0bFI3bXVJYm5mbkFZRlNP?=
 =?utf-8?B?UVREUi9FRVFKRlpVYkhuZ0pYZCtWQUt5Q0l0WG51Qmc2cWJOTGdBUi81YnJC?=
 =?utf-8?B?aVVWSmQwQnVVRWJ5Kyswc1ZNUlNHM1F2SEtjM1NSaGJkTmJBR083YnVuTS9C?=
 =?utf-8?B?a09SZVY1MnI5RHhxaXF4UmtoNjg5SCs0SWFkY0crek9nNHpXbnc2OGZleXZr?=
 =?utf-8?B?WnhQRGdwcGlZY0IzaUJjSDRkRVBZOVh2bFJaSFc5VnlkN1VtTlFQL3JqVkc1?=
 =?utf-8?B?RitLQ1VjREtzcVY3emlBUFpTQ2pHMHV5L2o0Z1hiWnE3YlR0aEVsZHRaU0Vk?=
 =?utf-8?B?bW9VN0hOeThEeE84NkIvTUExeXVYTkRVTkRyQ1FDYXFWNDdSeVUwcEROOXdi?=
 =?utf-8?B?QmpqcmUvQTRBUUxRcjh3MUFTWTl1VmlqN3RPbWZSM1VQM1pidGwvNUFYZFBt?=
 =?utf-8?B?bXBJY1lwa2EzaXZQNW9UMXo1b3Y2dVFTV1RTeThCZmxmUXpvRG9yVDBhY1JD?=
 =?utf-8?B?cWQ3WEtCV3U5MHFCWit1RGovbWNFUkNNM2F0UUFuQkdSWEVEYXAyVU55N3g3?=
 =?utf-8?B?YVBpRGZBNmF6QVRTN3JMUTNsblNka0tDQXg2cDZjMHNzVzB4aHhwclRmM0lD?=
 =?utf-8?B?NloreERGeVFnUVAxVlk5RTN3QzdZSElSa3p3TVE4WFp3M2pOMmhHZUtXdEJU?=
 =?utf-8?B?QWhJenY3dGM0Qm9ETkpDL3M1MGZzd1ZhN2l3bFAxeFRzem5KNEljNGlINFRm?=
 =?utf-8?B?WStOMFZWRGJmbTcwbjZVZW41RU5PR3lJZGd2V2RpMjUyUEl4WUtzcHNSai9v?=
 =?utf-8?B?N0JjZjJwWitqTndZaW1pMVpyUjBsNXFDeU9ldGNHY2tvQ0orYU1yRmJRMmNZ?=
 =?utf-8?B?dDh6YlU2dW1UZHlwTk5QeDIrZVJ6QzY2Z3JsY0NVMm1kUFlMeFNXeEhmQ25N?=
 =?utf-8?B?MVc1aW80VkZaYjU1Q0N1eUlCM0NQN08rTnVuY0RQcS84MW1SRmVvL0ZUUlBl?=
 =?utf-8?B?Ukl5Yzh5SkY0a1FHakhPVEJXTnhUTnBFWmsrenhXTm1BUjZ1K0hDaXcxUWht?=
 =?utf-8?B?S28yYzRHQS93YXQ0Rjd4cUlaVUtkVE1DTnBIQVlTemcrNktZS2RKcXdCUEQ4?=
 =?utf-8?B?S1U1ZE5kYkwxR2JicVVyakJjc2p6UHdRSDRkSWRBRzFic3VwZERNbE9GN3o2?=
 =?utf-8?B?ajRETUVjOEdTbjkvL1VOZXdQaTUvaUVraDAvVmJxZndCbWMxai9XcVN0UjMv?=
 =?utf-8?B?Q1gxaUl1b0txdHh5UWxqM015WEQyWmhtREttSHMrekVNWDFNRVI4MnNUS2oy?=
 =?utf-8?B?YnVrUnlkUDR5RFBMMGlLeWUwMzZwQkpxQzU2VXJvaDBablVwK3lLYUFIdVhF?=
 =?utf-8?B?V3M5WkZEUnY5clJvdEpCdStNNkRCeDQ2L1dkRFRVbm1xUDl6Q3ZDMHlwMThJ?=
 =?utf-8?B?WURLZGkrYWlURGE1NkdSczNPblNlVkJrMTRqeXJ1OHFoZDdBVnZUNFhJOWJw?=
 =?utf-8?B?ZWVlcnhYd3dGeUg2a3JJWHJMQzlTbDV5VWcweVhxMzdSYlI3Tk1VV1Q0QTQ1?=
 =?utf-8?B?bWhYVC9vei9hbWpaeXZjQUFvVXlna3J6djl2Ny8yYmFrMmgzSUJ2OHA0b2lP?=
 =?utf-8?B?SWtQU05DNTRCUVJhWnZaRzA4amNSRjVkTnpSY1pLM3hlVGdjZU10dkE0Um9Z?=
 =?utf-8?B?VUxqL0dKUk1OdGdSRGMrd2U5cThyY2JGRHlpMHh5WWRBdldQMTdzcFV6YjEv?=
 =?utf-8?B?aFZBcXhNeTF6b01qNnFPNzIxdzZWUTFsVHZNNUJiU04vWW1pQVY3WjNOZ21H?=
 =?utf-8?B?VXBBV2VCaGVra1JlZVg3aGNRdytMc1ZMZnZhQUN4U2MrK1d5VllSREp6akFD?=
 =?utf-8?B?MHNUTEN0VmNmYXZ6RDRRWWdNOHJ2S0J6a1RVNWphdlFzTnU2OXBKcnhwU2lH?=
 =?utf-8?B?YVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b6c411f-b015-44f7-1c67-08dc5a4de4bd
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 17:36:17.7391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wJQh3rDfV9CTxu1OPS9IAXw7M9L7WMIbNa/yRuObalRRGSyOjkKippPv3ybLDws+FP6P3XXpcaVmVoNcdioUMh3ZcMKID4NBafhGImPHemo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5112
X-OriginatorOrg: intel.com

Hi Dave,

On 4/11/2024 7:14 AM, Dave Martin wrote:
> On Mon, Apr 08, 2024 at 08:16:32PM -0700, Reinette Chatre wrote:
>> Hi James,
>>
>> On 3/21/2024 9:50 AM, James Morse wrote:
>>> rdtgroup_init() needs exporting so that arch code can call it once
>>> it lives in core code. As this is one of the few functions we export,
>>
>> Please do not impersonate code.
> 
> Noted.  Any objection to rewording this as follows?
> 
> "As this is one of the few functions exported from the resctrl common code, [...]"

Sounds good. Thank you.

Reinette