Received-SPF: pass (google.com: domain of linux-kernel+bounces-141412-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f919fdc9-e0e3-43ad-979e-024ae0cdd997@intel.com>
Date: Thu, 11 Apr 2024 10:37:27 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 11/31] x86/resctrl: Move monitor exit work to a restrl
 exit call
To: Dave Martin <Dave.Martin@arm.com>
CC: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Thomas
 Gleixner" <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "Borislav
 Petkov" <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>, Babu Moger
	<Babu.Moger@amd.com>, <shameerali.kolothum.thodi@huawei.com>, "D Scott
 Phillips OS" <scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-12-james.morse@arm.com>
 <92187846-374f-4b45-865e-543ba198b6b9@intel.com>
 <Zhfwe6Xhyec20LzC@e133380.arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <Zhfwe6Xhyec20LzC@e133380.arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3JNL0xLZ28zd3g1OUN2ZVBUcWNQb2R6OTBuajh3TVVXVEFMQklCU0VRQ2N2?=
 =?utf-8?B?eGJ6ZFJ0Z0sxb2RoV0UwcjBHbjBCZW1BUVlpTkR1cHQ0b3ZFazhva0FKeFlV?=
 =?utf-8?B?ZGpJZ0tRa0RqVW12U2cxR2RDZjhpYVhoZzVFMDF5eGEzVzJEd0pmKzcvckVG?=
 =?utf-8?B?RVNCQ0k5V2tUcG5yaDZCWVB4RzR5VnpYeUdwK3hVcGJZTFIzdS83S0Y1bDVm?=
 =?utf-8?B?QU84WGlCQUlrUzN6NGp1OC9zWXhsSWl0SmVQL2lsMHR5ZmtHNi85ZnBhR1Zj?=
 =?utf-8?B?b2Rwcm9VWldQMHVyR1U1ejJQSCs5ZTVFaExMdHJoMkVxQzRkMkhjbi9WSmpu?=
 =?utf-8?B?S0lDdDlzVDhibUxVWVQ3bWowYS81cW9ldDhXdXRjaStQdkg4cWlNSWszeG9L?=
 =?utf-8?B?ZCtUVEVkb0grRGQrSFlOTDFiNHBsZXlhV3E5SStBbjRzN1lIK2pCNFlCTTlQ?=
 =?utf-8?B?dUc2QTJGM0ZVNVJnbFU5aVJzc3Y4RzgyM2g3cHF5M3pqei9qbXE0ZHQ3TmJt?=
 =?utf-8?B?ZmRpVE5tTWd3aWJhRjFkOTdPWVg0dDdBVFlRN1ZieFNKOFRCVVVBMk1Db2Vi?=
 =?utf-8?B?WjVsU0o1OUlaMGxwR2Uyb1BSMzJTZ25sNnhndldndDRXS0EyajNZUHczd2Jm?=
 =?utf-8?B?OEtDSVAxaEJrWkd0c0psSG0vcjNMZ1ZRcXZUbDJUYzk4N0RKeGFlNW9NQ3pq?=
 =?utf-8?B?QjIwc3I0emd4dzh1NnQ2Wlc1MTB6Q1ZrdkpZT3d0MGZlVlpoRVRNMm9pOXNv?=
 =?utf-8?B?UXQ2aUV3aUgwYnRkdi9paWRhN0Voc3NROHdQc2FsVkJmZldxa0JPOHNLN3do?=
 =?utf-8?B?SU5CeUFNUVIyNXNzRFRzME1iSlpTVzNYL2J4UG9FcHdPVWFjNFYya2loZEV5?=
 =?utf-8?B?UHgwNWtwWkRjbllGUGpQR2ZqQm1SdkswSkNpOTFvaSsyWXowVDRtVjc0ejBE?=
 =?utf-8?B?Z0RlQkZ5ZmIrcittVUpkYSt1LzhLRzlrVFNCTUtrUlRTMDNDRTRjRjZKU1NL?=
 =?utf-8?B?TmZ4eXFSQTRRRTdmZDZUeVR0ZGg1WlpaZkI2OHpFbW9vRVZIZlg3c1lmV3di?=
 =?utf-8?B?UUgvL3plYTVvY1NuQVRXcHBydnN6dnFNWlFpTC9HUFJrWnZiaDN2TkJmOVgx?=
 =?utf-8?B?NjVLQmxuaDEvSE8rdGRKN2FSQlhVd0xpNWhVblcrOXRCY3dhT0theXRoVXMz?=
 =?utf-8?B?aHhrcVp2SURUMnE1N3Y1MjB4TkUvVlc4djFCc0pxREJWUVlLUEczZVRXTkp6?=
 =?utf-8?B?VFpNWitNc2FtN1N1dGFwVi8vbEtVY1ZuSGViUjlldkJuT0dkQmc0Y010UEpx?=
 =?utf-8?B?M0ZPOGpRczY5SU1BNnFuM2RRYnp5YW9kK3kxN3VKTldMekV4SEtnMml3Y01l?=
 =?utf-8?B?TmVKVEdwWUwrNHdrMXpBd0xpbVZXcnlJNTJvR3ZwSnRIRlpuOElRd2xwZENz?=
 =?utf-8?B?QlV2bW9FclpzNGNpM3lDR1J5WVh1Qm9PancrdUNid0lIOEJ5K0tKSzZqcnN5?=
 =?utf-8?B?SjUyNUgxa0k2MGRrNkxSTGxhaWlOWWNmaTdxUDJmY29SRjFSZ1ZuYXYzRUpa?=
 =?utf-8?B?eVBwZmd0bHZjU2FoUjNyOEFsVkpueURyUm1HNXVIdDRqY1RzVWlURmtza1lL?=
 =?utf-8?B?NCtKVXJ6a01nbmtEeEJsREF3RHlSYzRIY01NQ2JSREZyNkwzcUlPNTNvcGh1?=
 =?utf-8?B?aDVXVHc0OHh6RkxtcE1XbStiMVdpWmpaQjRELzVTOUxWNlQxOGZRbHRFUEYx?=
 =?utf-8?B?YlNwZ29aZEJBQXJTM0dZcDl1NVRuVTQxTVE4NVlWSWlCMURtbmdhVkI2WmF6?=
 =?utf-8?B?alhhYStQazBmL090ZG1QWEhWVzM3dWpUNDVlcWFnaE52ZUtpQy9qZ3Rha0F6?=
 =?utf-8?B?TUVKeDYyL0E3bVc3QlpCUmtsdUhTOFUxenp4SXppVHdWajBLN3BZWldOSDYv?=
 =?utf-8?B?MlBDWERpQUs1M2hoUTZBM3JuNW40OWVCYmx5YlVUVnBiSHJPakw5ejI3MXBD?=
 =?utf-8?B?N3Ntc1FEVmE4QmhDTVFlSDNpZExLK1Q4Tzl4eG45Y21NS01mWTdDc2t6SDhv?=
 =?utf-8?B?ZERLaERHS2drQTFhaVpWRXFFdnZXbWhvNkZXZjUzYnFjcjBzZkFQdFVsUFFo?=
 =?utf-8?B?V1R1T0JJQ255RlFIY3laUVluZ2IvbDg3aDIzdHNaMmduc0lRQ0lRUjhsc3lp?=
 =?utf-8?B?Wmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b1dbda8-959a-4812-e1c1-08dc5a4e0f8d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 17:37:29.5925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UJDg/wf+oelooiuzD2xewMYnJQvliEpzB2rsSbh4Hdf7z5iKb0JIzv9fAZJjKJRW+icgB2+jzPiTTCnZwVFg6jYCIlvKW/CAAArstqURxPk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5225
X-OriginatorOrg: intel.com

Hi Dave,

On 4/11/2024 7:15 AM, Dave Martin wrote:
> On Mon, Apr 08, 2024 at 08:19:00PM -0700, Reinette Chatre wrote:
>> On 3/21/2024 9:50 AM, James Morse wrote:
>>> rdt_put_mon_l3_config() is called via the architecture's
>>> resctrl_arch_exit() call, and appears to free the rmid_ptrs[]
>>> and closid_num_dirty_rmid[] arrays. In reality this code is marked
>>> __exit, and is removed by the linker as resctl can't be built
>>
>> resctl -> resctrl
> 
> Noted, thanks (also, there is "restrl" in the subject line.)

Thank you for catching that.

> 
>>
>>> as a module.
>>>
>>> MPAM can make use of this code from its error interrupt handler,
>>> a later patch drops all the __init/__exit annotations.
>>
>> Reminder:
>> https://lore.kernel.org/lkml/85f8756a-23a0-444e-b37d-a7817b600f46@intel.com/
> 
> The "Drop __init/__exit on assorted symbols" patch speaks for itself,
> I guess. I think it's probably sufficient for now to comfirm that this
> patch is deliberately not changing the annotations for now.
> 
> Does the following work?
> 
> --8<--
> 
> Since there is no immediate need to change them, leave the __exit
> annotations as-is.  This will need to be revisited as and when there is
> a need to call these functions other than at __exit time.
> 
> -->8--

Sounds good. I find a big focus on the __init/__exit annotations
distracting. As I understand this has nothing to do with the goal of
this patch, which is to move code from architecture side to filesystem side. 

Reinette