Received-SPF: pass (google.com: domain of linux-kernel+bounces-141413-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <d269b5d2-bd6d-44b2-8d99-0e0a2790bf50@intel.com>
Date: Thu, 11 Apr 2024 10:38:20 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 12/31] x86/resctrl: Move max_{name,data}_width into
 resctrl code
To: Dave Martin <Dave.Martin@arm.com>
CC: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Thomas
 Gleixner" <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "Borislav
 Petkov" <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>, Babu Moger
	<Babu.Moger@amd.com>, <shameerali.kolothum.thodi@huawei.com>, "D Scott
 Phillips OS" <scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-13-james.morse@arm.com>
 <fc4ee516-54b7-47cb-b881-00ce10d311a9@intel.com>
 <ZhfwjBJPeTvO04BL@e133380.arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ZhfwjBJPeTvO04BL@e133380.arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzRVN1ltRHdXQzA5WXFCY291QytnSHNtZnhnQ2Q1TklaOVNtN2Z1Z0VuWG9W?=
 =?utf-8?B?a01lak5sRmhlZXNPWmlJTFZYMmREQnRieTFsVjd5ZXh0WXlpN3UyVUExOXRq?=
 =?utf-8?B?UzZxdWZTMkppYUZVeHFHdU5Mbm8zMHJaL1Y5WnYySjFCTzY3R3lTcDYxUjlq?=
 =?utf-8?B?cjIvcktLd21sT09GRHZMRXZSV0N2ZkluMXhjTlNoaFB5RkFoS0dCaFNEODNK?=
 =?utf-8?B?L2w1V2dRL3IwUWRWKzBBWTlrQnMvQ2hnZ1haNVl6b0RyUlM5TE51cktUMGk4?=
 =?utf-8?B?aENOaGlVU1NtMGtRcFg5bEFLUUUvMnFHKy9ybGdFdkpoZUJYTEg4SU9nWjF0?=
 =?utf-8?B?eVJFc3dnTnNLRUp6V2Z5NGJrWjBueXpGMDlJc1VaeURYOTVoV2NEMEF6MTlY?=
 =?utf-8?B?dkJnYWFDOTZUZ1h1bkZjdFMrZU0wNy9wOFlTNTR4b1JXZmlFOEtjdUxsQWY4?=
 =?utf-8?B?Q29rTmJhRUM2a3lUMHFRaEp6allqdEtuNnlTeDI5Z0MwaVY3YWxjR3NNaGJ0?=
 =?utf-8?B?K01iMEU1azV3MnFTSzNENHB6ZDJ0RXZwd3FrWjY5bXozR1NWV1h0dDJTTnl1?=
 =?utf-8?B?QWhWMW5OeTZqeHhkNE9IYlFjdTFGWXdwU2VRQTFscDN2QlRGVnhsUUovdVRu?=
 =?utf-8?B?Qk1hUmt0bDFXVzdqWXRpRXFKNnpSOGFWc0ZJeFZHczczZU16SUkyN2tnR1p3?=
 =?utf-8?B?RExQNjJyeXZuOFpxL0ovTEU0b2k5N2N2ZjZOYWp4L29SOG5uQWhMemJqSGlT?=
 =?utf-8?B?cExnZEtmUnJvTEx5S2lpVnBkM3k3K0JrYlZYUjNUbHNmUGNIZlpqUmdQNHRP?=
 =?utf-8?B?V0VZUi9hOHFQRjhxMXdnWnkwTTlWV1gvVFlLdUdTUStyMVpxZVJRSlVlekVx?=
 =?utf-8?B?ZE14YkNtZ1dTR2FkeWdRbHRwdGxqTWNuRXQ2Z1pRTDE2SHhwaWx3N2crYzNY?=
 =?utf-8?B?SU8xanAvTDVxQ0lsUkNVaThad2lQTDZaNTFmaE5DNmg4V3NWZGFzZk9iSmpx?=
 =?utf-8?B?Y1hGTWswdnAxSmpLYjV3bUR0NGR4SklHOXNac1oyQWh1R0IwYkpTMHg1UnZE?=
 =?utf-8?B?NWhPcTlKYTZWRE5BTEVlc3VoNkpEdU55amI0Zmo2LzlPUGduZjNzWkhzc0xM?=
 =?utf-8?B?L3hVV2MxMWxwcmVTL0VTaXJCUW1ISGMxUzZxVGQxQStNUDNBWU42Y0dFM2pi?=
 =?utf-8?B?SDhkYTNFSlpRUGdGTTlETTdYSTFORDJoVldtU0RNd3hQTURnRlVyQm1WSzM5?=
 =?utf-8?B?MXU0R21yRXM1RUpiS0tweFNocUVMcEpreDdzM0NtQit6dC8wbzdZRTh5NGVL?=
 =?utf-8?B?NFUwZUlQNEptT0ZBczBVV0tuaTZza2NEdkF6Q05iOWM5Q2NyNGxvK3Z5QUpS?=
 =?utf-8?B?bnp0YzdPVXd6S0ZKSTVZQ0tJVlgwYThESnZmb1Ftdk9kMFVjQUFkMzR4ZjVX?=
 =?utf-8?B?MXJTdndZa1JrOW5sWWZrOG1FOTdZZTYyOUNMR09FUmZQWExsTXVWYjk0NGly?=
 =?utf-8?B?Rk5sVU1zY2F2QkxtbTRma0pSMkxIRUhIamJvQUpucjVxOGNMaThGbUpLa1Ri?=
 =?utf-8?B?VFFuT3FlRGIrVU5CS2YwL29kWDZPVlQwd2JzSnRoa0V5eFowcHY4Wm1tS2lD?=
 =?utf-8?B?S01UdmZSUkhEenVUMzNpU1FQWFhkZHpiRjdlMnBhM3JpWW1OKzhZTnMraWtT?=
 =?utf-8?B?cDBPWTA0MUFkMXBNYjN5RlBVZHRDSXp0L0xqeTBwUkZrUzdnbS9Zc2I3V1du?=
 =?utf-8?B?ekllVEJsTEFoRDAwdHNZWHZudDNYcXNQcjZwdEQ4TFZBQlo4RFJPR0pmT1RV?=
 =?utf-8?B?RFdDTGJWR1dEc3ZiMk1VcFd0SGo1NGUyc0dOcktLY0VEUHA3dCtjSjFwK3lP?=
 =?utf-8?B?UVZmZkFmUks3b1Yrc1YwUVN6NURvaXJDTUl3cXRFb1JBcy9JRS94bmZwVnl2?=
 =?utf-8?B?aDVzQ3p5RFczTWZWUzZ0Wkt3b2dHVUNzMzNXdUkrdzdsdG1zZm5aZExPM0pL?=
 =?utf-8?B?VDg1dG9hYjdZY0hBdzNlUXV3VjNOTjRkS1NGSUoyRkdOY3BWdDFnTDRqb0M3?=
 =?utf-8?B?aFhGRko4UlR5UGRPZ1dOeVBPdzVmbTlHdjJzMXY0QldZWDBSdXNUbXRtMEdG?=
 =?utf-8?B?MU8reFJyeXBMOWE1R3BvMWhCZ0tlT0xOaVlJcm1ocjM3aC9MaUlXTDlqeGZl?=
 =?utf-8?B?d3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d618967a-f612-4ffc-2d4a-08dc5a4e2f2b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 17:38:22.6447
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CdJllpic3iOnZsSAOywt6KmlJhOI5bzTl1tFLTCuLuTQ/tAgdO85Ogd9eSZ/mjlBLGPCAlS9YDg8AdHMRB37W2Oqac0/5VpILRp+l/Bq4UY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5225
X-OriginatorOrg: intel.com

Hi Dave,

On 4/11/2024 7:15 AM, Dave Martin wrote:
> On Mon, Apr 08, 2024 at 08:19:15PM -0700, Reinette Chatre wrote:
>> Hi James,
>>
>> On 3/21/2024 9:50 AM, James Morse wrote:
>>> @@ -2595,6 +2601,12 @@ static int schemata_list_add(struct rdt_resource *r, enum resctrl_conf_type type
>>>  	if (cl > max_name_width)
>>>  		max_name_width = cl;
>>>  
>>> +	/*
>>> +	 * Choose a width for the resource data based on the resource that has
>>> +	 * widest name and cbm.
>>
>> Please check series to ensure upper case is used for acronyms.
> 
> [...]
> 
>> Reinette
> 
> This patch is just moving existing code around AFAICT.  See:
> commit de016df88f23 ("x86/intel_rdt: Update schemata read to show data in tabular format")
> 
> Since no new usage of any term is being introduced here, can it be
> left as-is?
> 
> There seem to be other uses of "cbm" with this sense in the resctrl
> code already.

I am not asking to change all existing usages of these terms but in
any new changes, please use upper case for acronyms.

Reinette