Received-SPF: pass (google.com: domain of linux-kernel+bounces-141422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <0baf690b-4ed4-4dad-9f50-e5df93d599fd@intel.com>
Date: Thu, 11 Apr 2024 10:43:55 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 30/31] x86/resctrl: Move the filesystem bits to headers
 visible to fs/resctrl
To: Dave Martin <Dave.Martin@arm.com>
CC: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Thomas
 Gleixner" <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "Borislav
 Petkov" <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>, Babu Moger
	<Babu.Moger@amd.com>, <shameerali.kolothum.thodi@huawei.com>, "D Scott
 Phillips OS" <scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-31-james.morse@arm.com>
 <8f4a05d5-2040-4cf2-8c05-a190c25d64db@intel.com>
 <ZhfznA2Sp3KFdjrA@e133380.arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ZhfznA2Sp3KFdjrA@e133380.arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXRxUFlwNHZkUFZMN3ZhRzIrUklQWFI5MER2K0Mya01vL3FWd2IvMExrOElE?=
 =?utf-8?B?Z2lWbHJQTmh3V2VnMzVjcGVZZjFqMnNTTlc3YlNMRWtUcmNORWZEd2t1ZEJM?=
 =?utf-8?B?eG9FNGpmN2JUZkxXU0hoOExQY2Jtek9nY3RZWFRxdkFJTEIrR1d0UWpOell4?=
 =?utf-8?B?bFdRYnY2MWpGenEwRkN0cUVqM0lUWm1vOGxSVS9GazF4ZnNHZ2FMTjdlWThY?=
 =?utf-8?B?QWs0eURRdmR3aERjWEVodndiSEh2WW1DOUF2OVFKa1NMNExuaGNXSWNIRlgw?=
 =?utf-8?B?WTl3L2xReWkzeWtVUjZUVWlzODhwM3pXT1FQeWU4UmlodHhHNkxLNVN5VnUw?=
 =?utf-8?B?UGtJM05TL1c5UlhMVDdNWG5lWHBQd3Y3RmlCR25zb3M4MDhBbG95c2p5VjIz?=
 =?utf-8?B?ZUJWaW10YnlidkVtYzFNa1F1Y04yK0ZVWW0rNkdXcHhkSWxsdHRHTTRuUk1D?=
 =?utf-8?B?YUxMZGFHL3RsMzM0TUdFNm9vVU1ybko1V1ptNzQvSHVVY2xEUzNTK2p5MEtn?=
 =?utf-8?B?b1l0Wnpaa0JoYjB2Ylpmb1hYUW5lMzQvMVZ6KzRCazlXckJiVElWOElZSE9E?=
 =?utf-8?B?MG5FWGNBVE9QK2pSeXhMZXd6eGU4SmhKZkZiOHdUUG9DZHJFOUdDbjNRYU1i?=
 =?utf-8?B?ZW1zNW5RMy84TjRKK2NXQUNaeHVNWlo1Ty9jUEZjbXA0U0t5NGFTSVIrdnZ2?=
 =?utf-8?B?ZkVTVEpaSE50ZDJ6NW1UbDdlYlJGSWRtRkhKcDYyTmR1OXZZV3NMaTR3WStK?=
 =?utf-8?B?N2k0MThsNG05MnB0SVB4N2d4dUt1Q2dZTkphVTY5Ym5DcVBDQU9xOVNVNEdp?=
 =?utf-8?B?RUZsQzlPQkJyYWh2cU5rVGlhM2lJZExxTVVRWXVMcktCcEc0T0J0ck11QlFL?=
 =?utf-8?B?RmtTUmc1RkRPdUZtWGVCTVdjY2lxWHViTHIvUTZ2dGpxZ2RvVVV1ZVhtK0VT?=
 =?utf-8?B?U0Y3QUw3aUJLbnR1VGFFNEZ5T2FRaGNWdXQ0T0RPT1c2SmZmVEY3aVRHTWpT?=
 =?utf-8?B?dTNUV2ZucXFTY3JDNVVPcjFiZGVqZWl3YWRJdkxkRlo1cmk3em5ZcXZ5SmFa?=
 =?utf-8?B?RWNFZVNJMkJlQk1JSU83TS92M0VrTUtSeU4yNm53WHhKbzZqdEgvd1RYRUs5?=
 =?utf-8?B?QmZTaUd4eTg1cFI0eG9rajEvaitHQXdVdHNTbVFYZUc2Q1QxbGkzaU9idFFO?=
 =?utf-8?B?U1FZR3puSVJabERYWDNZMnAwZXcxSUkwTzUxQm9GSzdlRnNJZ1djRFRxSlhD?=
 =?utf-8?B?VEJ0bGNwcXQyVXJMM1JHTFBkVlhhcytLWU5Rekh4aTYxTmxzM1crRktsYmNZ?=
 =?utf-8?B?L3ZhemR0eEo5STU2TjExdVV0b2x0ZGxCakJEdDRTOGd1UHpoTGlKS2FBeGpD?=
 =?utf-8?B?WkxraVRadDFnc0RMWmtvM25FdDJWVFRIV1NZSi8yd2lTRDlHLzdTZXh3QVVG?=
 =?utf-8?B?d3d4dUhEaUoyZ1krbnlLa0trOUpOS1J4eFFnYktHaFY0VkZJRnRkd3F2eTZD?=
 =?utf-8?B?dmJJOGcwZ213dkR1cTFlbitER2RZSDFRV0JWaXFCV3hMVlp2U0h6U1FCaG9o?=
 =?utf-8?B?SmcxdVluNm1GTEdXM2xpSWRBSGg4anRZeW9RZHlITHlIVFN0NVBsaE9Qa3Z0?=
 =?utf-8?B?a21hdGwvTkZCY2V6RHFseFdaL2dnK09peU9CUFlKNkU2aTRnMU1uVUQyM3pE?=
 =?utf-8?B?Rkx5SXRyNEhYQlNrTjU0alhLTS9RazhrQ1A3dVltVjlId29vQ1lFbDZOM0Qw?=
 =?utf-8?B?M1ZYVlNBYTFISE5GUEFUNU8reisrZWxsYkxGOCt6OWtIWkY4Q015TnpqbUFO?=
 =?utf-8?B?ZEloK0YvcXAxcTJDSDJkRmJJYW9zWU9vOG1hQnBaYkVNUGlEZE9LUWVxc2xH?=
 =?utf-8?B?Y0gvZ3hQWWhWa1NEcVJ4YlV3ZTBCV1JEWGJVOGJpVkdtNXVIL29GejNUTjBj?=
 =?utf-8?B?N0txaGNlT3ZBUnlRYnUxQzEvNjJBMzJIN1E1UVJnc3VTRTRxU29qQmFwREpK?=
 =?utf-8?B?QlNMUE41ZFdzVHBpMEVJVld5cnN1QTJ4SmZkOEY5cTF5enRsL0RqRkp1VmE3?=
 =?utf-8?B?YWwydTVJUjV1T2RZNXpzVm1qaWtyMkNaRDdXZTdVZ1R0L3ArOCtScERlbUlk?=
 =?utf-8?B?WWRkVzNlblozM1REOGt0Tlo3Q3JXQmZLRVJMNWZyNWJrV0x5dDFZMGVhNUYv?=
 =?utf-8?B?dGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c8378be-2690-46af-9316-08dc5a4ef6e5
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 17:43:57.7272
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vhmJpZIXi+yeNPfkUg9zu25QTfzF5/Gx1UG7fdqM+3tOLtyzkuBgr0US5S6Qi9yCLh2usH9F6pdzv1FK/Z2jmtEhzmGT8w2s/K8rK9wIre0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4721
X-OriginatorOrg: intel.com

Hi Dave,

On 4/11/2024 7:28 AM, Dave Martin wrote:
> On Mon, Apr 08, 2024 at 08:42:00PM -0700, Reinette Chatre wrote:
>> Hi James,
>>
>> On 3/21/2024 9:51 AM, James Morse wrote:
>> ..
>>> diff --git a/include/linux/resctrl_types.h b/include/linux/resctrl_types.h
>>> index 4788bd95dac6..fe0b10b589c0 100644
>>> --- a/include/linux/resctrl_types.h
>>> +++ b/include/linux/resctrl_types.h
>>> @@ -7,6 +7,36 @@
>>>  #ifndef __LINUX_RESCTRL_TYPES_H
>>>  #define __LINUX_RESCTRL_TYPES_H
>>>  
>>> +#define CQM_LIMBOCHECK_INTERVAL	1000
>>> +
>>> +#define MBM_CNTR_WIDTH_BASE		24
>>> +#define MBM_OVERFLOW_INTERVAL		1000
>>> +#define MAX_MBA_BW			100u
>>> +#define MBA_IS_LINEAR			0x4
>>> +
>>> +/* rdtgroup.flags */
>>> +#define	RDT_DELETED		1
>>> +
>>> +/* rftype.flags */
>>> +#define RFTYPE_FLAGS_CPUS_LIST	1
>>> +
>>> +/*
>>> + * Define the file type flags for base and info directories.
>>> + */
>>> +#define RFTYPE_INFO			BIT(0)
>>> +#define RFTYPE_BASE			BIT(1)
>>> +#define RFTYPE_CTRL			BIT(4)
>>> +#define RFTYPE_MON			BIT(5)
>>> +#define RFTYPE_TOP			BIT(6)
>>> +#define RFTYPE_RES_CACHE		BIT(8)
>>> +#define RFTYPE_RES_MB			BIT(9)
>>> +#define RFTYPE_DEBUG			BIT(10)
>>> +#define RFTYPE_CTRL_INFO		(RFTYPE_INFO | RFTYPE_CTRL)
>>> +#define RFTYPE_MON_INFO			(RFTYPE_INFO | RFTYPE_MON)
>>> +#define RFTYPE_TOP_INFO			(RFTYPE_INFO | RFTYPE_TOP)
>>> +#define RFTYPE_CTRL_BASE		(RFTYPE_BASE | RFTYPE_CTRL)
>>> +#define RFTYPE_MON_BASE			(RFTYPE_BASE | RFTYPE_MON)
>>> +
>>>  /* Reads to Local DRAM Memory */
>>>  #define READS_TO_LOCAL_MEM		BIT(0)
>>>  
>>
>> Not all these new seem to belong in this file. Could you please confirm?
>>
>> For example:
>> Earlier in series it was mentioned that struct rdtgroup is private to the
>> fs so having RDT_DELETED is unexpected as it implies access to struct rdtgroup.
>>
>> CQM_LIMBOCHECK_INTERVAL seems private to the fs code, so too
>> RFTYPE_FLAGS_CPUS_LIST.
>>
>> Reinette
>>
> 
> I'll flag this for James to review.
> 
> These have to be moved out of the x86 private headers, but you're right
> that some of them seem logically private to the resctrl core.
> 
> I guess some of these could move to fs/resctrl/internal.h?

It looks to me that way.

> 
> OTOH, might it be preferable to keep all the flag definitions for a
> given member together for ease of maintenance, even if some are for
> resctrl internal use only?

Indeed, those RFTYPE flags really seem to be fs code but I agree that
architectures' use of RFTYPE_RES_CACHE and RFTYPE_RES_MB does make this
complicated and having these in a central place is reasonable to me.

Reinette