Received-SPF: pass (google.com: domain of linux-kernel+bounces-141320-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 11 Apr 2024 12:28:29 -0400
From: Parker Newman <parker@finest.io>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
 linux-pci@vger.kernel.org, Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH 2/2] serial: exar: adding CTI PCI/PCIe serial port
 support to 8250_exar
Message-ID: <20240411122829.2125e13e@SWDEV2.connecttech.local>
In-Reply-To: <2024041147-flogging-straining-910c@gregkh>
References: <cover.1712846025.git.pnewman@connecttech.com>
	<9ffdef053f455c87f705dff169346bc10d307787.1712846026.git.pnewman@connecttech.com>
	<2024041147-flogging-straining-910c@gregkh>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:otLAxziXAP4=;dtfYW5QSXfSoPkQF1mBXck0KEFf
 nZ1TK7n9PmXBd/62uXFrr1b4RyOMwXjsT8FFsHavmQxCNbGaxI/bPrq1M0KBShBq6tqJJ3GNS
 DEznB+Q2jKgs/qukQpVcKPvF4W2cqetZcg/SWCUTf63NIVZNxwxHC2itR+Yaajd9PdnePECY9
 l/nNE00E20hV7v/9nt47JBqhRbhtqzK/Mzy/hhamiHEWnCr9TSQcOEs5JBVE75inzdund4IPZ
 Ax2w8ox6en6saJpRxu4yArxF1BGmqRPR15YamOcBNd7ELXy1BXoJuKRDEm1mJi+hNvcV/T9is
 a0n11anhx75xpDyigd7QP0trsBaUhWGb8tfJH/jDTFaA28EdX1OUYg/2Y7LDRUDOL+2rS28HI
 k7myxkSkJi48a9lZrmsAveH+gVC2BrN8gXZoBeC65NNQZzOSsKlnGyq/8dx9R410DuLEQ+S1w
 Zvjm70C0z3ng3gaVzJe9CQSYutWFB91740uYMkBI3Nefwln9VKUuOqSqu+IpeNYP/Pp0QBU20
 yCHJPufTWElx0+CzWUhv6aUPjM1v1Ex/pOxFZvMCL9vGP7wSkvIaSOWX7+Vr+3FIm1euDAJay
 jc14ChBoRdhgBit2QI/eFm3T3aI63M3WJb0SnU1wzb3Ny3QgRVw8C/IUBNKDF4PaIe0hbxTGv
 UJIvFRJmFXn2WtAP/dBlUeiSx+Sw2RAi6dfdfWCw07SBzSomXu+59d+O+cGwscaVyj+V2vUA4
 BIHQhR9ON0mx8ZMxcUTFrtPTHyZ4YQ70Tjc9IDQzevu0wGuR7ibhwY=

On Thu, 11 Apr 2024 17:55:54 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Thu, Apr 11, 2024 at 11:29:27AM -0400, parker@finest.io wrote:
> > From: Parker Newman <pnewman@connecttech.com>
> >
> > This patch adds support for most of Connect Tech's (CTI) PCI/PCIe
> > serial cards to the 8250_exar driver.
> >
> > Major changes:
> >  - Added (optional) board_setup function called once during probe
> >  - Added exar_get_nr_ports function
> >  - Removed old Connect Tech setup functions
> >  - Added new UART family based CTI setup functions
> >  - Added PCI IDs entries for Exar XR17V25x and CTI FPGA based cards
> >  - Added MPIO functions for configuring/setting a single MPIO
> >  - Added support for reading from the Exar EEPROM
>
> When you need to list the different things you did in a single patch,
> that's a huge hint it needs to be broken up into smaller, easier to
> review, pieces.
>
> >
> > Signed-off-by: Parker Newman <pnewman@connecttech.com>
> > ---
> >  drivers/tty/serial/8250/8250_exar.c | 1089 +++++++++++++++++++++++++-=
-
> >  1 file changed, 1019 insertions(+), 70 deletions(-)
>
> Reviewing 1000 lines of changes at once that does different things,
> isn't easy.  Please break this up into smaller,
> one-logical-step-at-a-time patches.
>
> thanks,
>
> greg k-h

I will try to split it up better and submit a v2.

Thank you,
- Parker