Received-SPF: pass (google.com: domain of linux-kernel+bounces-141319-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 11 Apr 2024 09:27:39 -0700
From: Alison Schofield <alison.schofield@intel.com>
To: Lukas Bulwahn <lbulwahn@redhat.com>
Cc: Ben Cheatham <Benjamin.Cheatham@amd.com>,
	Dan Williams <dan.j.williams@intel.com>, linux-cxl@vger.kernel.org,
	linux-acpi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Lukas Bulwahn <lukas.bulwahn@redhat.com>
Subject: Re: [PATCH] MAINTAINERS: repair file entry in COMPUTE EXPRESS LINK
Message-ID: <ZhgPe5mDt2ocXovz@aschofie-mobl2>
References: <20240411062443.47372-1-lukas.bulwahn@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240411062443.47372-1-lukas.bulwahn@redhat.com>

On Thu, Apr 11, 2024 at 08:24:43AM +0200, Lukas Bulwahn wrote:
> Commit 12fb28ea6b1c ("EINJ: Add CXL error type support") adds the header
> file include/linux/einj-cxl.h, but then adds a file entry with cxl-einj.h
> (note the swapping of words) to the COMPUTE EXPRESS LINK (CXL) section.
> 
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
> 
> Repair the file entry in COMPUTE EXPRESS LINK (CXL).

How about stating the impact, something like:

get_maintainer.pl can only return commit_signer history for file
include/linux/einj-cxl.h because the entry in MAINTAINERS is wrong.
Correct the entry so that the full MAINTAINER list is returned.

It is interesting how you found it and I'm not suggesting deleting
that.

Thanks,
Alison


> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index edf6176a5530..03204db05027 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5415,7 +5415,7 @@ M:	Dan Williams <dan.j.williams@intel.com>
>  L:	linux-cxl@vger.kernel.org
>  S:	Maintained
>  F:	drivers/cxl/
> -F:	include/linux/cxl-einj.h
> +F:	include/linux/einj-cxl.h
>  F:	include/linux/cxl-event.h
>  F:	include/uapi/linux/cxl_mem.h
>  F:	tools/testing/cxl/
> -- 
> 2.44.0
> 
>