Received-SPF: pass (google.com: domain of linux-kernel+bounces-141534-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 11 Apr 2024 21:25:35 +0200
From: Nicolas Schier <nicolas@fjasle.eu>
To: "Daniel Walker (danielwa)" <danielwa@cisco.com>
Cc: Nicolas Schier <n.schier@avm.de>,
 "Valerii Chernous -X (vchernou - GLOBALLOGIC INC at Cisco)"
 <vchernou@cisco.com>, Masahiro Yamada <masahiroy@kernel.org>,
 Nathan Chancellor <nathan@kernel.org>,
 "xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
 Jonathan Corbet <corbet@lwn.net>,
 "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
 "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] Add MO(mod objs) variable to process ext modules with
 subdirs
Message-ID: <Zhg5L2xO_lT4lLwp@fjasle.eu>
References: <20240405165610.1537698-1-vchernou@cisco.com>
 <ZhfLrGrED-ls6i5V@buildd.core.avm.de> <ZhgdjpE+yl3IYSzl@goliath>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="kz7PYebefrXoraDu"
Content-Disposition: inline
In-Reply-To: <ZhgdjpE+yl3IYSzl@goliath>
Feedback-ID: 1174286m:1174286a9YXZ7r:1174286sdeYb5ezlG


--kz7PYebefrXoraDu
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 11, 2024 at 05:27:42PM +0000 Daniel Walker (danielwa) wrote:
> On Thu, Apr 11, 2024 at 01:38:20PM +0200, Nicolas Schier wrote:
> > Hi Valerii,
> >=20
> > thanks for your patch.  I know several non-upstream kernel developers
> > that would like to see support for out-of-source builds of external
> > kmods (and we developed several work-arounds at AVM as well); but please
> > be aware that patches that don't fix or enhance the in-tree kernel/kmod
> > build but only add feature for out-of-tree stuff, are rarely accepted.

"out-of-tree stuff" was meant to be "out-of-tree kernel modules".  "Rarely"=
 was
chosen in explicit contrast to "never", but to hint on my personal expectat=
ion
regarding the probability of acceptance.

> If that were true we would not have driver/uio/ for example. It seems like
> Cisco and NVM should work together produce a solution.
>=20
> You could run into this issue even with entirely in tree modules. For exa=
mple,
> we may have a v6.6 kernel but we need some modules from v5.15 for some in=
compatibility
> reason in v6.6. Then we may build the v5.15 modules as out of tree modules
> against the v6.6 kernel.

If your in-tree module in question does compile and run properly in v5.15 a=
nd
in v6.6: why don't you just compile it in-tree in v6.6?  Which driver/modul=
e do
you refer to?

> You also have just normal developers making kernel modules which always s=
tart as
> out of tree modules before they are upstreamed. Those modules could be an=
y level
> of complexity.

I do not agree, but there is no need to convince me as I am not in the posi=
tion
to decide between acceptance or denial.  I just thought it might be fair to
warn that I do not expect acceptance.

Kind regards,
Nicolas


> I don't think it make sense to view this as strictly enhancing large of t=
he tree
> modules with no upstream potential.
>=20
> Daniel

--=20
epost|xmpp: nicolas@fjasle.eu          irc://oftc.net/nsc
=E2=86=B3 gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
     -- frykten for herren er opphav til kunnskap --

--kz7PYebefrXoraDu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEh0E3p4c3JKeBvsLGB1IKcBYmEmkFAmYYOSYACgkQB1IKcBYm
EmkWABAAuB4G3SHinwG4MH0JXhY/Z9qL2SQzLcu+frNSpobXWQIDgnEDwsdBbMWp
UsC26wZjjBJuBv42JYEeP79EawDqJKImFg75gmiXnuVNt1/foqsKJRQjRMmc5YeO
hmCX9uOJcKC6C66GtpppRlTZidh4I7svhLnvGUgz10Y/k1sx0gyl+PfqW5okzXNO
mreXIep3YrlHUg3vMnLmyvtj6NKbC+nZFeF88TYHFG3HURWENw1jy9tJg8VpyqCv
V8yWtuxmnStiwGjX40PDdiTcNHbBwz0ULkx/N98aw1mCJT7pZSx59x4kRlSTgCjb
7E98vL1ArfZEIbK4zb+BVNJp8aqjaEGSHrhH/pWMt+9lhKl5thuHjjefp0tw2nHL
gPNdGcTxDsSiW29hkCPk8T5Wo+PO7IAFiDAIAETdi5HUR/uCylrsb2iIApU/jD85
mELn6UDNxjHzk2db1uBNARAuLRkmElIL1Q48DNOhpitPWnwipz7GMIl4mOiz4UFQ
GVbOrtcYeIDx6Br860aMJic/4kCI2a9SMEoOEDWaN37jpoPv1RUGd4FbGGRoZ87Q
FjcMZWy7X4IdVqB39BqzQll1YnBMyQ2WGJ1V8Euiv8DuL7INElouhPf1vrMNGDCl
pfXAKOPa0ZK8yykV6KHco3LeJFY2D0qERlhHd3U5rhx8YKGZkr0=
=5fm7
-----END PGP SIGNATURE-----

--kz7PYebefrXoraDu--