Received-SPF: pass (google.com: domain of linux-kernel+bounces-141475-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240405190419.74162-1-krzk@kernel.org> <20240405190419.74162-5-krzk@kernel.org>
In-Reply-To: <20240405190419.74162-5-krzk@kernel.org>
From: Rob Herring <robh@kernel.org>
Date: Thu, 11 Apr 2024 13:27:11 -0500
Message-ID: <CAL_Jsq+PtL3HTKkA_gwTjb_i1mFZ+wW+qwin34HMYmwW7oNDFw@mail.gmail.com>
Subject: Re: [PATCH v2 05/10] arm64: dts: microchip: sparx5_pcb134: align I2C
 mux node name with bindings
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Conor Dooley <conor@kernel.org>, Nicolas Ferre <nicolas.ferre@microchip.com>, 
	Claudiu Beznea <claudiu.beznea@tuxon.dev>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
	Lars Povlsen <lars.povlsen@microchip.com>, Steen Hegelund <Steen.Hegelund@microchip.com>, 
	Daniel Machon <daniel.machon@microchip.com>, UNGLinuxDriver@microchip.com, 
	Bjarni Jonasson <bjarni.jonasson@microchip.com>, "David S. Miller" <davem@davemloft.net>, 
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, horatiu.vultur@microchip.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 5, 2024 at 2:04=E2=80=AFPM Krzysztof Kozlowski <krzk@kernel.org=
> wrote:
>
> DT schema expects node names to match certain.  This fixes dtbs_check
> warnings like:
>
>   sparx5_pcb134_emmc.dtb: i2c0-emux@0: $nodename:0: 'i2c0-emux@0' does no=
t match '^(i2c-?)?mux'
>
> and dtc W=3D1 warnings:
>
>   sparx5_pcb134_board.dtsi:398.25-403.4: Warning (unique_unit_address_if_=
enabled): /axi@600000000/i2c0-imux@0: duplicate unit-address (also used in =
node /axi@600000000/i2c0-emux@0)
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes in v2:
> 1. None
> ---
>  arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi b/arc=
h/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
> index e816e6e9d62d..cafec6ef0d0f 100644
> --- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
> +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
> @@ -395,13 +395,13 @@ i2cmux_11: i2cmux-11-pins {
>  };
>
>  &axi {
> -       i2c0_imux: i2c0-imux@0 {
> +       i2c0_imux: i2c-mux-0 {

Doesn't this introduce a new warning with simple-bus.yaml? These
devices shouldn't be under an AXI bus which should require a
unit-address.

All the sft-eth* nodes have the same problem:
axi@600000000: sfp-eth63: {'compatible': ['sff,sfp'], 'i2c-bus':
[[91]], 'tx-disable-gpios': [[87, 31, 0, 1]], 'rate-select0-gpios':
[[87, 31, 1, 0]], 'los-gpios': [[88, 31, 0, 0]], 'mod-def0-gpios':
[[88, 31, 1, 1]], 'tx-fault-gpios': [[88, 31, 2, 0]], 'phandle':
[[78]]} should not be valid under {'type': 'object'}


Rob