Received-SPF: pass (google.com: domain of linux-kernel+bounces-141574-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: parker@finest.io
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org
Cc: Parker Newman <pnewman@connecttech.com>
Subject: [PATCH v2 7/7] serial: exar: fix: fix crash during shutdown if setup fails
Date: Thu, 11 Apr 2024 16:25:45 -0400
Message-ID: <9af149b983592a7b8763132c64ca269909b4b8d3.1712863999.git.pnewman@connecttech.com>
In-Reply-To: <cover.1712863999.git.pnewman@connecttech.com>
References: <cover.1712863999.git.pnewman@connecttech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:kyFkFkRSoq0=;eeDmdpPDU1OJ7YPEsz61CCfLQFe
 zwVOh3DvjJoO6wJkHveiEkrZg+D/CF/Df2JKSIeMZh3TOmADpzfSp+HpQxX2YqmIzL0/KUCM/
 qewwFjewvrHNcVmDBrLL1kXKcb0WWkHNWoj5SN6foAFfN/WagtWS3743O/4u8XcAUsrCOQAjg
 Lhz5I9cIj6fPHi0i2Z/TICA9ifKDH4UHBM2Y+X2GsfkD4H4daY3346NAC6xkBqmeU4MtXnsXs
 3LU/ORoCgBkgjVYnn5KaDbDToeN7j8UJ3D6QRJXRBIMyiH1WUvZWedTBTzLXARwyKCrPCYc/9
 vIyT8XCPtyEKNc9qJqbx5Nw23WUbIE8RCaS2TC3dYH9h4o50O5JINfTiGro4Q0R3vb3bdA2nY
 8d0BjrSWYaR1z0fn8vcAXHtDIkdPUGTEdZC/9zEuiOQ0z+o8qV67G4vf/bB53JwXtcWUC7Inq
 J+dZJ1fwmif0UJul3v1LkK8oTu1oFjYp91IbKfI/RIZQ7r6gihYeuH6wJ+n8y0FG3OZkUTARN
 6mNaj8F6KO+YOVPyEPIlSU0Xuilwx5dznAcAEEuc0xwcxL8wUju3hwKS6AY7JDDq3/KOg2d8Y
 sObNF4plZQjOIV3lvLRaZ9bR3ZmjpUP1HOrCi4Axwiv25qtGxaVh9um7f+mc7iuZxfN04kaHo
 esJYhcpI4fVxDaTLIvJbvjsiJdQ/6xZjrEqP+14ckltGm8Huuq420VEoSs6B1xQgx6m0q4xSa
 hX6Mud+2fBLwxtVQkmJZDKbdm8IHXifHdwtYOcR9uz8rEfsu0QR6dU=

From: Parker Newman <pnewman@connecttech.com>

If a port fails to register with serial8250_register_8250_port the
kernel can crash when shutting down or module removal.

This is because "priv->line[i]" will be set to a negative error code
andin the exar_pci_remove function serial8250_unregister_port is called
without checking if the "priv->line[i]" value is valid.

Signed-off-by: Parker Newman <pnewman@connecttech.com>
=2D--
 drivers/tty/serial/8250/8250_exar.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250=
/8250_exar.c
index d8425113a9f1..1c6343ed76e9 100644
=2D-- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -1675,7 +1675,8 @@ static void exar_pci_remove(struct pci_dev *pcidev)
 	unsigned int i;

 	for (i =3D 0; i < priv->nr; i++)
-		serial8250_unregister_port(priv->line[i]);
+		if (priv->line[i] >=3D 0)
+			serial8250_unregister_port(priv->line[i]);

 	/* Ensure that every init quirk is properly torn down */
 	if (priv->board->exit)
=2D-
2.43.2