Received-SPF: pass (google.com: domain of linux-kernel+bounces-141585-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 11 Apr 2024 13:42:34 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: David Hildenbrand <david@redhat.com>
Cc: Alex Shi <seakeel@gmail.com>, alexs@kernel.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, zik.eidus@ravellosystems.com,
 willy@infradead.org, aarcange@redhat.com, hughd@google.com,
 chrisw@sous-sol.org
Subject: Re: [PATCH v5 09/10] mm/ksm: rename get_ksm_page_flags() to
 ksm_get_folio_flags
Message-Id: <20240411134234.09920cdb641b3aa001526284@linux-foundation.org>
In-Reply-To: <47686d5e-efd3-4431-b72c-620f749faeaa@redhat.com>
References: <20240411061713.1847574-1-alexs@kernel.org>
	<20240411061713.1847574-10-alexs@kernel.org>
	<192aaa5c-3ff3-40c1-b12a-b674518bf5de@redhat.com>
	<add08bec-f474-476e-a985-9017dbb33a88@gmail.com>
	<47686d5e-efd3-4431-b72c-620f749faeaa@redhat.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 11 Apr 2024 13:46:23 +0200 David Hildenbrand <david@redhat.com> wrote:

> On 11.04.24 13:42, Alex Shi wrote:
> > 
> > 
> > On 4/11/24 3:51 PM, David Hildenbrand wrote:
> >> On 11.04.24 08:17, alexs@kernel.org wrote:
> >>> From: David Hildenbrand <david@redhat.com>
> >>>
> >>> As we are removing get_ksm_page_flags(), make the flags match the new
> >>> function name.
> >>>
> >>> Signed-off-by: David Hildenbrand <david@redhat.com>
> >>> Reviewed-by: Alex Shi <alexs@kernel.org>
> >>> ---
> >>
> >> s/get_ksm_page_flags()/get_ksm_page_flags/ in title, otherwise LGTM.
> >>
> > 
> > Uh, for this trivial issue, do I need to sent a new version? or left to maintainer for a quick fix?
> 
> I'm sure Andrew can fix that up :)

He indeed can.  Although he prefers foo() to foo.  Those two characters
have a good information-per-byte ratio.

Also I added Alex's Signed-off-by to this.

        (c) The contribution was provided directly to me by some other
            person who certified (a), (b) or (c) and I have not modified
            it.