Received-SPF: pass (google.com: domain of linux-kernel+bounces-141589-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <001f99f4-9463-451d-ac16-0cda91e37e67@linuxfoundation.org>
Date: Thu, 11 Apr 2024 14:45:49 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] selftests: timers: Fix posix_timers ksft_print_msg
 warning
To: John Stultz <jstultz@google.com>, LKML <linux-kernel@vger.kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
 Anna-Maria Behnsen <anna-maria@linutronix.de>,
 Frederic Weisbecker <frederic@kernel.org>,
 Thomas Gleixner <tglx@linutronix.de>, Stephen Boyd <sboyd@kernel.org>,
 Nathan Chancellor <nathan@kernel.org>,
 Nick Desaulniers <ndesaulniers@google.com>, Bill Wendling
 <morbo@google.com>, Justin Stitt <justinstitt@google.com>,
 Oleg Nesterov <oleg@redhat.com>, Andrew Morton <akpm@linux-foundation.org>,
 Edward Liaw <edliaw@google.com>, Carlos Llamas <cmllamas@google.com>,
 kernel-team@android.com, linux-kselftest@vger.kernel.org,
 Shuah Khan <skhan@linuxfoundation.org>
References: <20240410232637.4135564-1-jstultz@google.com>
Content-Language: en-US
From: Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20240410232637.4135564-1-jstultz@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/10/24 17:26, John Stultz wrote:
> After commit 6d029c25b71f ("selftests/timers/posix_timers:

Tried to apply this for linux-kselftest next with Nathan's patch.
I can't find this commit in Linux 6.9-rc3? Is this is timers
tree?

> Reimplement check_timer_distribution()") I started seeing the
> following warning building with an older gcc:
> 
> posix_timers.c:250:2: warning: format not a string literal and no format arguments [-Wformat-security]
>    250 |  ksft_print_msg(errmsg);
>        |  ^~~~~~~~~~~~~~
> 
> Fix this up by changing it to ksft_print_msg("%s", errmsg)
> 
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Anna-Maria Behnsen <anna-maria@linutronix.de>
> Cc: Frederic Weisbecker <frederic@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Bill Wendling <morbo@google.com>
> Cc: Justin Stitt <justinstitt@google.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Edward Liaw <edliaw@google.com>
> Cc: Carlos Llamas <cmllamas@google.com>
> Cc: kernel-team@android.com
> Cc: linux-kselftest@vger.kernel.org
> Fixes: 6d029c25b71f ("selftests/timers/posix_timers: Reimplement check_timer_distribution()")
> Signed-off-by: John Stultz <jstultz@google.com>
> ---
>   tools/testing/selftests/timers/posix_timers.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/timers/posix_timers.c b/tools/testing/selftests/timers/posix_timers.c
> index d86a0e00711e..348f47176e0a 100644
> --- a/tools/testing/selftests/timers/posix_timers.c
> +++ b/tools/testing/selftests/timers/posix_timers.c
> @@ -247,7 +247,7 @@ static int check_timer_distribution(void)
>   		ksft_test_result_skip("check signal distribution (old kernel)\n");
>   	return 0;
>   err:
> -	ksft_print_msg(errmsg);
> +	ksft_print_msg("%s", errmsg);
>   	return -1;
>   }
>  

thanks,
-- Shuah