Received: by 2002:ab2:7407:0:b0:1f4:b336:87c4 with SMTP id e7csp71470lqn; Thu, 11 Apr 2024 14:18:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVJMH7WVVyNht3JH6paIdbic/jcFLSwr8Py+DLmrcPpeI95Duah6MWJPh3ybWDUCrrOYwfLr6no9llO31/TuG9wTcCMjbRZ3BTbs2G36g== X-Google-Smtp-Source: AGHT+IEM9HIF0e24Dzt7iifsy8leUN0zulX/5fUoNqwY3uK9ysTIzTEp6kQzSIkPdFYq63nVF5te X-Received: by 2002:a05:6a00:10c8:b0:6ec:ea3b:4529 with SMTP id d8-20020a056a0010c800b006ecea3b4529mr880945pfu.11.1712870300995; Thu, 11 Apr 2024 14:18:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712870300; cv=pass; d=google.com; s=arc-20160816; b=dlifdlbgvD1qLINl8F8RUdsVI3yTkfbZd6VPTweZsAZVh8FpPELCk2HPlaRGwOUYw5 QUJr1eIvosfMUKqtvLprJH/Lmm892gkGEUzpJN7t/7WaIIDbtjtLUTWqqBqhr8HCNPpw K7egXdmy7oHpdvk0sEUB/LsaePQzWEPzzzA7fPGuxwMdGHCgYgnLpm5thYp2PiuLgfHW Asebx4zh3I8ocWZ1U0g2DtggHMChMfQRtx3VKw9xSfUrAyvEdo63nAs1bgtgxOIXJXfV /VqpxXDSAljTEytqxmHftzgeYyEYTGTv7UhBTlCK+V829kwg9XetO1Hc4ZVu3IdWExrs oRsA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=A4R8SNBXJ275CXC4IwKn1Nf9LGrTrEst208ivldsCOI=; fh=6j2ZAtKtlVVtZe6yWDJEWmiTwd2grfMzeV4ImEXMICs=; b=eJaUIMRbNXHPKnqy5VSHijN2vP1kfoX+qB/eDw1War7q7IQDG34EuyJNnF07dIRyDK s8Bnw613rT/DAaoK9U2j4SwXk13nugupQgqW9yD6boKUELvuEoLxDWkXEdDCL//2qxh2 hipL+5lrC6la0g5GphJ9tYvEKobW5AtJbNOzH0LLAoYC8wVhn1k30+Vd2B29cj/oz6Ah mwzwT73QC1BYY81M5Q4cb2eYpDiS/a8U2WkrfhmRY8frRYddpsAEyS0GGe5TKZWJ6avv xeIQrIAMOl6cF8YfgunXqj1cTL+d77l7oDU3yVMXIaGkT33yUnmNUsYywl0K1sFaYcig gMWQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UxxTBHrH; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-141617-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141617-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id fy5-20020a056a00828500b006e8d8bff71asi1969091pfb.289.2024.04.11.14.18.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 14:18:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-141617-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UxxTBHrH; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-141617-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141617-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id AB5FD285BB0 for ; Thu, 11 Apr 2024 21:18:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7942F3D39B; Thu, 11 Apr 2024 21:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UxxTBHrH" Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5762E36AEF for ; Thu, 11 Apr 2024 21:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870276; cv=none; b=H8qComAmqhFP1pFbMYEWsoitQ/AQu+SIAhOgOM2ldaZ6pvcwPMBHEIjpHJCRFvDsXJRi3sZaPUIfOimYQxIBQiJogQxcalgP8ult1qtc6YhINf3bILxxYU5lLbrYZtnGY2WveAAuGnbE2xiixeOFX/BAagVEs1gMjHMgvJNUJ9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870276; c=relaxed/simple; bh=ufd7B+p2FkYNpk8qLtjfnLDHP5pTTghrh6j0nvh6z8w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PeCe0QNCDprDBquOB5jW47jB1rMjUK2YwQCoUvU5hRA9KTdAJqQMYFET+K3z43/iuWlLn+AeAcOztU0ArtQ8u1zbWIz69u9JBxUteiM06x1ztsYi7wjOZ/oS73JIv+PlddRID/1vxFRU0AcEkG5aJhLMAYLU81/mYceS4YmMiI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=UxxTBHrH; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3c3aeef1385so136709b6e.3 for ; Thu, 11 Apr 2024 14:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712870274; x=1713475074; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=A4R8SNBXJ275CXC4IwKn1Nf9LGrTrEst208ivldsCOI=; b=UxxTBHrHcEKj9qrhNBiFUPaGnqdS/+eENZ2ttbwLqITLIKri0XMmg6AKrgp4gGJhuZ EH3AOdhoM/HLqiS6kg7WC5Yh31ZKxUSvPczi2LQqpPKhH9TTCxw/oK3SUmokervwXr/z 16CGv6lHerxMx1binx3punJNY74MwyI4k0NCQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712870274; x=1713475074; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A4R8SNBXJ275CXC4IwKn1Nf9LGrTrEst208ivldsCOI=; b=Mn+DNiIabdyCnAwRyd3WWB5KClkU6Uhf0yjqa9vRqqGSDD/L+bUQBrVUR+njihroDV u0WIF5zrxdexKCu3/+eaLY+Q5qVzjOBSs3opPfJEWw2qyKxCCukMjU02/UZCZfxzMsBy UAGKlCwV6s3uRG1n+LVYSO8POidslFclHhLgHUMCxP827q7PI0x69EYbO9JcHYUZp0rf 0pUFjKMhM6mhvPlQmE0AI4qLHP0LL+uCt7b9qVB8kEkKc3vIwoxln6o+Sp3MwycWoNVf bc7vBdgGpvnK49bQ0SMF7vYIAODDvbO+g3ysoXGXkb07h/yx4yTqBl0wCan7tEBwvgEV diSw== X-Forwarded-Encrypted: i=1; AJvYcCWz2mIepaNDxfC4mbLC+FGOzlBGMHrJPeckhw5Lw5Knj7FNYI9OxLzqGgBK0e5UkCd9xYD3RArJjcRebGXlfbpemeIbEUXAI101FkyG X-Gm-Message-State: AOJu0YxZfqQA1NKGsBsKQ0lyjjOvISnId7J8ONpOmjphLVeHq4fDineN /cR5PzjamQgqNpgLXRp6oWPrk+MASLjdUkkR+wPQfwrhaq84C851Y3eO1vBceohbUnTkDPTa3IN 9sg== X-Received: by 2002:a05:6808:1cf:b0:3c4:f70b:7755 with SMTP id x15-20020a05680801cf00b003c4f70b7755mr793202oic.20.1712870274492; Thu, 11 Apr 2024 14:17:54 -0700 (PDT) Received: from denia.c.googlers.com (200.234.86.34.bc.googleusercontent.com. [34.86.234.200]) by smtp.gmail.com with ESMTPSA id k20-20020ac84794000000b00434d7c4f9fasm1373362qtq.8.2024.04.11.14.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 14:17:54 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 11 Apr 2024 21:17:51 +0000 Subject: [PATCH 2/7] media: solo6x10: Use devm functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240411-fix-smatch-v1-2-045f92467937@chromium.org> References: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> In-Reply-To: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> To: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , Patrice Chotard Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Let devm handle the life cycle of the irq request. Makes smatch happier: drivers/media/pci/solo6x10/solo6x10-core.c:631 solo_pci_probe() warn: 'pdev' from pci_request_regions() not released on lines: 631. Signed-off-by: Ricardo Ribalda --- drivers/media/pci/solo6x10/solo6x10-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-core.c b/drivers/media/pci/solo6x10/solo6x10-core.c index abf30b7609e17..1a9e2bccc4136 100644 --- a/drivers/media/pci/solo6x10/solo6x10-core.c +++ b/drivers/media/pci/solo6x10/solo6x10-core.c @@ -144,7 +144,6 @@ static void free_solo_dev(struct solo_dev *solo_dev) /* Now cleanup the PCI device */ solo_irq_off(solo_dev, ~0); - free_irq(pdev->irq, solo_dev); } pci_disable_device(pdev); @@ -544,8 +543,8 @@ static int solo_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) /* PLL locking time of 1ms */ mdelay(1); - ret = request_irq(pdev->irq, solo_isr, IRQF_SHARED, SOLO6X10_NAME, - solo_dev); + ret = devm_request_irq(&pdev->dev, pdev->irq, solo_isr, IRQF_SHARED, + SOLO6X10_NAME, solo_dev); if (ret) goto fail_probe; -- 2.44.0.683.g7961c838ac-goog