Received: by 2002:ab2:7407:0:b0:1f4:b336:87c4 with SMTP id e7csp71720lqn; Thu, 11 Apr 2024 14:19:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU+fRstUkJhN1NXIYldLWmDKBNHj6NTqDXkIg3KfAT1cCU1NHQwJ7PG7XL05I0q3QAToYESa2EUPHNZCnfgmnePPGezp6yw1qthEKzcig== X-Google-Smtp-Source: AGHT+IE6jRjn1tEZ9liIM5DLPAlTPxeo9Eq2IldHZ12mbWvPdu2f9cZkcA/9lDQfbP0NwkL3xK3P X-Received: by 2002:a9d:624b:0:b0:6eb:5b4b:51fc with SMTP id i11-20020a9d624b000000b006eb5b4b51fcmr198413otk.24.1712870340626; Thu, 11 Apr 2024 14:19:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712870340; cv=pass; d=google.com; s=arc-20160816; b=eiFZTl8/trPH2s0PVAH5XF4Jps+OvIkQnFDoQ8yVs2gl4WSIIvKTre1EsvTkMzPh6g WB5lB8FvFPfl8JYiftzTnUf92t1/kMmaWNxk2zx+cxY3zRR3RnVKXrDB7Xwa7gr+wGQf gQ5EIqpk3+wme7iZwLVsy/6oN/oMQ9WdV9tJAO956yBpCbfnq1FoUUHHA86UOoAVIsIb Fk2SH1NHubwGQ80rynJLwz0TYnyznVcs9vTjYgjUmGFmI5t4yGJAl6o2F16BIbsjySJm 47VIqFzkxTi3PJ2YVR5HgLP++RnxWkzKd0EFGyF4UX9C0PZGEuaU2hWa1+QAQKn8i358 fV5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=TL6JnALE0FuyaUB3vxEn5mmMwRa1J5olT0hONBuxBN8=; fh=p1DLIutbEM8dj9udau5nq+Ro6J1G/AOnlaXdS1w9ExI=; b=R+JPEN8uhdsgnV/1eUO8/DzulPuwMYYH8qGS74z0+mfZFVkcLF6BgFCmMCE6M+tK4l PE1YVnhKBgmvP6fvU0JNLbpRrtAXJnKJnN0tQPFrd37Yxw3Av5aUrMLEreLqX0jNNdKq e6pyKNlaS8grduhYJL/ZLyqJvBS/GIKvB8B63YWXFBAkl1OWE4QLuzqDTp2F2RoQFoWd jwFi3uXJcuAhq/vRdcylRBaomncjY/qMCOybBG3r1jc7kcel00HVsDwLzWQbdlQHeCn5 7m5MQLYpGqnFize9mpQ0tlNUsycp8XSEAwn27/PvAoSpA2qHyyl0qtK1BgWmlzls/LQZ AiZw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Tc3ha5I9; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-141620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id bm39-20020a05620a19a700b0078d60c72e8fsi2652631qkb.563.2024.04.11.14.19.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 14:19:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-141620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Tc3ha5I9; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-141620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 593BD1C21F3D for ; Thu, 11 Apr 2024 21:19:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C40D040BE1; Thu, 11 Apr 2024 21:18:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Tc3ha5I9" Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 903843E462 for ; Thu, 11 Apr 2024 21:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870280; cv=none; b=QgZ4rc7xqZIsVHvEiMGx+Ngis/sQydN/TPHzMF1WnYQ0rREbnDeP0XxnEeQ72PlDfl5MI2ItTxCDJeeAWQTyQQ5hkEebA2z3gk8l4mI+YvyGXb9CqsKuASP2zhkdRi/JVq/FZU1gkgm8+dMHvpgBYApxuUlCh1kiPICRmc4dUlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870280; c=relaxed/simple; bh=jVTlH6xfXoB6FESZXfYYk6pPpl6OaLfHd2BNU/Y9GQU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dCIqM9tbtJNczkRRdyIQVhv/7CM4LpIihEomM4iPjvil2ut3RCMRjL/wHHWaB6S4mrxOp0v4qM1T7mTJSpmZVQDHB8ZxMnl+Fbg6ioqU7utzHrM2SRccSIvha4tnuehVelJpPbhjyCdNucT/82VAVPlydtSZlMSNYic3Iau/wW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Tc3ha5I9; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-43651b7004bso1522451cf.1 for ; Thu, 11 Apr 2024 14:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712870277; x=1713475077; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TL6JnALE0FuyaUB3vxEn5mmMwRa1J5olT0hONBuxBN8=; b=Tc3ha5I97/v6Oelp3/EyyzXlyuwIlYoEN8/V4u36Cv+ClIxOJ72jDg2dny8L0jIuqo M8c2HwBoKlo8lQecZDp6VFv8YIQMxhTd3lioZp5SPHsSnHS725uO1v5Rkg4t1Kq/Y6La DHOox7fUZaYMAf2JZiQW3G1omxGWo4EMVyctA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712870277; x=1713475077; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TL6JnALE0FuyaUB3vxEn5mmMwRa1J5olT0hONBuxBN8=; b=QYoXoyLu4OUuLktrIQKK+awrSg5WsJkU5Naujr+jXfpFtDLnEv4pHnhGHn3ie0wW6C l/cx/n4jpYh31wy1iCRy269qBPSpg1hVzgtRaopifyovsu9EiNiAo2EJQyvAWlN5JDUv ZmfpG/JXtlfb2siSKn5HWYROxNgzsU3AU1bRs9Mq0I+A2bMH6cEXAvCaT7LQa1zjNHPg utZr4/vQ/VsUh3yjo8U4RVdWgBd2eemwFGJClaJq9iuQwkry7hKhl748kvn1190zgTYl mRD3brM/O5hBSyhSoH1tkWSvvkAH2xVKeGkzQ9aDeHI++YXlr8VfNJm3mOnCJeRGdN3s UGJg== X-Forwarded-Encrypted: i=1; AJvYcCVlauGiAMTGmNIG1pc1W4/FkQv4OGO8/VZonhYd/TQmAGBPQqEqqoQU+gqJuPyg+fDEepZ7IsuP+RiygDFvlpNrkGGlgBHBRrNlLL/u X-Gm-Message-State: AOJu0YwsOLOw5UX583fT0Bsn45C0Tl+S59Z8M2K5dwNdbKE9cSOjZIzi 4cZAlGy2e9ck6VlYw0mcJLi5GEvBfermuOzC334LMg1/nnSOdcJHiylSlh6eSw== X-Received: by 2002:a05:622a:1897:b0:436:89bf:5706 with SMTP id v23-20020a05622a189700b0043689bf5706mr270247qtc.17.1712870277703; Thu, 11 Apr 2024 14:17:57 -0700 (PDT) Received: from denia.c.googlers.com (200.234.86.34.bc.googleusercontent.com. [34.86.234.200]) by smtp.gmail.com with ESMTPSA id k20-20020ac84794000000b00434d7c4f9fasm1373362qtq.8.2024.04.11.14.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 14:17:56 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 11 Apr 2024 21:17:53 +0000 Subject: [PATCH 4/7] media: c8sectpfe: Refactor load_c8sectpfe_fw Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240411-fix-smatch-v1-4-045f92467937@chromium.org> References: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> In-Reply-To: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> To: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , Patrice Chotard Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ricardo Ribalda X-Mailer: b4 0.12.4 release_firmware() in the same function that it was requested. It is more clear and makes smatch happy. drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c:1146 load_c8sectpfe_fw() warn: 'fw' from request_firmware() not released on lines: 1125,1132. Signed-off-by: Ricardo Ribalda --- drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c index e4cf27b5a0727..ce0fd6ace8032 100644 --- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c +++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c @@ -1097,7 +1097,6 @@ static int load_slim_core_fw(const struct firmware *fw, struct c8sectpfei *fei) } } - release_firmware(fw); return err; } @@ -1121,6 +1120,7 @@ static int load_c8sectpfe_fw(struct c8sectpfei *fei) } err = load_slim_core_fw(fw, fei); + release_firmware(fw); if (err) { dev_err(fei->dev, "load_slim_core_fw failed err=(%d)\n", err); return err; -- 2.44.0.683.g7961c838ac-goog