Received: by 2002:ab2:7407:0:b0:1f4:b336:87c4 with SMTP id e7csp129317lqn; Thu, 11 Apr 2024 16:50:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVjvxSNsLm9HcI4q5keQQ/dJmqOv421a+x3vBmwa2cPwdZ7JqjhF4mUmOyGVLSTUxhXqyF27vpuXSTn5KxeVmNwqV0Vn3G9IUeLm/bHLA== X-Google-Smtp-Source: AGHT+IGqRhPUW/5lcbf6Wpm+w+kCXRCLiqjJVSHry5SfdxQy5449/bbqpG5pTTIlwripAHXWjR+4 X-Received: by 2002:ac2:52a7:0:b0:518:6fa5:489b with SMTP id r7-20020ac252a7000000b005186fa5489bmr586473lfm.64.1712879443855; Thu, 11 Apr 2024 16:50:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712879443; cv=pass; d=google.com; s=arc-20160816; b=YB0GBWMdDJazFYV/CBoVAcI4HPRDiH7PlfawKAiptKA0/0lkArEzT8DnVn9dBaLPk1 BdhV33XPStBYhoc6vIJLimzfu1zOHQnAYYTwhvLkvKu5kjrUCBlkDVWU6CzpuyDsGzZL S3yTWV//uP2M377XJp8Oeyb7H1OoBbTfd3XBBfcnoKt8dGWsxRG7v5ly2FlCVagyfpp7 EvCHZWiFUC2ymUbEPjw88HL0KN+SPHE5lJMd4uhh1xK2EUosv8vn5AByWlMZFXBbiVDU ZhQU+UZ1zefsFy2eQJHc3hB+Aznl58wgHO/rYuFzzN/7xDfoNeVMoBrOBBsZUfD7u7jv gkNg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=mzQXyjqX1tud9XJAAPq6taeKKD1DkGuDn7UJbaDURSY=; fh=s8CGwYSfyJZuJfoDjoorunfochexlgFCtaMwexfk7Pw=; b=iiSyuZ+NwBmmVWlgId+K7x2KMZ9BXQKLxz6a67AIsDAeo9kIwz8efBgPZK7M/7S4nw vPRrb3nG8CbT01pCsT6n3oIf2o77Sn4hok8oTfxb2GzWKBGqOauSbECHP1V+S9/QQz8X 48gcmnxQ+Wo9q2FNBDBac7nAv+HdNZIAM8Rct1A30a0mx0VP1tWOSGIwnOuC7FYY05pw WPaiWaxoQP3VmvJS+h7Fri38ucRlFEpdl22wDCDWLT/opiT4HH8o0IPmTPbHT5e+rhm+ CUlckSTQuFeC/FvZgY3uhc//IMncZNntdymk8jFHR65Coz2Yl+Dlru1xuZPUfsM9sZlu 6lUw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="TphtNR/P"; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-141725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141725-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p3-20020a17090628c300b00a51c1d84505si1143243ejd.592.2024.04.11.16.50.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 16:50:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-141725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="TphtNR/P"; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-141725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141725-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 788561F2321D for ; Thu, 11 Apr 2024 23:50:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 936964B5CD; Thu, 11 Apr 2024 23:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="TphtNR/P" Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DC2E2C68F; Thu, 11 Apr 2024 23:50:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712879434; cv=none; b=qokKuAMYGlh1Xbh22MlEXadiQ2MUUzbd2K6hq1Q7k4G5ZWI/ixVu9UiSEjW26RlVsOQaQX+l/IwXzZIPaI00GFiGAPZ9hlb400NG9N3sK9nd2dQ17fffqiKnRmO6ZddpE0mzgDN8n18uPT77q1RBcsvdBS8u3H7DVr23bKJVLA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712879434; c=relaxed/simple; bh=+ZbVM53olLQwA3LTGhsIEabeEfmwDoxmEtMaj4RVRwM=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q/+iuRkrwgOL7t2uVKe32x5UsOIvJH74LQglo8ez8moiLjR/w1W28Oa5ZP3JZcCh+K95R1OtZokAPTha3POkrgpR1Hw4zf4tcd8lyGh4qHxm2Wg7FWJ5qWfzJa4VoEePA37iepyPYubP76u5hd2pjcGT3uha0KD7/SK8H7U0fSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=TphtNR/P; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 43BNUFm6029773; Thu, 11 Apr 2024 23:50:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=qcppdkim1; bh=mzQXyjqX1tud9XJAAPq6t aeKKD1DkGuDn7UJbaDURSY=; b=TphtNR/PMDSRSzMWvgOgtlCNtd1GfQC5UQT0H 11DxF6Q2hIGIEWB4PucpPMI1iNYgA3HFW3hiSGJTSn8tctkq+ssUrIfFwD8lsZMe 0V4yXTB+7BdRd3AGOmC3h/A8tDAKhD3EVV7bAdTmU/L1l6t8dhYTdIPmtAIfD0Y6 JTZlpVeKts9Bo23vHBx71eImeSJbLk1wIa8sUAjXXoKjDSZbHMoHr1nQ8V0BxYaY ONld9xP6EZtRCTojwBIQKFOUP7PKumSxWh/3wRBI7tzCPKxh1IPTlcuGAhm0aMQE 7NMmj+0isSrL9Ymvks4tnzI8JpksukDvF6sYjiqh5M1DJYKtQ== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xem8m0n26-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Apr 2024 23:50:22 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 43BNnjgX012898 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Apr 2024 23:49:45 GMT Received: from hu-eberman-lv.qualcomm.com (10.49.16.6) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 11 Apr 2024 16:49:44 -0700 Date: Thu, 11 Apr 2024 16:49:44 -0700 From: Elliot Berman To: Konrad Dybcio CC: Bjorn Andersson , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , "Daniel Vetter" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , , , Neil Armstrong Subject: Re: [PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them Message-ID: <20240411162849104-0700.eberman@hu-eberman-lv.qualcomm.com> References: <20240405-topic-smem_speedbin-v1-0-ce2b864251b1@linaro.org> <20240405-topic-smem_speedbin-v1-1-ce2b864251b1@linaro.org> <20240410132510649-0700.eberman@hu-eberman-lv.qualcomm.com> <2c2bca6c-b429-4cef-b63a-ee3bd6c9eecb@linaro.org> <20240411130802689-0700.eberman@hu-eberman-lv.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: F55obkBZh8Y7oG1qCozFOKbMkGxrJdD9 X-Proofpoint-GUID: F55obkBZh8Y7oG1qCozFOKbMkGxrJdD9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-11_12,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 priorityscore=1501 malwarescore=0 phishscore=0 impostorscore=0 mlxlogscore=961 bulkscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404110171 On Thu, Apr 11, 2024 at 10:24:08PM +0200, Konrad Dybcio wrote: > > > On 4/11/24 22:09, Elliot Berman wrote: > > On Thu, Apr 11, 2024 at 10:05:30PM +0200, Konrad Dybcio wrote: > > > > > > > > > On 4/11/24 20:55, Elliot Berman wrote: > > > > On Fri, Apr 05, 2024 at 10:41:29AM +0200, Konrad Dybcio wrote: > > > > > In preparation for parsing the chip "feature code" (FC) and "product > > > > > code" (PC) (essentially the parameters that let us conclusively > > > > > characterize the sillicon we're running on, including various speed > > > > > bins), move the socinfo version defines to the public header and > > > > > include some more FC/PC defines. > > > > > > > > > > Signed-off-by: Konrad Dybcio > > > > > --- > > [...] > > > > > 0xf is the last one. > > One more question, are the "internal/external feature codes" referring to > internality/externality of the chips (i.e. "are they QC-lab-only engineering > samples), or what else does that represent? Yes, QC-lab-only engineering samples is the right interpretation of these feature codes. Thanks, Elliot