Received: by 2002:ab2:7407:0:b0:1f4:b336:87c4 with SMTP id e7csp163602lqn; Thu, 11 Apr 2024 18:28:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXxHWxCQwfUzfYD1UdVckLy5TglfDY9kW2KwDC0PLYDajW/zeyPHeMZ/Ta47sJOAB5dryt/DXqwLbfcvfC4wLl2bBqa3USi8kbY2yy8Dw== X-Google-Smtp-Source: AGHT+IFRITbpGQ5oEl6UnclEhThTtobSwwoI/Z10v7S4AgEKciJQYYnN32Zrlr39I91GB+O39o07 X-Received: by 2002:a05:600c:ccc:b0:414:69be:54b0 with SMTP id fk12-20020a05600c0ccc00b0041469be54b0mr882357wmb.22.1712885301722; Thu, 11 Apr 2024 18:28:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712885301; cv=pass; d=google.com; s=arc-20160816; b=f2tkj6XGDuneGze964r+5PlI/d5LcUjO/CffONtV58WNpbewquUo+U4YO+6Q2u1rwG 0ldMxog7QYazPuGAk2ecHWHjQgECdq62P52gHDtNxBypHrKg5eMxtRB8LUkPCTn5vdxn /XBzJ8oYjgLUdXy/aT9qxMJ0B+CBoQUnp6m/jGmLX3gj3nBMHIBe1bXc3s5C5Kwo9UxR vou9+UfOdm2DaP/OPtVCH13XXEHDHnzIlsthUyrhOmhceLCaIGkSrVj+pGSxPftOAH6K kOiyd13ME/rEOsaPwVRnXy6eDPCU99Xt2f7p+mrkeTTeRzLfEjLqWAqOEypBWx+zCBNV ycQA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=+Xkf3r825F7wfDU8twPTWxjNLonSd6C14mKqSjqUdZA=; fh=X9Gc8vHx957hKak+Z2QCE60E+xGBneZopEgLNcONH5M=; b=BWAmnnsWROnlXEn6hnxPk4jjHiXX5ls4OixnFTNASbPhjZKcyAgrdQCAqCEeZbOu3m X3yHsC01E5i8tMDy2q9/wqbjgQIhgf9xtyzqDTDz2SCr2bGnlofT9cDMDs41nWXpC5dE wF5nWuWW6irWD5gIKcsyntc+TRG5d8i2FUTAkR/03Yu4wav/jVtsPyyqV4ZekRcnHluJ 5PZq4rnehWrA8Es8HhsN93w6hJEa6D0kSRaNxPGFk/8K2OVflBnrBcY10VcSJltLIadD ES9OLPMji6uiwVAagUGqWjGBhKCkzr2vhHkCDdLRg1fQ89yGqsGK0fDggfnFPi7B+LUj NjZA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Wa9HJT4N; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-141771-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141771-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id q16-20020a056402519000b0056ba9c067bdsi1181872edd.250.2024.04.11.18.28.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 18:28:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-141771-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Wa9HJT4N; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-141771-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141771-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 73AB31F22F71 for ; Fri, 12 Apr 2024 01:28:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 782F215491; Fri, 12 Apr 2024 01:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wa9HJT4N" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9382F12B79; Fri, 12 Apr 2024 01:27:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712885251; cv=none; b=Y/7mEfiCHffK4c52yEXSHA4feyZxstDbZSmWujyqNnpSTS9aS9NiaOWA9Cl4EdfN9G0CDoAEoorkJ9Aui1rECwRFMI+JEw7X5qt70xEnk3ZyvpPFCOVmJzgfL+thY4atsJ74ippIqpsH6GjzzMdFB35G+nbZ5KPCPmhGkcgAMow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712885251; c=relaxed/simple; bh=Ftl1ELwoUg2yhIIHfz2G1tgb+Ro1SsK1dVV7+WesnzE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UI9zfiDUoyVVty96/eXPuV4+wY76fR4mSn/SohaFfd8x7AFsJy6SZvYuIKSFi7irBnmJZr5RtyVV4jw44s/YnV1tVu2zDbl35n+OMTVyNpfEshOda+4o6mUfQ9nWvF7U9pxNiBBfnIDPxSkeRfAu1kdAdKWCS26hUFhg4OLDC7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wa9HJT4N; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5AB3C32781; Fri, 12 Apr 2024 01:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712885250; bh=Ftl1ELwoUg2yhIIHfz2G1tgb+Ro1SsK1dVV7+WesnzE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wa9HJT4NX2U9KixURe0OmDMPjdp9Mh/udp2DgLxOk0T2fcCR7+N45J6MTJUW6bsvh 9VZTiGYMMyIN9DEhzRR1ZsaqWCHkzKp3ssYDO+P0s9Fhy9deoiHi6h/EGbS82BY2jR ADYy7X0+FENxApBVTAbsKCxR1aCbMSdKEWeGqDib1TPy1D0QA3Woa0vUBWqxjxRJCx yrhbIeRLxsSAXnUvo8mZnwaxvR/G/GcbeQaioCU2GPe0xmdy5CFBDf8OrCdjhfNaur 7LRvXgsHxrmAlOnJx+ejBS5ciMbPxqwCiwu5rYFgwJ6IJTeQheSLIkYp+qvFA5tCH+ vMzaABd1XIyvA== From: Bjorn Andersson To: Maximilian Luz Cc: Konrad Dybcio , Bartosz Golaszewski , Johan Hovold , Krzysztof Kozlowski , Guru Das Srinagesh , Ard Biesheuvel , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] firmware: qcom: uefisecapp: Fix memory related IO errors and crashes Date: Thu, 11 Apr 2024 20:27:24 -0500 Message-ID: <171288524180.749915.6159719966958784520.b4-ty@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406130125.1047436-1-luzmaximilian@gmail.com> References: <20240406130125.1047436-1-luzmaximilian@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Sat, 06 Apr 2024 15:01:09 +0200, Maximilian Luz wrote: > It turns out that while the QSEECOM APP_SEND command has specific fields > for request and response buffers, uefisecapp expects them both to be in > a single memory region. Failure to adhere to this has (so far) resulted > in either no response being written to the response buffer (causing an > EIO to be emitted down the line), the SCM call to fail with EINVAL > (i.e., directly from TZ/firmware), or the device to be hard-reset. > > [...] Applied, thanks! [1/1] firmware: qcom: uefisecapp: Fix memory related IO errors and crashes commit: ed09f81eeaa8f9265e1787282cb283f10285c259 Best regards, -- Bjorn Andersson