Received-SPF: pass (google.com: domain of linux-kernel+bounces-141791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
To: SEO HOYOUNG <hy50.seo@samsung.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, beanhuo@micron.com, bvanassche@acm.org,
        kwangwon.min@samsung.com, kwmad.kim@samsung.com, sh425.lee@samsung.com,
        quic_nguyenb@quicinc.com, cpgs@samsung.com, h10.kim@samsung.com
Subject: Re: [PATCH v3] scsi: ufs: core: changing the status to check inflight
From: "Martin K. Petersen" <martin.petersen@oracle.com>
In-Reply-To: <20240411071444.51873-1-hy50.seo@samsung.com> (SEO HOYOUNG's
	message of "Thu, 11 Apr 2024 16:14:44 +0900")
Organization: Oracle Corporation
Message-ID: <yq11q7bl50u.fsf@ca-mkp.ca.oracle.com>
References: <CGME20240411071042epcas2p4b2e6937a952e6dfa879db166983b1c54@epcas2p4.samsung.com>
	<20240411071444.51873-1-hy50.seo@samsung.com>
Date: Thu, 11 Apr 2024 21:54:35 -0400
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?E15tc4pLoeLmAGk1wz/DsDgL3UZccby7CSgKA2hYRSWIUoHhxfVbnhKIlxgH?=
 =?us-ascii?Q?GrWM3yyrZfjF5OpKDBBrMXPZszhF85sI0F05tz7HowHQfoKDeanuMW3zEL/z?=
 =?us-ascii?Q?v+LUhr+Z0dYbifAsDWMVXeMxqwX9Qmr37BTV+Ir4zzTJE95CRRLtdmspULvx?=
 =?us-ascii?Q?ebhkVEbhxn+ixGVHKzvs9gcKyB2Tqe0sA/vAwhv0TMarscqGrEzSY5mLALpf?=
 =?us-ascii?Q?VgpJX00wwK6ioZ0PfB34S5F4edvm46LxlSHgEwKV8F8cJYhHU+hwx6SH7MGO?=
 =?us-ascii?Q?R1sZEKLrB828qSZn2oMd1gcIaXwmEoQxSd1pKus/z1Tk7E4F77idKGGZJugz?=
 =?us-ascii?Q?SpL1Y+1ikReXRpGHDL3dwGBAQn6bHvbJTdHoWyZiVYsFuZnjAYnKA39WY5+S?=
 =?us-ascii?Q?J/tFt8mF1SWBmVp5ymB0CbFBgjrEmokRtC4BTe7Yp0OCr7mzy6kLn4WhZC9t?=
 =?us-ascii?Q?ni7/SKEO5+RY/gVG16wXR4ge69w01HEhnW8eieHKW1brljfn1ZXxrGn0Lygq?=
 =?us-ascii?Q?hzSU7CPKCQeA5v/i7HHLdFj5b9HX3qpCxQRDCXY7s8ZbSSkkKgOIIiovjdzC?=
 =?us-ascii?Q?uYoPRbBz+mLDfl2AJlo+PLhv7dAmfz36Vv6OtHioy6p7BUXBbk6eUjEbmWUs?=
 =?us-ascii?Q?dQRhQ1AkBjGnenFAmbm0Z5ZWadZUyAdmZ5t3KZkseJKP7HcAkroRWnkejihc?=
 =?us-ascii?Q?JB6VzONM3VUUwIn6TZFuIeJEup02pLJb3FsEFgj7JtjhYJMg+P2Dg+/R29in?=
 =?us-ascii?Q?dqZb/ECMWLa1TC2CC/k/J0N+4J2hCbC0KgSj7hKBgf8KPG8VhHsQdxnWKqoq?=
 =?us-ascii?Q?Rcrc8bPvtjlA80nuCwqXlnFW81+T9NpOsOZWQcqbQ5Tqn4enjoIXJlY45TmS?=
 =?us-ascii?Q?7Lj7O+xcjPMJbSZNK1AXavF32aBqKAoNcomLkQ8imgophGf1+9+7JWAPh71r?=
 =?us-ascii?Q?4AA6TRs3E0G7y+j3oEJtGqt89jAjpwN1dOeqkp8mJgq1cbDuCIZo24Vr10MJ?=
 =?us-ascii?Q?fg9NG2u7hJgMR+84zGqduuJ5co9Cwtah0HhM9sI6etVmjwUjUA/x38nZPstw?=
 =?us-ascii?Q?hgSskt0BydwbDeiiFn91ELOUXVwCMgR0XzBzVhdsAnOUl6a1AvH0t1h4FGg+?=
 =?us-ascii?Q?7TFw1bZ84BWbcPQHD1vb5F/47+yYwBEl4xEI5j6ilf4DUSG0ocIftRX2G9/Z?=
 =?us-ascii?Q?javpmN2foeYbIYM//+g7J12G8uE+ry7id2egxb5eYY2LcjAjkwdcqHC5TLAL?=
 =?us-ascii?Q?W9wn7tYgRh0b3O9tOxzxX7BpS7gNqK90pJp8pDbTRSYif/b5D0q8mu63doDL?=
 =?us-ascii?Q?mAia+3zXSIxO7iK6JMyNit63/wgQRgvKAlvDI6yp4alZsga1WB0YUGMTlS3l?=
 =?us-ascii?Q?qygRVgLUe7Fkuy83SVl9Uu3m23x9AYS+2GigPWNWWc4p7cwyXgKm7UyWWYoy?=
 =?us-ascii?Q?G1PrfZwowQGL79Ywu3UQrES7zJGlnxlWNGLyyVQBVjXBOi/T2HyLVxFoK7QV?=
 =?us-ascii?Q?BeFdvVgSp4dX0S0uzdRh3g1S+8vNSt0CNuqOmcybHGs88LIuwPvVEyrXk6Ym?=
 =?us-ascii?Q?cntyDzM+BL1yfU28olsL0c4711kRgYTupos0G7GFsGHpRkDlu1sFLICaKXxD?=
 =?us-ascii?Q?Cw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	ifVYFtz5ZDjuXXasFJ9KVY39V4kc/q77HVrqAzU1dAsOH6aJ9ow0bp2RAntfLXJOOcLfXnutxN4ABkkUCzadRLF6pReHqxuPcAZlzaLKvb/AQDWHB1z3z7b+d829/ombKPA9+Jv1J0jiFhYLZZhg3xbK4fRoFapsbhbTUrdvTSmjeh5QJmNMz+Z3wK9aAOGj1sy26V9+JrWKJR5Bmu7prXka7y3iAGcBt7qsuASbSBuTCZz0hDA7KiWZYLb9GCQJ/IgM9pvEvvpYzPMtATX50ELjZmyN7nIwt3fFKdqvhZrd+oS12nvrnW1AulktvtmQN/WmJ1OFHsJgEzqWZ6HyWBdK/0GAKJ7okep2iPFxWvnL0M1n+uZvkkb8PGNJj+e01j16uyOoeCY+lh7s2PmLoJAxUpek8VVUaihlayvvb72pafS33jIYLuHjeV4f/xueBWaLZeN7CEGPkQqKRZbIHzDU5QgywSurw0ggzpGmtPcZnMD9QksYVl9a/GEtUxKDucF6El/FmKqE/erb/D053PNNDSz+oNSBmEP3lx0LwdM/R5ZPKW0lzP4Hw5LQrKrIOgDOuEmxIaLzUIJugtey5gapbgqLp3Fp34SPv10ghOQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8bcf5158-931b-460b-5aaf-08dc5a9383eb
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 01:54:40.0626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: heA9bgEA+OVTyC5rHc0RPNH/EkM+RPOlbOiqf+Zoc52Jy+/fJmaBw7StOENaWLZc7tXgYgQHxTYZNnr27xaY8fz2wmgmKsm+p5FpbGEnZyI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4667
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-11_14,2024-04-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 mlxlogscore=999
 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404120012
X-Proofpoint-GUID: ciYgpKiBo_aDrgtErTljwt01XAXFAD9M
X-Proofpoint-ORIG-GUID: ciYgpKiBo_aDrgtErTljwt01XAXFAD9M


> ufshcd_cmd_inflight() is used to check whether or not a command is in
> progress. Make it skip commands that have already completed by
> changing the !blk_mq_request_started(rq) check into
> blk_mq_rq_state(rq) != MQ_RQ_IN_FLIGHT. We cannot rely on lrbp->cmd
> since lrbp->cmd is not cleared when a command completes.

Applied to 6.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering