Received: by 2002:ab2:7407:0:b0:1f4:b336:87c4 with SMTP id e7csp190912lqn; Thu, 11 Apr 2024 19:59:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU/kX3c14s6Y7JiF4pHrGp09XpuE+qQEEF/r7zMNxHOeS8qzJL1kFPiroCt8j0LVa/7qL0UZPTb5ekDnNl7HN1bV7gd9t8BfbZ5dnCbsQ== X-Google-Smtp-Source: AGHT+IGf0Md+HRMB9VQuKqSoVdmo01zjHe9g2C54/G4Nm1okLKm3hQLNfaJUNbDV/+B/x0z9vhI7 X-Received: by 2002:a05:6830:3443:b0:6ea:186e:d333 with SMTP id b3-20020a056830344300b006ea186ed333mr1522241otu.14.1712890766636; Thu, 11 Apr 2024 19:59:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712890766; cv=pass; d=google.com; s=arc-20160816; b=y1/yhRrAhO5bu9DQBl1U4O9Iht0zbqSd+LCOiEuxb6Uwj/4thS79t73WzGo8QTlWbT aS0kOgEyYM3yyInEdMxTWKnturdIVNNXOwcTTHn8pjbbl0tG0tfFFKWRJWlACWiIF4YZ Nt3HnJZVK5RY1kVWA66Fx7B0e9Kg8oxM2gz9F+vD51Nx0UDnx6vKy/dDWVIxgYTeM7CF sHtymkmSfqTuBblXjrBdU3COM3ptyA+RXWyE+lm2JaIP3YJHqTrY+M4uSWAQEbld2lvD PwRVNReQzkSJcJawYTH7aPA1o0Sk3ZcFRiXUuoeGWQ7HwJGlJAauLaXlrCKFX8y6lLeo yy7A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:date:to:cc:from:subject:references:in-reply-to :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:dkim-signature; bh=p+4XkXpOxunuKnnWO83NDMUzum9+mHSSGqv0fFD9r7s=; fh=jhRrYQLgWLM4B5QwB9JZbmPhY4pZ0AXyVmVwIln+95w=; b=u4E83+h7aSHiNH38lImr1WWJYi/lFGFtYT/6cWl+Vq11uV06lK+5t1gdfeQmJVPpD6 /zP4NOyi4Obj9IQTNJ1NhakbZF5aoJ0AJP+DUoTLi0FejBTJ6ciRoMsmArDIaiyhn5TM q3MPLbnrOyma49BrNQZA9nrjmlwq/vC4ktPG0NhKaFoTkZqUMrqBtOcHeeBy2Vpin1k+ mnYgkCaYc0+yCzlT/v/EwPvDqukT5ImAnK8I5Ob8gOCdGarwdun55pdhkkEChYoc04Sy KmPxf7hOsLzJqrMpLp8wMoLyOrbkSmzxbgN1GLmXwdZs0z9cSxKbkSEwacqcmiVfZlcf H/Hw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QBXPtoxV; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-141829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 4-20020a631844000000b005dc5568b149si2308261pgy.297.2024.04.11.19.59.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 19:59:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-141829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QBXPtoxV; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-141829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 86349B21C9D for ; Fri, 12 Apr 2024 02:57:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C75C2134B1; Fri, 12 Apr 2024 02:57:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QBXPtoxV" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB12A2581; Fri, 12 Apr 2024 02:57:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712890632; cv=none; b=mm5QEvdAxlJq2Gq/vHSSYFsCaAlDdvlWoZoVUt316rVgEwQ1IIZvjfUUfwExHLvaD/nlbSFg5pGWNWaNg7Y2IOTrzeh3i3JNT/Mkc6KRqGL82IFTeaERRh+ay+AxMJjvzsMoXaGfV7SR7WZHtXt9mg9KqmEhnmrTfNv2TeZJn4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712890632; c=relaxed/simple; bh=p+4XkXpOxunuKnnWO83NDMUzum9+mHSSGqv0fFD9r7s=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=L6JyFkn2NKnr/r1c1ydjG3XVmK4h0FWLV1miMn/3gXcXuBF0R2N3+scHv2ObOAu+HOlYug/HOV9iOrPvEiX4+RGMnjWrVD5F1Atnd3O+qPj2Y0JDmjt9Em8EqImeVTB7MlCutjNGDtT/WHEwETI6SCXibHkeAoj9kLQXp+xNGgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QBXPtoxV; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CD58C072AA; Fri, 12 Apr 2024 02:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712890631; bh=p+4XkXpOxunuKnnWO83NDMUzum9+mHSSGqv0fFD9r7s=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=QBXPtoxV+vVyS1Qy7tf9k5jCPndXuhDBFvVab65uRIOAwl3+UUsVjhrMNQUyMB0U9 XWrzecCBpSJSY9I7tZfg98E82DlruZ0nEfe9Ebj6o4hw7cfP8Pe9Q+pT9QLqmUv2MF Ua41VD2K+WiMR8pTxP61JOap3vM/LcNhERXRRRY+DpxhhBBzpTP9Aeobv0aIDhzjkt LXu0X0iGFgWDydnmQJB9nuxUQoIkHlJp/C8J7tRJjPzd2atq3+WOyGRtIVQ9deYEYD OKm6mRknWQLxRiZIP/r2Xv7wFQJOp3b+7oypEKXtTwIzx+piu5r8KAcEpn9MWFdc+x TQEXkVRPsIM2A== Message-ID: <58b23157c088cb4774d579cc8700de85.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20240402-pxa1908-lkml-v9-0-25a003e83c6f@skole.hr> <20240402-pxa1908-lkml-v9-5-25a003e83c6f@skole.hr> <3838e4684f98e1ce3818bfb6983844bc.sboyd@kernel.org> Subject: Re: [PATCH v9 5/9] clk: mmp: Add Marvell PXA1908 clock driver From: Stephen Boyd Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Karel Balej , David Wronek , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Catalin Marinas , Conor Dooley , Duje =?utf-8?q?Mihanovi=C4=87?= , Guilherme G. Piccoli , Haojian Zhuang , Kees Cook , Krzysztof Kozlowski , Linus Walleij , Lubomir Rintel , Michael Turquette , Rob Herring , Rob Herring , Tony Lindgren , Tony Luck , Will Deacon Date: Thu, 11 Apr 2024 19:57:09 -0700 User-Agent: alot/0.10 Quoting Duje Mihanovi=C4=87 (2024-04-11 03:15:34) > On 4/11/2024 10:00 AM, Stephen Boyd wrote: > >=20 > > Is there a reason this file can't be a platform driver? >=20 > Not that I know of, I did it like this only because the other in-tree=20 > MMP clk drivers do so. I guess the initialization should look like any=20 > of the qcom GCC drivers then? Yes. >=20 > While at it, do you think the other MMP clk drivers could use a conversio= n? >=20 Sure, go for it. I'm a little wary if the conversion cannot be tested though. It doesn't hurt that other drivers haven't been converted.